[PATCH] soc: qcom: socinfo: Add remaining IPQ6018 family ID-s

[PATCH] soc: qcom: socinfo: Add remaining IPQ6018 family ID-s

[Robert Marko]

ID for IPQ6018 was previously added, but ID-s for rest of the
family are missing.
So, lets add those based on downstream driver.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 drivers/soc/qcom/socinfo.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index f6cfb79338f0..28bbc7a9227e 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -255,6 +255,9 @@ static const struct soc_id soc_id[] = {
 	{ 351, "SDA450" },
 	{ 356, "SM8250" },
 	{ 402, "IPQ6018" },
+	{ 403, "IPQ6028" },
+	{ 421, "IPQ6000" },
+	{ 422, "IPQ6010" },
 	{ 425, "SC7180" },
 	{ 455, "QRB5165" },
 };
-- 
2.31.1

Re: [PATCH] soc: qcom: socinfo: Add remaining IPQ6018 family ID-s

[Kathiravan T]

On 2021-05-04 17:18, Robert Marko wrote:
> ID for IPQ6018 was previously added, but ID-s for rest of the
> family are missing.
> So, lets add those based on downstream driver.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Reviewed-by: Kathiravan T <kathirav@codeaurora.org>

Nit: May be you can add the IPQ6005(453) variant as well? or you want to 
add it later on need basis?

> ---
>  drivers/soc/qcom/socinfo.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index f6cfb79338f0..28bbc7a9227e 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -255,6 +255,9 @@ static const struct soc_id soc_id[] = {
>  	{ 351, "SDA450" },
>  	{ 356, "SM8250" },
>  	{ 402, "IPQ6018" },
> +	{ 403, "IPQ6028" },
> +	{ 421, "IPQ6000" },
> +	{ 422, "IPQ6010" },
>  	{ 425, "SC7180" },
>  	{ 455, "QRB5165" },
>  };

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCH] soc: qcom: socinfo: Add remaining IPQ6018 family ID-s

[Robert Marko]

On Mon, May 17, 2021 at 12:46 PM Kathiravan T <kathirav@codeaurora.org> wrote:
>
> On 2021-05-04 17:18, Robert Marko wrote:
> > ID for IPQ6018 was previously added, but ID-s for rest of the
> > family are missing.
> > So, lets add those based on downstream driver.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
>
> Reviewed-by: Kathiravan T <kathirav@codeaurora.org>
>
> Nit: May be you can add the IPQ6005(453) variant as well? or you want to
> add it later on need basis?
Hi, I completely missed that one.
I will send a v2 with it then.

Regards,
Robert
>
> > ---
> >  drivers/soc/qcom/socinfo.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> > index f6cfb79338f0..28bbc7a9227e 100644
> > --- a/drivers/soc/qcom/socinfo.c
> > +++ b/drivers/soc/qcom/socinfo.c
> > @@ -255,6 +255,9 @@ static const struct soc_id soc_id[] = {
> >       { 351, "SDA450" },
> >       { 356, "SM8250" },
> >       { 402, "IPQ6018" },
> > +     { 403, "IPQ6028" },
> > +     { 421, "IPQ6000" },
> > +     { 422, "IPQ6010" },
> >       { 425, "SC7180" },
> >       { 455, "QRB5165" },
> >  };
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> member of Code Aurora Forum, hosted by The Linux Foundation



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr