From: Joe Perches <joe@perches.com>
To: Aditya <yashsri421@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com
Subject: Re: [PATCH v3] checkpatch: add fix option for ASSIGNMENT_CONTINUATIONS
Date: Fri, 20 Nov 2020 09:26:52 -0800 [thread overview]
Message-ID: <08f164e93dc40e066e81c4021485d27d5ad5a6b7.camel@perches.com> (raw)
In-Reply-To: <48f56f40-a365-faac-542d-0e120fcf4365@gmail.com>
On Fri, 2020-11-20 at 16:11 +0530, Aditya wrote:
> On 17/11/20 10:48 pm, Aditya Srivastava wrote:
> > Currently, checkpatch warns us if an assignment operator is placed
> > at the start of a line and not at the end of previous line.
> >
> > E.g., running checkpatch on commit 8195b1396ec8 ("hv_netvsc: fix
> > deadlock on hotplug") reports:
> >
> > CHECK: Assignment operator '=' should be on the previous line
> > + struct netvsc_device *nvdev
> > + = container_of(w, struct netvsc_device, subchan_work);
> >
> > Provide a simple fix by appending assignment operator to the previous
> > line and removing from the current line, if both the lines are additions
> > (ie start with '+')
> >
> > Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
> > ---
> > Changes in v2:
> > add check if both the lines are additions (ie start with '+')
> >
> > Changes in v3:
> > quote $operator; test with division assignment operator ('/=')
> >
> > scripts/checkpatch.pl | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index c9aaaa443265..d5bc4d8e4f6c 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -3542,8 +3542,14 @@ sub process {
> >
> >
> > # check for assignments on the start of a line
> > if ($sline =~ /^\+\s+($Assignment)[^=]/) {
> > - CHK("ASSIGNMENT_CONTINUATIONS",
> > - "Assignment operator '$1' should be on the previous line\n" . $hereprev);
> > + my $operator = "$1";
> > + if (CHK("ASSIGNMENT_CONTINUATIONS",
> > + "Assignment operator '$1' should be on the previous line\n" . $hereprev) &&
> > + $fix && $prevrawline =~ /^\+/) {
> > + # add assignment operator to the previous line, remove from current line
> > + $fixed[$fixlinenr - 1] .= " $operator";
> > + $fixed[$fixlinenr] =~ s/$operator\s*//;
> > + }
> > }
> >
> >
> > # check for && or || at the start of a line
> >
>
> Hi Joe
> This patch probably got missed. Please review :)
Did you look at $Assignment? Did you see it can be /= ?
If it is, what happens in the $fixed[$fixlinenr] line?
next prev parent reply other threads:[~2020-11-20 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 17:18 [PATCH v3] checkpatch: add fix option for ASSIGNMENT_CONTINUATIONS Aditya Srivastava
2020-11-20 10:41 ` Aditya
2020-11-20 17:26 ` Joe Perches [this message]
2020-11-20 18:02 ` Aditya
2020-11-21 11:50 ` Aditya
2020-11-21 12:04 ` [PATCH v4] " Aditya Srivastava
2020-11-21 12:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08f164e93dc40e066e81c4021485d27d5ad5a6b7.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).