From: Aditya <yashsri421@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com
Subject: Re: [PATCH v3] checkpatch: add fix option for ASSIGNMENT_CONTINUATIONS
Date: Sat, 21 Nov 2020 17:20:51 +0530 [thread overview]
Message-ID: <1d7692d0-359f-6b6a-32d4-1627ebd8b100@gmail.com> (raw)
In-Reply-To: <6deacf63-a80f-67b5-0594-e5cb5e82f42b@gmail.com>
On 20/11/20 11:32 pm, Aditya wrote:
> On 20/11/20 10:56 pm, Joe Perches wrote:
>> On Fri, 2020-11-20 at 16:11 +0530, Aditya wrote:
>>> On 17/11/20 10:48 pm, Aditya Srivastava wrote:
>>>> Currently, checkpatch warns us if an assignment operator is placed
>>>> at the start of a line and not at the end of previous line.
>>>>
>>>> E.g., running checkpatch on commit 8195b1396ec8 ("hv_netvsc: fix
>>>> deadlock on hotplug") reports:
>>>>
>>>> CHECK: Assignment operator '=' should be on the previous line
>>>> + struct netvsc_device *nvdev
>>>> + = container_of(w, struct netvsc_device, subchan_work);
>>>>
>>>> Provide a simple fix by appending assignment operator to the previous
>>>> line and removing from the current line, if both the lines are additions
>>>> (ie start with '+')
>>>>
>>>> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
>>>> ---
>>>> Changes in v2:
>>>> add check if both the lines are additions (ie start with '+')
>>>>
>>>> Changes in v3:
>>>> quote $operator; test with division assignment operator ('/=')
>>>>
>>>> scripts/checkpatch.pl | 10 ++++++++--
>>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>>>> index c9aaaa443265..d5bc4d8e4f6c 100755
>>>> --- a/scripts/checkpatch.pl
>>>> +++ b/scripts/checkpatch.pl
>>>> @@ -3542,8 +3542,14 @@ sub process {
>>>>
>>>>
>>>> # check for assignments on the start of a line
>>>> if ($sline =~ /^\+\s+($Assignment)[^=]/) {
>>>> - CHK("ASSIGNMENT_CONTINUATIONS",
>>>> - "Assignment operator '$1' should be on the previous line\n" . $hereprev);
>>>> + my $operator = "$1";
>>>> + if (CHK("ASSIGNMENT_CONTINUATIONS",
>>>> + "Assignment operator '$1' should be on the previous line\n" . $hereprev) &&
>>>> + $fix && $prevrawline =~ /^\+/) {
>>>> + # add assignment operator to the previous line, remove from current line
>>>> + $fixed[$fixlinenr - 1] .= " $operator";
>>>> + $fixed[$fixlinenr] =~ s/$operator\s*//;
>>>> + }
>>>> }
>>>>
>>>>
>>>> # check for && or || at the start of a line
>>>>
>>>
>>> Hi Joe
>>> This patch probably got missed. Please review :)
>>
>> Did you look at $Assignment? Did you see it can be /= ?
>>
>
> Yes, I tested the patch with '/=' operator as well.
> As I could not find any occurrences in the past(over 4.13..5.8), I
> created an example for myself by modifying the above mentioned commit
> example i.e. commit 8195b1396ec8 ("hv_netvsc: fix deadlock on
> hotplug") as:
>
> + struct netvsc_device *nvdev
> + /= container_of(w, struct netvsc_device, subchan_work);
>
> [For Line 144 and 145(where the warning was reported for '=' earlier)]
>
> The fix changes these lines to:
> + struct netvsc_device *nvdev /=
> + container_of(w, struct netvsc_device, subchan_work);
>
> On retesting the patch with checkpatch.pl, it did not give this CHECK,
> nor did we add any new warning/error.
>
>> If it is, what happens in the $fixed[$fixlinenr] line?
>>
>
> In $fixed[$fixlinenr], we are just getting rid of the operator and any
> space(s) following it.
>
> What do you think?
>
I think I understood quoting incorrectly here. I had to use \Q.
I'll resend the modified patch with desired changes.
Sorry for inconvenience.
Thanks
Aditya
next prev parent reply other threads:[~2020-11-21 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 17:18 [PATCH v3] checkpatch: add fix option for ASSIGNMENT_CONTINUATIONS Aditya Srivastava
2020-11-20 10:41 ` Aditya
2020-11-20 17:26 ` Joe Perches
2020-11-20 18:02 ` Aditya
2020-11-21 11:50 ` Aditya [this message]
2020-11-21 12:04 ` [PATCH v4] " Aditya Srivastava
2020-11-21 12:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d7692d0-359f-6b6a-32d4-1627ebd8b100@gmail.com \
--to=yashsri421@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).