From: Georgi Djakov <georgi.djakov@linaro.org>
To: Felipe Balbi <balbi@kernel.org>, Matthias Kaehlcke <mka@chromium.org>
Cc: Sandeep Maheswaram <sanm@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Manu Gautam <mgautam@codeaurora.org>,
Chandana Kishori Chiluveru <cchiluve@codeaurora.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver
Date: Fri, 15 May 2020 09:11:18 +0300 [thread overview]
Message-ID: <090e48d7-7988-eea1-bf39-f6820578d354@linaro.org> (raw)
In-Reply-To: <87tv0h3fpv.fsf@kernel.org>
Hi,
On 5/15/20 08:54, Felipe Balbi wrote:
>
> Hi,
>
> Georgi Djakov <georgi.djakov@linaro.org> writes:
>> On 5/14/20 20:13, Matthias Kaehlcke wrote:
>>> On Thu, May 14, 2020 at 02:30:28PM +0300, Felipe Balbi wrote:
>>>> Felipe Balbi <balbi@kernel.org> writes:
>>>>
>>>>> Hi,
>>>>>
>>>>> Sandeep Maheswaram <sanm@codeaurora.org> writes:
>>>>>> +static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
>>>>>> +{
>>>>>> + struct device *dev = qcom->dev;
>>>>>> + int ret;
>>>>>> +
>>>>>> + if (!device_is_bound(&qcom->dwc3->dev))
>>>>>> + return -EPROBE_DEFER;
>>>>>
>>>>> this breaks allmodconfig. I'm dropping this series from my queue for
>>>>> this merge window.
>>>>
>>>> Sorry, I meant this patch ;-)
>>>
>>> I guess that's due to INTERCONNECT being a module. There is currently a
>>
>> I believe it's because of this:
>> ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!
>>
>>> discussion about this with Viresh and Georgi in response to another
>>> automated build failure. Viresh suggests changing CONFIG_INTERCONNECT
>>> from tristate to bool, which seems sensible to me given that interconnect
>>> is a core subsystem.
>>
>> The problem you are talking about would arise when INTERCONNECT=m and
>> USB_DWC3_QCOM=y and it definitely exists here and could be triggered with
>> randconfig build. So i suggest to squash also the diff below.
>>
>> Thanks,
>> Georgi
>>
>> ---8<---
>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>> index 206caa0ea1c6..6661788b1a76 100644
>> --- a/drivers/usb/dwc3/Kconfig
>> +++ b/drivers/usb/dwc3/Kconfig
>> @@ -129,6 +129,7 @@ config USB_DWC3_QCOM
>> tristate "Qualcomm Platform"
>> depends on ARCH_QCOM || COMPILE_TEST
>> depends on EXTCON || !EXTCON
>> + depends on INTERCONNECT || !INTERCONNECT
>
> I would prefer to see a patch adding EXPORT_SYMBOL_GPL() to device_is_bound()
Agree, but just to clarify, that these are two separate issues that need to
be fixed. The device_is_bound() is the first one and USB_DWC3_QCOM=y combined
with INTERCONNECT=m is the second one.
Thanks,
Georgi
next prev parent reply other threads:[~2020-05-15 6:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 5:15 [PATCH v7 0/4] ADD interconnect support for Qualcomm DWC3 driver Sandeep Maheswaram
2020-04-01 5:15 ` [PATCH v7 1/4] dt-bindings: usb: qcom,dwc3: Introduce interconnect properties " Sandeep Maheswaram
2020-04-14 15:22 ` Rob Herring
2020-04-14 20:30 ` Stephen Boyd
2020-04-01 5:15 ` [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver Sandeep Maheswaram
2020-05-14 11:29 ` Felipe Balbi
2020-05-14 11:30 ` Felipe Balbi
2020-05-14 17:13 ` Matthias Kaehlcke
2020-05-14 21:02 ` Georgi Djakov
2020-05-15 3:57 ` Viresh Kumar
2020-05-15 4:23 ` Manu Gautam
2020-05-15 4:26 ` Viresh Kumar
2020-05-15 5:54 ` Felipe Balbi
2020-05-15 6:11 ` Georgi Djakov [this message]
2020-05-15 6:29 ` Felipe Balbi
2020-05-18 18:35 ` Bjorn Andersson
2020-05-19 3:29 ` Viresh Kumar
2020-05-26 11:04 ` Sandeep Maheswaram (Temp)
2020-05-26 11:34 ` Georgi Djakov
2020-05-26 11:43 ` Felipe Balbi
2020-05-28 9:24 ` Sandeep Maheswaram (Temp)
2020-06-03 17:36 ` Stephen Boyd
2020-06-04 9:43 ` Sandeep Maheswaram (Temp)
2020-06-04 11:16 ` Stephen Boyd
2020-06-15 19:42 ` Matthias Kaehlcke
2020-06-16 4:52 ` Sandeep Maheswaram (Temp)
2020-06-16 20:38 ` Matthias Kaehlcke
2020-06-30 22:42 ` Matthias Kaehlcke
2020-07-07 5:11 ` Sandeep Maheswaram (Temp)
2020-07-07 15:52 ` Matthias Kaehlcke
2020-04-01 5:15 ` [PATCH v7 3/4] arm64: dts: qcom: sdm845: Add interconnect properties for USB Sandeep Maheswaram
2020-04-14 20:31 ` Stephen Boyd
2020-04-01 5:15 ` [PATCH v7 4/4] arm64: dts: qcom: sc7180: " Sandeep Maheswaram
2020-04-14 20:32 ` Stephen Boyd
2020-04-29 18:35 ` [PATCH v7 0/4] ADD interconnect support for Qualcomm DWC3 driver Matthias Kaehlcke
2020-05-08 6:29 ` Sandeep Maheswaram (Temp)
2020-05-14 10:49 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=090e48d7-7988-eea1-bf39-f6820578d354@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cchiluve@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sanm@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).