Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

From: Felipe Balbi <balbi@kernel.org>
To: Georgi Djakov <georgi.djakov@linaro.org>,
	Matthias Kaehlcke <mka@chromium.org>
Cc: Sandeep Maheswaram <sanm@codeaurora.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Boyd <swboyd@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Manu Gautam <mgautam@codeaurora.org>,
	Chandana Kishori Chiluveru <cchiluve@codeaurora.org>,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver
Date: Fri, 15 May 2020 08:54:52 +0300	[thread overview]
Message-ID: <87tv0h3fpv.fsf@kernel.org> (raw)
In-Reply-To: <abbc3f8c-c8c9-c189-735e-f8058dab3e40@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1851 bytes --]


Hi,

Georgi Djakov <georgi.djakov@linaro.org> writes:
> On 5/14/20 20:13, Matthias Kaehlcke wrote:
>> On Thu, May 14, 2020 at 02:30:28PM +0300, Felipe Balbi wrote:
>>> Felipe Balbi <balbi@kernel.org> writes:
>>>
>>>> Hi,
>>>>
>>>> Sandeep Maheswaram <sanm@codeaurora.org> writes:
>>>>> +static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
>>>>> +{
>>>>> +	struct device *dev = qcom->dev;
>>>>> +	int ret;
>>>>> +
>>>>> +	if (!device_is_bound(&qcom->dwc3->dev))
>>>>> +		return -EPROBE_DEFER;
>>>>
>>>> this breaks allmodconfig. I'm dropping this series from my queue for
>>>> this merge window.
>>>
>>> Sorry, I meant this patch ;-)
>> 
>> I guess that's due to INTERCONNECT being a module. There is currently a
>
> I believe it's because of this:
> ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!
>
>> discussion about this  with Viresh and Georgi in response to another
>> automated build failure. Viresh suggests changing CONFIG_INTERCONNECT
>> from tristate to bool, which seems sensible to me given that interconnect
>> is a core subsystem.
>
> The problem you are talking about would arise when INTERCONNECT=m and
> USB_DWC3_QCOM=y and it definitely exists here and could be triggered with
> randconfig build. So i suggest to squash also the diff below.
>
> Thanks,
> Georgi
>
> ---8<---
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 206caa0ea1c6..6661788b1a76 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -129,6 +129,7 @@ config USB_DWC3_QCOM
>  	tristate "Qualcomm Platform"
>  	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on EXTCON || !EXTCON
> +	depends on INTERCONNECT || !INTERCONNECT

I would prefer to see a patch adding EXPORT_SYMBOL_GPL() to device_is_bound()

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]