linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
	thierry.reding@gmail.com, jonathanh@nvidia.com,
	sakari.ailus@iki.fi, hverkuil@xs4all.nl,
	jacopo+renesas@jmondi.org, leonl@leopardimaging.com,
	robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies
Date: Wed, 2 Sep 2020 08:52:19 +0200	[thread overview]
Message-ID: <09270110-39ca-7232-0848-c5c338de8552@lucaceresoli.net> (raw)
In-Reply-To: <7ce6003c-a27d-5831-66a1-832db0114188@lucaceresoli.net>

Hi again...

On 02/09/20 08:46, Luca Ceresoli wrote:
> Hi Sowjanya,
> 
> On 02/09/20 04:04, Sowjanya Komatineni wrote:
>> This patch adds IMX274 optional external clock input and voltage
>> supplies to device tree bindings.
>>
>> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>>  .../devicetree/bindings/media/i2c/sony,imx274.yaml  | 21 +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>> index 7ae47a6..57e7176 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>> @@ -25,6 +25,27 @@ properties:
>>    reset-gpios:
>>      maxItems: 1
>>  
>> +  clocks:
>> +    maxItems: 1
>> +    description: Reference to the sensor input clock
>> +
>> +  clock-names:
>> +    maxItems: 1
>> +    items:
>> +      - const: inck
> 
> I think this can be simpler:
> 
>   clock-names:
>     maxItems: 1
>     items:
>       - const: inck

Which is equal to the original... copy-paste-and-forgot.

Here's the simplified form, for real:

  clocks:
    maxItems: 1
  clock-names:
    const: inck

As in:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml?h=v5.9-rc3#n90


-- 
Luca

  reply	other threads:[~2020-09-02  6:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02  2:04 [PATCH v5 0/3] IMX274 fixes and power on and off implementation Sowjanya Komatineni
2020-09-02  2:04 ` [PATCH v5 1/3] media: i2c: imx274: Fix Y_OUT_SIZE register setting Sowjanya Komatineni
2020-09-02  2:04 ` [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies Sowjanya Komatineni
2020-09-02  6:46   ` Luca Ceresoli
2020-09-02  6:52     ` Luca Ceresoli [this message]
2020-09-03 12:55   ` Jacopo Mondi
2020-09-03 16:05     ` Sowjanya Komatineni
2020-09-03 16:35       ` Jacopo Mondi
2020-09-03 16:40         ` Sowjanya Komatineni
2020-09-08  9:33           ` Sakari Ailus
2020-09-08 14:34             ` Jacopo Mondi
2020-09-08 18:10               ` Sowjanya Komatineni
2020-09-02  2:04 ` [PATCH v5 3/3] media: i2c: imx274: Add IMX274 power on and off sequence Sowjanya Komatineni
2020-09-03 15:03   ` Jacopo Mondi
2020-09-03 16:25     ` Sowjanya Komatineni
2020-09-04  8:55       ` Jacopo Mondi
     [not found]         ` <5ebe8d22-86fb-7bf2-ab19-e729caf8d88f@nvidia.com>
2020-09-07  7:48           ` Jacopo Mondi
2020-09-08 18:13             ` Sowjanya Komatineni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09270110-39ca-7232-0848-c5c338de8552@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil@xs4all.nl \
    --cc=jacopo+renesas@jmondi.org \
    --cc=jonathanh@nvidia.com \
    --cc=leonl@leopardimaging.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@iki.fi \
    --cc=skomatineni@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).