From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: <skomatineni@nvidia.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <sakari.ailus@iki.fi>,
<hverkuil@xs4all.nl>, <jacopo+renesas@jmondi.org>,
<luca@lucaceresoli.net>, <leonl@leopardimaging.com>,
<robh+dt@kernel.org>, <lgirdwood@gmail.com>, <broonie@kernel.org>
Cc: <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v5 1/3] media: i2c: imx274: Fix Y_OUT_SIZE register setting
Date: Tue, 1 Sep 2020 19:04:36 -0700 [thread overview]
Message-ID: <1599012278-10203-2-git-send-email-skomatineni@nvidia.com> (raw)
In-Reply-To: <1599012278-10203-1-git-send-email-skomatineni@nvidia.com>
As per Sony IMX274 Y_OUT_SIZE should be the height of effective
image output from the sensor which are the actual total lines
sent over MIPI CSI to receiver.
So, Y_OUT_SIZE should be same as crop height and this patch fixes it.
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 6011cec..a4b9dfd 100644
--- a/drivers/media/i2c/imx274.c
+++ b/drivers/media/i2c/imx274.c
@@ -1163,7 +1163,7 @@ static int imx274_apply_trimming(struct stimx274 *imx274)
(-imx274->crop.top / 2) : (imx274->crop.top / 2);
v_cut = (IMX274_MAX_HEIGHT - imx274->crop.height) / 2;
write_v_size = imx274->crop.height + 22;
- y_out_size = imx274->crop.height + 14;
+ y_out_size = imx274->crop.height;
err = imx274_write_mbreg(imx274, IMX274_HMAX_REG_LSB, hmax, 2);
if (!err)
--
2.7.4
next prev parent reply other threads:[~2020-09-02 2:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 2:04 [PATCH v5 0/3] IMX274 fixes and power on and off implementation Sowjanya Komatineni
2020-09-02 2:04 ` Sowjanya Komatineni [this message]
2020-09-02 2:04 ` [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies Sowjanya Komatineni
2020-09-02 6:46 ` Luca Ceresoli
2020-09-02 6:52 ` Luca Ceresoli
2020-09-03 12:55 ` Jacopo Mondi
2020-09-03 16:05 ` Sowjanya Komatineni
2020-09-03 16:35 ` Jacopo Mondi
2020-09-03 16:40 ` Sowjanya Komatineni
2020-09-08 9:33 ` Sakari Ailus
2020-09-08 14:34 ` Jacopo Mondi
2020-09-08 18:10 ` Sowjanya Komatineni
2020-09-02 2:04 ` [PATCH v5 3/3] media: i2c: imx274: Add IMX274 power on and off sequence Sowjanya Komatineni
2020-09-03 15:03 ` Jacopo Mondi
2020-09-03 16:25 ` Sowjanya Komatineni
2020-09-04 8:55 ` Jacopo Mondi
[not found] ` <5ebe8d22-86fb-7bf2-ab19-e729caf8d88f@nvidia.com>
2020-09-07 7:48 ` Jacopo Mondi
2020-09-08 18:13 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599012278-10203-2-git-send-email-skomatineni@nvidia.com \
--to=skomatineni@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=jonathanh@nvidia.com \
--cc=leonl@leopardimaging.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).