From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Darren Hart <dvhart@infradead.org>, Takashi Iwai <tiwai@suse.com>
Cc: "Michał Kępień" <kernel@kempniu.pl>,
"Richard Purdie" <rpurdie@rpsys.net>,
"Pavel Machek" <pavel@ucw.cz>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Anthony Wong" <anthony.wong@canonical.com>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86
Date: Tue, 17 Jan 2017 22:20:29 +0100 [thread overview]
Message-ID: <0989ec2f-c776-13f5-3933-0cb60b36f8ed@gmail.com> (raw)
In-Reply-To: <20170116132204.6421-1-kernel@kempniu.pl>
Hi Darren,
Are you OK with the patches 4/6 and 6/6? If so, could you give
your ack so that I could apply the whole patch set to the LED tree?
Best regards,
Jacek Anaszewski
On 01/16/2017 02:21 PM, Michał Kępień wrote:
> This patch series moves the dell-led driver from the LED subsystem to
> the x86 platform driver subsystem.
>
> The original motivation behind this effort was to move all code using
> the dell-smbios module to the x86 platform driver subsystem. While I
> was investigating the possibilities to do that, it quickly emerged that
> dell-led can and in fact should be moved to the x86 platform driver
> subsystem in its entirety.
>
> dell-led consists of two major parts:
>
> - the part exposing a microphone mute LED interface, introduced in
> db6d8cc00773 ("dell-led: add mic mute led interface"); this
> interface is used by sound/pci/hda/dell_wmi_helper.c; while the
> original implementation used a WMI interface, it was changed to use
> dell-smbios in cf0d7ea33596 ("dell-led: use dell_smbios_find_token()
> for finding mic DMI tokens") and 0c41a08e131d ("dell-led: use
> dell_smbios_send_request() for performing SMBIOS calls"),
>
> - the part handling an activity LED present in Dell Latitude 2100
> netbooks, introduced in 72dcd8d08aca ("leds: Add Dell Business Class
> Netbook LED driver"); it binds to a specific WMI GUID and then
> registers a LED device which is controlled using WMI (i.e. it is
> essentially a WMI driver).
>
> Patches 1 and 2 clean up the microphone mute LED interface to minimize
> the amount of code moved around.
>
> Patch 3 updates a variable name in sound/pci/hda/dell_wmi_helper.c so
> that it better matches that variable's role.
>
> Patch 4 moves the microphone mute LED interface to
> drivers/platform/x86/dell-laptop.c, effectively causing
> sound/pci/hda/dell_wmi_helper.c to depend on CONFIG_DELL_LAPTOP instead
> of CONFIG_LEDS_DELL_NETBOOKS.
>
> Patch 5 reverts dell-led to the state it was in after its initial commit
> 72dcd8d08aca ("leds: Add Dell Business Class Netbook LED driver") by
> removing all remnants of the microphone mute LED handling code.
>
> Patch 6 moves all that is left of dell-led (i.e. the activity LED part,
> as originally implemented), to a new module which is placed in
> drivers/platform/x86/dell-wmi-led.c.
>
> As all patches except patch 3 in this series affect the LED subsystem,
> the series is based on linux-leds/for-4.11.
>
> Anthony, I would be grateful if you could test this patch series on the
> Dell machines you have access to that were previously supported by
> dell-led as Jacek needs a Tested-by from someone to sign off on these
> changes. Please note the Kconfig option rename done by the last patch.
> Thanks!
>
> Changes from v1:
>
> - Squash patches 2-4 from v1 into a single patch (#2 in v2).
>
> - Add patch 3.
>
> - Fix subject pattern in patch 4.
>
> - Slight commit message adjustments, including fixing a typo
> ("COFIG_LEDS_DELL_NETBOOKS") in patch 6.
>
> - Remove the name of the module's source file from the header comment
> in drivers/platform/x86/dell-wmi-led.c to avoid the need to update
> it in the future.
>
> drivers/leds/Kconfig | 9 ---
> drivers/leds/Makefile | 1 -
> drivers/platform/x86/Kconfig | 8 +++
> drivers/platform/x86/Makefile | 1 +
> drivers/platform/x86/dell-laptop.c | 28 ++++++++
> .../dell-led.c => platform/x86/dell-wmi-led.c} | 75 ++--------------------
> include/linux/dell-led.h | 6 +-
> sound/pci/hda/dell_wmi_helper.c | 30 ++++-----
> 8 files changed, 60 insertions(+), 98 deletions(-)
> rename drivers/{leds/dell-led.c => platform/x86/dell-wmi-led.c} (73%)
>
next prev parent reply other threads:[~2017-01-17 21:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 13:21 [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Michał Kępień
2017-01-16 13:21 ` [PATCH v2 1/6] dell-led: remove GUID check from dell_micmute_led_set() Michał Kępień
2017-01-16 13:22 ` [PATCH v2 2/6] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set() Michał Kępień
2017-01-16 13:22 ` [PATCH v2 3/6] ALSA: hda - rename dell_led_set_func to dell_micmute_led_set_func Michał Kępień
2017-01-17 11:12 ` Pali Rohár
2017-01-17 21:20 ` Jacek Anaszewski
2017-01-16 13:22 ` [PATCH v2 4/6] platform/x86: dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c Michał Kępień
2017-01-17 11:23 ` Pali Rohár
2017-01-18 19:12 ` Andy Shevchenko
2017-01-16 13:22 ` [PATCH v2 5/6] dell-led: remove code related to mic mute LED Michał Kępień
2017-01-17 11:24 ` Pali Rohár
2017-01-16 13:22 ` [PATCH v2 6/6] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c Michał Kępień
2017-01-16 20:49 ` Jacek Anaszewski
2017-01-17 11:08 ` Pavel Machek
2017-01-17 11:28 ` Pali Rohár
2017-01-18 19:08 ` Andy Shevchenko
2017-01-17 7:17 ` [PATCH v2 6+/6] platform/x86: dell-wmi-led: fix coding style issues Michał Kępień
2017-01-17 8:21 ` Joe Perches
2017-01-17 9:19 ` Michał Kępień
2017-01-17 21:20 ` Jacek Anaszewski
2017-01-17 11:08 ` Pavel Machek
2017-01-18 19:06 ` Andy Shevchenko
2017-01-17 21:20 ` Jacek Anaszewski [this message]
2017-02-13 11:26 ` [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Michał Kępień
2017-02-15 11:56 ` Alex Hung
2017-02-15 13:54 ` Michał Kępień
2017-02-15 14:31 ` Alex Hung
2017-02-15 15:12 ` Pali Rohár
2017-02-16 9:33 ` Michał Kępień
2017-02-16 9:27 ` Michał Kępień
2017-02-16 10:35 ` Alex Hung
2017-02-16 11:32 ` Michał Kępień
2017-02-16 11:38 ` Alex Hung
2017-02-16 11:41 ` Andy Shevchenko
2017-02-16 12:01 ` Michał Kępień
2017-02-16 13:11 ` Andy Shevchenko
2017-02-16 22:11 ` Jacek Anaszewski
2017-02-15 20:28 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0989ec2f-c776-13f5-3933-0cb60b36f8ed@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=anthony.wong@canonical.com \
--cc=dvhart@infradead.org \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).