* [PATCH RESEND] KVM: x86: Expose CLDEMOTE CPU feature to guest VM
@ 2018-05-22 9:01 Jingqi Liu
2018-06-04 7:19 ` Liu, Jingqi
0 siblings, 1 reply; 3+ messages in thread
From: Jingqi Liu @ 2018-05-22 9:01 UTC (permalink / raw)
To: kvm
Cc: pbonzini, rkrcmar, tglx, mingo, hpa, x86, linux-kernel,
wei.w.wang, Jingqi Liu
The CLDEMOTE instruction hints to hardware that the cache line that
contains the linear address should be moved("demoted") from
the cache(s) closest to the processor core to a level more distant
from the processor core. This may accelerate subsequent accesses
to the line by other cores in the same coherence domain,
especially if the line was written by the core that demotes the line.
This patch exposes the cldemote feature to the guest.
The release document ref below link:
https://software.intel.com/sites/default/files/managed/c5/15/\
architecture-instruction-set-extensions-programming-reference.pdf
This patch has a dependency on https://lkml.org/lkml/2018/4/23/928
Signed-off-by: Jingqi Liu <jingqi.liu@intel.com>
---
arch/x86/kvm/cpuid.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index 82055b9..72d8c49 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -403,7 +403,8 @@ static inline int __do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
const u32 kvm_cpuid_7_0_ecx_x86_features =
F(AVX512VBMI) | F(LA57) | F(PKU) | 0 /*OSPKE*/ |
F(AVX512_VPOPCNTDQ) | F(UMIP) | F(AVX512_VBMI2) | F(GFNI) |
- F(VAES) | F(VPCLMULQDQ) | F(AVX512_VNNI) | F(AVX512_BITALG);
+ F(VAES) | F(VPCLMULQDQ) | F(AVX512_VNNI) | F(AVX512_BITALG) |
+ F(CLDEMOTE);
/* cpuid 7.0.edx*/
const u32 kvm_cpuid_7_0_edx_x86_features =
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH RESEND] KVM: x86: Expose CLDEMOTE CPU feature to guest VM
2018-05-22 9:01 [PATCH RESEND] KVM: x86: Expose CLDEMOTE CPU feature to guest VM Jingqi Liu
@ 2018-06-04 7:19 ` Liu, Jingqi
2018-06-13 16:23 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Liu, Jingqi @ 2018-06-04 7:19 UTC (permalink / raw)
To: pbonzini; +Cc: kvm, rkrcmar, tglx, mingo, hpa, x86, linux-kernel, Wang, Wei W
Hi Paolo,
I had changed the Signed-off-by chain.
Could you help to review?
Thanks.
On 5/22/2018 5:01 PM, Liu, Jingqi wrote:
>
> The CLDEMOTE instruction hints to hardware that the cache line that contains
> the linear address should be moved("demoted") from the cache(s) closest to the
> processor core to a level more distant from the processor core. This may
> accelerate subsequent accesses to the line by other cores in the same coherence
> domain, especially if the line was written by the core that demotes the line.
>
> This patch exposes the cldemote feature to the guest.
>
> The release document ref below link:
> https://software.intel.com/sites/default/files/managed/c5/15/\
> architecture-instruction-set-extensions-programming-reference.pdf
> This patch has a dependency on https://lkml.org/lkml/2018/4/23/928
>
> Signed-off-by: Jingqi Liu <jingqi.liu@intel.com>
> ---
> arch/x86/kvm/cpuid.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index
> 82055b9..72d8c49 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -403,7 +403,8 @@ static inline int __do_cpuid_ent(struct
> kvm_cpuid_entry2 *entry, u32 function,
> const u32 kvm_cpuid_7_0_ecx_x86_features =
> F(AVX512VBMI) | F(LA57) | F(PKU) | 0 /*OSPKE*/ |
> F(AVX512_VPOPCNTDQ) | F(UMIP) | F(AVX512_VBMI2) | F(GFNI)
> |
> - F(VAES) | F(VPCLMULQDQ) | F(AVX512_VNNI) |
> F(AVX512_BITALG);
> + F(VAES) | F(VPCLMULQDQ) | F(AVX512_VNNI) |
> F(AVX512_BITALG) |
> + F(CLDEMOTE);
>
> /* cpuid 7.0.edx*/
> const u32 kvm_cpuid_7_0_edx_x86_features =
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] KVM: x86: Expose CLDEMOTE CPU feature to guest VM
2018-06-04 7:19 ` Liu, Jingqi
@ 2018-06-13 16:23 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2018-06-13 16:23 UTC (permalink / raw)
To: Liu, Jingqi
Cc: kvm, rkrcmar, tglx, mingo, hpa, x86, linux-kernel, Wang, Wei W
On 04/06/2018 09:19, Liu, Jingqi wrote:
> Hi Paolo,
>
> I had changed the Signed-off-by chain.
> Could you help to review?
> Thanks.
The patch has been applied, thanks.
Paolo
> On 5/22/2018 5:01 PM, Liu, Jingqi wrote:
>
>>
>> The CLDEMOTE instruction hints to hardware that the cache line that contains
>> the linear address should be moved("demoted") from the cache(s) closest to the
>> processor core to a level more distant from the processor core. This may
>> accelerate subsequent accesses to the line by other cores in the same coherence
>> domain, especially if the line was written by the core that demotes the line.
>>
>> This patch exposes the cldemote feature to the guest.
>>
>> The release document ref below link:
>> https://software.intel.com/sites/default/files/managed/c5/15/\
>> architecture-instruction-set-extensions-programming-reference.pdf
>> This patch has a dependency on https://lkml.org/lkml/2018/4/23/928
>>
>> Signed-off-by: Jingqi Liu <jingqi.liu@intel.com>
>> ---
>> arch/x86/kvm/cpuid.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index
>> 82055b9..72d8c49 100644
>> --- a/arch/x86/kvm/cpuid.c
>> +++ b/arch/x86/kvm/cpuid.c
>> @@ -403,7 +403,8 @@ static inline int __do_cpuid_ent(struct
>> kvm_cpuid_entry2 *entry, u32 function,
>> const u32 kvm_cpuid_7_0_ecx_x86_features =
>> F(AVX512VBMI) | F(LA57) | F(PKU) | 0 /*OSPKE*/ |
>> F(AVX512_VPOPCNTDQ) | F(UMIP) | F(AVX512_VBMI2) | F(GFNI)
>> |
>> - F(VAES) | F(VPCLMULQDQ) | F(AVX512_VNNI) |
>> F(AVX512_BITALG);
>> + F(VAES) | F(VPCLMULQDQ) | F(AVX512_VNNI) |
>> F(AVX512_BITALG) |
>> + F(CLDEMOTE);
>>
>> /* cpuid 7.0.edx*/
>> const u32 kvm_cpuid_7_0_edx_x86_features =
>> --
>> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-13 16:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 9:01 [PATCH RESEND] KVM: x86: Expose CLDEMOTE CPU feature to guest VM Jingqi Liu
2018-06-04 7:19 ` Liu, Jingqi
2018-06-13 16:23 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).