* [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15
@ 2012-09-06 15:21 Daniel Kurtz
2012-09-06 15:43 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Kurtz @ 2012-09-06 15:21 UTC (permalink / raw)
To: Kukjin Kim, Russell King, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Cc: Thomas Abraham, olofj, dianders, Daniel Kurtz
chained_irq_enter/exit() already mask&ack/unmask the chained interrupt.
There is no need to also explicitly do it in the handler.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
---
arch/arm/mach-exynos/common.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
index 4eb39cd..0a85aec 100644
--- a/arch/arm/mach-exynos/common.c
+++ b/arch/arm/mach-exynos/common.c
@@ -965,14 +965,7 @@ static void exynos_irq_eint0_15(unsigned int irq, struct irq_desc *desc)
struct irq_chip *chip = irq_get_chip(irq);
chained_irq_enter(chip, desc);
- chip->irq_mask(&desc->irq_data);
-
- if (chip->irq_ack)
- chip->irq_ack(&desc->irq_data);
-
generic_handle_irq(*irq_data);
-
- chip->irq_unmask(&desc->irq_data);
chained_irq_exit(chip, desc);
}
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15
2012-09-06 15:21 [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15 Daniel Kurtz
@ 2012-09-06 15:43 ` Doug Anderson
2012-09-19 23:59 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2012-09-06 15:43 UTC (permalink / raw)
To: Daniel Kurtz
Cc: Kukjin Kim, Russell King, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Thomas Abraham, olofj
On Thu, Sep 6, 2012 at 8:21 AM, Daniel Kurtz <djkurtz@chromium.org> wrote:
> chained_irq_enter/exit() already mask&ack/unmask the chained interrupt.
> There is no need to also explicitly do it in the handler.
>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> ---
> arch/arm/mach-exynos/common.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index 4eb39cd..0a85aec 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -965,14 +965,7 @@ static void exynos_irq_eint0_15(unsigned int irq, struct irq_desc *desc)
> struct irq_chip *chip = irq_get_chip(irq);
>
> chained_irq_enter(chip, desc);
> - chip->irq_mask(&desc->irq_data);
> -
> - if (chip->irq_ack)
> - chip->irq_ack(&desc->irq_data);
> -
> generic_handle_irq(*irq_data);
> -
> - chip->irq_unmask(&desc->irq_data);
> chained_irq_exit(chip, desc);
> }
>
> --
> 1.7.7.3
>
Acked-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15
2012-09-06 15:43 ` Doug Anderson
@ 2012-09-19 23:59 ` Kukjin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2012-09-19 23:59 UTC (permalink / raw)
To: 'Doug Anderson', 'Daniel Kurtz'
Cc: 'Russell King',
linux-arm-kernel, linux-samsung-soc, linux-kernel,
'Thomas Abraham',
olofj
Doug Anderson wrote:
>
> On Thu, Sep 6, 2012 at 8:21 AM, Daniel Kurtz <djkurtz@chromium.org> wrote:
> > chained_irq_enter/exit() already mask&ack/unmask the chained interrupt.
> > There is no need to also explicitly do it in the handler.
> >
> > Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> > ---
> > arch/arm/mach-exynos/common.c | 7 -------
> > 1 files changed, 0 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-
> exynos/common.c
> > index 4eb39cd..0a85aec 100644
> > --- a/arch/arm/mach-exynos/common.c
> > +++ b/arch/arm/mach-exynos/common.c
> > @@ -965,14 +965,7 @@ static void exynos_irq_eint0_15(unsigned int irq,
> struct irq_desc *desc)
> > struct irq_chip *chip = irq_get_chip(irq);
> >
> > chained_irq_enter(chip, desc);
> > - chip->irq_mask(&desc->irq_data);
> > -
> > - if (chip->irq_ack)
> > - chip->irq_ack(&desc->irq_data);
> > -
> > generic_handle_irq(*irq_data);
> > -
> > - chip->irq_unmask(&desc->irq_data);
> > chained_irq_exit(chip, desc);
> > }
> >
> > --
> > 1.7.7.3
> >
>
> Acked-by: Doug Anderson <dianders@chromium.org>
Yes, will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-19 23:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-06 15:21 [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15 Daniel Kurtz
2012-09-06 15:43 ` Doug Anderson
2012-09-19 23:59 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).