[PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits

[PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits

[Andy Shevchenko]

According to documentation the function has 2 bits for reset
while iDMA 64-bit has only one.

Rename it accordingly. Note, there is no functional change since
we always handle them together.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mfd/intel-lpss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 4bcf117a7ba8..50bffc3382d7 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -40,8 +40,8 @@
 
 /* Offsets from lpss->priv */
 #define LPSS_PRIV_RESETS		0x04
-#define LPSS_PRIV_RESETS_FUNC		BIT(2)
-#define LPSS_PRIV_RESETS_IDMA		0x3
+#define LPSS_PRIV_RESETS_IDMA		BIT(2)
+#define LPSS_PRIV_RESETS_FUNC		0x3
 
 #define LPSS_PRIV_ACTIVELTR		0x10
 #define LPSS_PRIV_IDLELTR		0x14
-- 
2.17.0

Re: [PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits

[Mika Westerberg]

On Tue, Apr 24, 2018 at 06:05:12PM +0300, Andy Shevchenko wrote:
> According to documentation the function has 2 bits for reset
> while iDMA 64-bit has only one.
> 
> Rename it accordingly. Note, there is no functional change since
> we always handle them together.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits

[Andy Shevchenko]

On Wed, 2018-04-25 at 13:26 +0300, Mika Westerberg wrote:
> On Tue, Apr 24, 2018 at 06:05:12PM +0300, Andy Shevchenko wrote:
> > According to documentation the function has 2 bits for reset
> > while iDMA 64-bit has only one.
> > 
> > Rename it accordingly. Note, there is no functional change since
> > we always handle them together.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Thanks, Mika!

Lee, anything about this one? (it's not stable material, though I don't
see it in linux-next)

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Re: [PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits

[Lee Jones]

On Tue, 24 Apr 2018, Andy Shevchenko wrote:

> According to documentation the function has 2 bits for reset
> while iDMA 64-bit has only one.
> 
> Rename it accordingly. Note, there is no functional change since
> we always handle them together.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mfd/intel-lpss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog