From: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To: Kalle Valo <kvalo@codeaurora.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Wireless <linux-wireless@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Sharon, Sara" <sara.sharon@intel.com>,
"Coelho, Luciano" <luciano.coelho@intel.com>,
Kees Cook <keescook@google.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
"David Miller" <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>
Subject: RE: linux-next: build warnings after merge of the wireless-drivers-next tree
Date: Wed, 19 Dec 2018 08:31:54 +0000 [thread overview]
Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB3013375F96C@HASMSX112.ger.corp.intel.com> (raw)
In-Reply-To: <871s6evtra.fsf@kamboji.qca.qualcomm.com>
>
> Stephen Rothwell <sfr@canb.auug.org.au> writes:
>
> > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> >>
> >> After merging the wireless-drivers-next tree, today's linux-next
> >> build
> >> (x86_64 allmodconfig) produced these warnings:
> >>
> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function
> 'iwl_parse_tlv_firmware':
> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this
> statement may fall through [-Wimplicit-fallthrough=]
> >> if (iwlwifi_mod_params.enable_ini)
> >> ^
> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
> >> default:
> >> ^~~~~~~
> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function
> 'iwl_parse_fw_dbg_tlv':
> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this
> statement may fall through [-Wimplicit-fallthrough=]
> >> iwl_fw_dbg_copy_tlv(trans, tlv, true);
> >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
> >> default:
> >> ^~~~~~~
> >>
> >> Introduced by commit
> >>
> >> f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
> >>
> >> These are noted because I use -Wimplict-fallthrough
> >>
> >> The warnings can be suppressed by adding a comment like
> >> /* fall through */
> >> at the appropriate place to indicate that the fallthough is intended.
> >
> > I am still seeing these warnings (but in the net-next tree now) and I
> > do not see a fix patch in the wireless-drivers-next tree.
>
> Luca did submit a patch[1] for cfg80211 to fix those but I don't see any
> patches for iwlwifi (even in the one pending pull request he sent), not sure
> what happened. I know that Luca is already on holidays but adding
> Emmanuel, maybe he can help here?
>
Just sent a patch.
next prev parent reply other threads:[~2018-12-19 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 1:05 linux-next: build warnings after merge of the wireless-drivers-next tree Stephen Rothwell
2018-11-30 4:33 ` Kalle Valo
2018-11-30 5:50 ` Stephen Rothwell
2018-11-30 7:43 ` Kalle Valo
2018-12-03 12:38 ` Luciano Coelho
2018-12-03 15:15 ` Gustavo A. R. Silva
2018-12-19 2:47 ` Stephen Rothwell
2018-12-19 7:51 ` Kalle Valo
2018-12-19 8:31 ` Grumbach, Emmanuel [this message]
2018-12-19 10:27 ` Luca Coelho
2018-12-19 12:40 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0BA3FCBA62E2DC44AF3030971E174FB3013375F96C@HASMSX112.ger.corp.intel.com \
--to=emmanuel.grumbach@intel.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=keescook@google.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sara.sharon@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).