linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Kalle Valo <kvalo@codeaurora.org>,
	Wireless <linux-wireless@vger.kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Sara Sharon <sara.sharon@intel.com>,
	Luca Coelho <luciano.coelho@intel.com>,
	Kees Cook <keescook@google.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: linux-next: build warnings after merge of the wireless-drivers-next tree
Date: Fri, 30 Nov 2018 12:05:55 +1100	[thread overview]
Message-ID: <20181130120555.1d35eb6b@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

Hi all,

After merging the wireless-drivers-next tree, today's linux-next build
(x86_64 allmodconfig) produced these warnings:

drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function 'iwl_parse_tlv_firmware':
drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (iwlwifi_mod_params.enable_ini)
       ^
drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
   default:
   ^~~~~~~
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function 'iwl_parse_fw_dbg_tlv':
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    iwl_fw_dbg_copy_tlv(trans, tlv, true);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
   default:
   ^~~~~~~

Introduced by commit

  f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")

These are noted because I use -Wimplict-fallthrough

The warnings can be suppressed by adding a comment like
	/* fall through */
at the appropriate place to indicate that the fallthough is intended.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2018-11-30  1:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30  1:05 Stephen Rothwell [this message]
2018-11-30  4:33 ` linux-next: build warnings after merge of the wireless-drivers-next tree Kalle Valo
2018-11-30  5:50   ` Stephen Rothwell
2018-11-30  7:43     ` Kalle Valo
2018-12-03 12:38       ` Luciano Coelho
2018-12-03 15:15         ` Gustavo A. R. Silva
2018-12-19  2:47 ` Stephen Rothwell
2018-12-19  7:51   ` Kalle Valo
2018-12-19  8:31     ` Grumbach, Emmanuel
2018-12-19 10:27       ` Luca Coelho
2018-12-19 12:40       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181130120555.1d35eb6b@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=gustavo@embeddedor.com \
    --cc=keescook@google.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    --cc=sara.sharon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).