From: Vlastimil Babka <vbabka@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@kernel.org>,
Mel Gorman <mgorman@techsingularity.net>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 4/8] mm, page_alloc: restructure direct compaction handling in slowpath
Date: Wed, 20 Jul 2016 18:02:42 +0200 [thread overview]
Message-ID: <0a0a9812-2c51-dbb2-4f67-677d750e16ec@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1607191548370.19940@chino.kir.corp.google.com>
On 07/20/2016 12:50 AM, David Rientjes wrote:
> On Mon, 18 Jul 2016, Vlastimil Babka wrote:
>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 30443804f156..a04a67745927 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -3510,7 +3510,7 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
>> struct page *page = NULL;
>> unsigned int alloc_flags;
>> unsigned long did_some_progress;
>> - enum migrate_mode migration_mode = MIGRATE_ASYNC;
>> + enum migrate_mode migration_mode = MIGRATE_SYNC_LIGHT;
>> enum compact_result compact_result;
>> int compaction_retries = 0;
>> int no_progress_loops = 0;
>> @@ -3552,6 +3552,49 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
>> if (page)
>> goto got_pg;
>>
>> + /*
>> + * For costly allocations, try direct compaction first, as it's likely
>> + * that we have enough base pages and don't need to reclaim.
>> + */
>> + if (can_direct_reclaim && order > PAGE_ALLOC_COSTLY_ORDER) {
>> + page = __alloc_pages_direct_compact(gfp_mask, order,
>> + alloc_flags, ac,
>> + MIGRATE_ASYNC,
>> + &compact_result);
>> + if (page)
>> + goto got_pg;
>> +
>> + /* Checks for THP-specific high-order allocations */
>> + if (is_thp_gfp_mask(gfp_mask)) {
>> + /*
>> + * If compaction is deferred for high-order allocations,
>> + * it is because sync compaction recently failed. If
>> + * this is the case and the caller requested a THP
>> + * allocation, we do not want to heavily disrupt the
>> + * system, so we fail the allocation instead of entering
>> + * direct reclaim.
>> + */
>> + if (compact_result == COMPACT_DEFERRED)
>> + goto nopage;
>> +
>> + /*
>> + * Compaction is contended so rather back off than cause
>> + * excessive stalls.
>> + */
>> + if (compact_result == COMPACT_CONTENDED)
>> + goto nopage;
>> +
>> + /*
>> + * It can become very expensive to allocate transparent
>> + * hugepages at fault, so use asynchronous memory
>> + * compaction for THP unless it is khugepaged trying to
>> + * collapse. All other requests should tolerate at
>> + * least light sync migration.
>> + */
>> + if (!(current->flags & PF_KTHREAD))
>> + migration_mode = MIGRATE_ASYNC;
>> + }
>> + }
>>
>
> If gfp_pfmemalloc_allowed() == true, does this try to do compaction when
> get_page_from_freelist() would have succeeded with no watermarks?
Yes, but the compaction will return immediately with COMPACT_SKIPPED, if
we are below min watermarks. So I don't think it's worth complicating
the code to avoid this?
next prev parent reply other threads:[~2016-07-20 16:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 11:22 [PATCH 0/8] compaction-related cleanups v4 Vlastimil Babka
2016-07-18 11:22 ` [PATCH 1/8] mm, compaction: don't isolate PageWriteback pages in MIGRATE_SYNC_LIGHT mode Vlastimil Babka
2016-07-19 22:21 ` David Rientjes
2016-07-18 11:22 ` [PATCH 2/8] mm, page_alloc: set alloc_flags only once in slowpath Vlastimil Babka
2016-07-18 11:27 ` Michal Hocko
2016-07-19 22:28 ` David Rientjes
2016-07-21 7:00 ` Vlastimil Babka
2016-07-18 11:22 ` [PATCH 3/8] mm, page_alloc: don't retry initial attempt " Vlastimil Babka
2016-07-18 11:29 ` Michal Hocko
2016-07-18 11:34 ` Vlastimil Babka
2016-07-19 22:36 ` David Rientjes
2016-07-20 15:25 ` Vlastimil Babka
2016-07-20 22:00 ` David Rientjes
2016-07-18 11:22 ` [PATCH 4/8] mm, page_alloc: restructure direct compaction handling " Vlastimil Babka
2016-07-19 22:50 ` David Rientjes
2016-07-20 16:02 ` Vlastimil Babka [this message]
2016-07-18 11:22 ` [PATCH 5/8] mm, page_alloc: make THP-specific decisions more generic Vlastimil Babka
2016-07-19 23:10 ` David Rientjes
2016-07-21 7:13 ` Vlastimil Babka
2016-07-18 11:23 ` [PATCH 6/8] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Vlastimil Babka
2016-07-18 11:23 ` [PATCH 7/8] mm, compaction: introduce direct compaction priority Vlastimil Babka
2016-07-18 11:23 ` [PATCH 8/8] mm, compaction: simplify contended compaction handling Vlastimil Babka
2016-07-18 11:30 ` [PATCH 0/8] compaction-related cleanups v4 Michal Hocko
2016-07-18 15:41 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a0a9812-2c51-dbb2-4f67-677d750e16ec@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).