From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@kernel.org>,
Mel Gorman <mgorman@techsingularity.net>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: [PATCH 1/8] mm, compaction: don't isolate PageWriteback pages in MIGRATE_SYNC_LIGHT mode
Date: Mon, 18 Jul 2016 13:22:55 +0200 [thread overview]
Message-ID: <20160718112302.27381-2-vbabka@suse.cz> (raw)
In-Reply-To: <20160718112302.27381-1-vbabka@suse.cz>
From: Hugh Dickins <hughd@google.com>
At present MIGRATE_SYNC_LIGHT is allowing __isolate_lru_page() to
isolate a PageWriteback page, which __unmap_and_move() then rejects
with -EBUSY: of course the writeback might complete in between, but
that's not what we usually expect, so probably better not to isolate it.
When tested by stress-highalloc from mmtests, this has reduced the number of
page migrate failures by 60-70%.
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Michal Hocko <mhocko@suse.com>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index cd93ea24c565..892e397655dc 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1200,7 +1200,7 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone,
struct page *page;
const isolate_mode_t isolate_mode =
(sysctl_compact_unevictable_allowed ? ISOLATE_UNEVICTABLE : 0) |
- (cc->mode == MIGRATE_ASYNC ? ISOLATE_ASYNC_MIGRATE : 0);
+ (cc->mode != MIGRATE_SYNC ? ISOLATE_ASYNC_MIGRATE : 0);
/*
* Start at where we last stopped, or beginning of the zone as
--
2.9.0
next prev parent reply other threads:[~2016-07-18 11:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 11:22 [PATCH 0/8] compaction-related cleanups v4 Vlastimil Babka
2016-07-18 11:22 ` Vlastimil Babka [this message]
2016-07-19 22:21 ` [PATCH 1/8] mm, compaction: don't isolate PageWriteback pages in MIGRATE_SYNC_LIGHT mode David Rientjes
2016-07-18 11:22 ` [PATCH 2/8] mm, page_alloc: set alloc_flags only once in slowpath Vlastimil Babka
2016-07-18 11:27 ` Michal Hocko
2016-07-19 22:28 ` David Rientjes
2016-07-21 7:00 ` Vlastimil Babka
2016-07-18 11:22 ` [PATCH 3/8] mm, page_alloc: don't retry initial attempt " Vlastimil Babka
2016-07-18 11:29 ` Michal Hocko
2016-07-18 11:34 ` Vlastimil Babka
2016-07-19 22:36 ` David Rientjes
2016-07-20 15:25 ` Vlastimil Babka
2016-07-20 22:00 ` David Rientjes
2016-07-18 11:22 ` [PATCH 4/8] mm, page_alloc: restructure direct compaction handling " Vlastimil Babka
2016-07-19 22:50 ` David Rientjes
2016-07-20 16:02 ` Vlastimil Babka
2016-07-18 11:22 ` [PATCH 5/8] mm, page_alloc: make THP-specific decisions more generic Vlastimil Babka
2016-07-19 23:10 ` David Rientjes
2016-07-21 7:13 ` Vlastimil Babka
2016-07-18 11:23 ` [PATCH 6/8] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Vlastimil Babka
2016-07-18 11:23 ` [PATCH 7/8] mm, compaction: introduce direct compaction priority Vlastimil Babka
2016-07-18 11:23 ` [PATCH 8/8] mm, compaction: simplify contended compaction handling Vlastimil Babka
2016-07-18 11:30 ` [PATCH 0/8] compaction-related cleanups v4 Michal Hocko
2016-07-18 15:41 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718112302.27381-2-vbabka@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).