* [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically
@ 2020-12-08 12:35 quanyang.wang
2020-12-08 12:42 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: quanyang.wang @ 2020-12-08 12:35 UTC (permalink / raw)
To: mturquette, sboyd, michal.simek
Cc: quanyang.wang, linux-clk, linux-arm-kernel, linux-kernel
From: Quanyang Wang <quanyang.wang@windriver.com>
The Zynqmp Ultrascale clock controller generates clocks for peripherals,
so we need to enable it when ARCH_ZYNQMP is selected.
Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
---
drivers/clk/zynqmp/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/zynqmp/Kconfig b/drivers/clk/zynqmp/Kconfig
index 17086059be8b..a8aa58bbb790 100644
--- a/drivers/clk/zynqmp/Kconfig
+++ b/drivers/clk/zynqmp/Kconfig
@@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
depends on ARCH_ZYNQMP || COMPILE_TEST
depends on ZYNQMP_FIRMWARE
+ default ARCH_ZYNQMP
help
Support for the Zynqmp Ultrascale clock controller.
It has a dependency on the PMU firmware.
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically
2020-12-08 12:35 [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically quanyang.wang
@ 2020-12-08 12:42 ` Michal Simek
2020-12-09 1:14 ` quanyang.wang
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2020-12-08 12:42 UTC (permalink / raw)
To: quanyang.wang, mturquette, sboyd, michal.simek
Cc: linux-clk, linux-arm-kernel, linux-kernel
Hi,
On 08. 12. 20 13:35, quanyang.wang@windriver.com wrote:
> From: Quanyang Wang <quanyang.wang@windriver.com>
>
> The Zynqmp Ultrascale clock controller generates clocks for peripherals,
> so we need to enable it when ARCH_ZYNQMP is selected.
>
> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> ---
> drivers/clk/zynqmp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/zynqmp/Kconfig b/drivers/clk/zynqmp/Kconfig
> index 17086059be8b..a8aa58bbb790 100644
> --- a/drivers/clk/zynqmp/Kconfig
> +++ b/drivers/clk/zynqmp/Kconfig
> @@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
> bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
> depends on ARCH_ZYNQMP || COMPILE_TEST
> depends on ZYNQMP_FIRMWARE
> + default ARCH_ZYNQMP
This is not right. If you look 2 lines above.
> help
> Support for the Zynqmp Ultrascale clock controller.
> It has a dependency on the PMU firmware.
>
And we were talking about enabling this driver in defconfig. Not via
Kconfig. This fragment was designed in a way that this clock controller
doesn't need to be used. It is our default but if you want to use for
example fixed clock you also can.
This enables space for being able to use for example different firmware.
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically
2020-12-08 12:42 ` Michal Simek
@ 2020-12-09 1:14 ` quanyang.wang
0 siblings, 0 replies; 3+ messages in thread
From: quanyang.wang @ 2020-12-09 1:14 UTC (permalink / raw)
To: Michal Simek, mturquette, sboyd; +Cc: linux-clk, linux-arm-kernel, linux-kernel
Hi Michal,
On 12/8/20 8:42 PM, Michal Simek wrote:
> Hi,
>
> On 08. 12. 20 13:35, quanyang.wang@windriver.com wrote:
>> From: Quanyang Wang <quanyang.wang@windriver.com>
>>
>> The Zynqmp Ultrascale clock controller generates clocks for peripherals,
>> so we need to enable it when ARCH_ZYNQMP is selected.
>>
>> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
>> ---
>> drivers/clk/zynqmp/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/zynqmp/Kconfig b/drivers/clk/zynqmp/Kconfig
>> index 17086059be8b..a8aa58bbb790 100644
>> --- a/drivers/clk/zynqmp/Kconfig
>> +++ b/drivers/clk/zynqmp/Kconfig
>> @@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
>> bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
>> depends on ARCH_ZYNQMP || COMPILE_TEST
>> depends on ZYNQMP_FIRMWARE
>> + default ARCH_ZYNQMP
> This is not right. If you look 2 lines above.
>
>> help
>> Support for the Zynqmp Ultrascale clock controller.
>> It has a dependency on the PMU firmware.
>>
> And we were talking about enabling this driver in defconfig. Not via
> Kconfig. This fragment was designed in a way that this clock controller
> doesn't need to be used. It is our default but if you want to use for
> example fixed clock you also can.
> This enables space for being able to use for example different firmware.
Thanks for your reply. I will enable this driver in defconfig.
Best Regards
Quanyang
>
> Thanks,
> Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-09 1:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 12:35 [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically quanyang.wang
2020-12-08 12:42 ` Michal Simek
2020-12-09 1:14 ` quanyang.wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).