From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Tim Chang <jia-wei.chang@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Roger Lu <roger.lu@mediatek.com>,
Kevin Hilman <khilman@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
hsinyi@google.com
Subject: Re: [PATCH v3 2/4] soc: mediatek: svs: add support for mt8186
Date: Mon, 23 May 2022 11:38:11 +0200 [thread overview]
Message-ID: <0a1c4797-cfdf-1b45-62f0-18ecf78ed335@collabora.com> (raw)
In-Reply-To: <20220523084034.26802-3-jia-wei.chang@mediatek.com>
Il 23/05/22 10:40, Tim Chang ha scritto:
> From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
>
> MT8186 svs has a number of banks which used as optimization of opp
> voltage table for corresponding dvfs drivers.
> MT8186 svs big core uses 2-line high bank and low bank to optimize the
> voltage of opp table for higher and lower frequency respectively.
>
> Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-svs.c | 351 ++++++++++++++++++++++++++++++++-
> 1 file changed, 344 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 606a00a2e57d..656d0361ff7d 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
..snip..
> @@ -2245,6 +2569,16 @@ static const struct svs_platform_data svs_mt8192_platform_data = {
> .bank_max = ARRAY_SIZE(svs_mt8192_banks),
> };
>
> +static const struct svs_platform_data svs_mt8186_platform_data = {
> + .name = "mt8186-svs",
> + .banks = svs_mt8186_banks,
> + .efuse_parsing = svs_mt8186_efuse_parsing,
> + .probe = svs_mt8186_platform_probe,
> + .irqflags = IRQF_TRIGGER_HIGH,
I know I gave you my R-b tag earlier, but I've just noticed that: please remove
irqflags, as this kind of flags are specified in devicetree and it is not
necessary to specify them here.
Thanks,
Angelo
next prev parent reply other threads:[~2022-05-23 9:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 8:40 [PATCH v2 0/4] soc: mediatek: svs: add support for mt8186 and Tim Chang
2022-05-23 8:40 ` [PATCH v3 1/4] dt-bindings: soc: mediatek: add mt8186 svs dt-bindings Tim Chang
2022-05-24 2:05 ` Rob Herring
2022-05-23 8:40 ` [PATCH v3 2/4] soc: mediatek: svs: add support for mt8186 Tim Chang
2022-05-23 9:38 ` AngeloGioacchino Del Regno [this message]
2022-05-26 5:52 ` Jia-Wei Chang
2022-05-23 8:40 ` [PATCH v3 3/4] dt-bindings: soc: mediatek: add mt8195 svs dt-bindings Tim Chang
2022-05-23 8:40 ` [PATCH v3 4/4] soc: mediatek: svs: add support for mt8195 Tim Chang
2022-05-23 9:38 ` AngeloGioacchino Del Regno
2022-05-26 5:54 ` Jia-Wei Chang
2022-05-23 8:57 ` [PATCH v2 0/4] soc: mediatek: svs: add support for mt8186 and Jia-Wei Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a1c4797-cfdf-1b45-62f0-18ecf78ed335@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@google.com \
--cc=jia-wei.chang@mediatek.com \
--cc=khilman@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).