From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"Rob Herring" <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Roger Lu <roger.lu@mediatek.com>,
Kevin Hilman <khilman@kernel.org>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<hsinyi@google.com>
Subject: Re: [PATCH v3 4/4] soc: mediatek: svs: add support for mt8195
Date: Thu, 26 May 2022 13:54:44 +0800 [thread overview]
Message-ID: <36568582407c2513028bdd6669b9a6147ebd6132.camel@mediatek.com> (raw)
In-Reply-To: <d9563b65-2391-d32c-8a07-ca7a13cae7c7@collabora.com>
On Mon, 2022-05-23 at 11:38 +0200, AngeloGioacchino Del Regno wrote:
> Il 23/05/22 10:40, Tim Chang ha scritto:
> > From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
> >
> > To support svs on MT8195, add corresponding bank information,
> > platform
> > data, probe and parsing function.
> >
> > Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
>
>
>
> > ---
> > drivers/soc/mediatek/mtk-svs.c | 151
> > +++++++++++++++++++++++++++++++++
> > 1 file changed, 151 insertions(+)
> >
> > diff --git a/drivers/soc/mediatek/mtk-svs.c
> > b/drivers/soc/mediatek/mtk-svs.c
> > index 656d0361ff7d..bb5021648143 100644
> > --- a/drivers/soc/mediatek/mtk-svs.c
> > +++ b/drivers/soc/mediatek/mtk-svs.c
> > @@ -1680,6 +1680,89 @@ static int svs_bank_resource_setup(struct
> > svs_platform *svsp)
>
> ..snip..
>
> > @@ -2559,6 +2697,16 @@ static struct svs_bank svs_mt8183_banks[] =
> > {
> > },
> > };
> >
> > +static const struct svs_platform_data svs_mt8195_platform_data = {
> > + .name = "mt8195-svs",
> > + .banks = svs_mt8195_banks,
> > + .efuse_parsing = svs_mt8195_efuse_parsing,
> > + .probe = svs_mt8192_platform_probe,
> > + .irqflags = IRQF_TRIGGER_HIGH,
>
> Interrupt flags are specified in devicetree; avoid declaring
> irqflags.
>
> After that:
>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
>
Hi Angelo,
Sure, I will remove it in the next version.
Thanks.
next prev parent reply other threads:[~2022-05-26 5:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 8:40 [PATCH v2 0/4] soc: mediatek: svs: add support for mt8186 and Tim Chang
2022-05-23 8:40 ` [PATCH v3 1/4] dt-bindings: soc: mediatek: add mt8186 svs dt-bindings Tim Chang
2022-05-24 2:05 ` Rob Herring
2022-05-23 8:40 ` [PATCH v3 2/4] soc: mediatek: svs: add support for mt8186 Tim Chang
2022-05-23 9:38 ` AngeloGioacchino Del Regno
2022-05-26 5:52 ` Jia-Wei Chang
2022-05-23 8:40 ` [PATCH v3 3/4] dt-bindings: soc: mediatek: add mt8195 svs dt-bindings Tim Chang
2022-05-23 8:40 ` [PATCH v3 4/4] soc: mediatek: svs: add support for mt8195 Tim Chang
2022-05-23 9:38 ` AngeloGioacchino Del Regno
2022-05-26 5:54 ` Jia-Wei Chang [this message]
2022-05-23 8:57 ` [PATCH v2 0/4] soc: mediatek: svs: add support for mt8186 and Jia-Wei Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36568582407c2513028bdd6669b9a6147ebd6132.camel@mediatek.com \
--to=jia-wei.chang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@google.com \
--cc=khilman@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).