From: Nagarjuna Kristam <nkristam@nvidia.com>
To: YueHaibing <yuehaibing@huawei.com>, <balbi@kernel.org>,
<gregkh@linuxfoundation.org>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <felipe.balbi@linux.intel.com>
Cc: <linux-usb@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] usb: gadget: xudc: Remove redundant platform_get_irq error message
Date: Fri, 17 Jan 2020 09:36:31 +0530 [thread overview]
Message-ID: <0a693269-3727-bb71-414e-856eab485353@nvidia.com> (raw)
In-Reply-To: <20200116141433.57056-1-yuehaibing@huawei.com>
Reviewed-by: Nagarjuna Kristam <nkristam@nvidia.com>
On 16-01-2020 19:44, YueHaibing wrote:
> External email: Use caution opening links or attachments
>
>
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
> index 634c2c1..fc1eafc 100644
> --- a/drivers/usb/gadget/udc/tegra-xudc.c
> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
> @@ -3492,11 +3492,8 @@ static int tegra_xudc_probe(struct platform_device *pdev)
> }
>
> xudc->irq = platform_get_irq(pdev, 0);
> - if (xudc->irq < 0) {
> - dev_err(xudc->dev, "failed to get IRQ: %d\n",
> - xudc->irq);
> + if (xudc->irq < 0)
> return xudc->irq;
> - }
>
> err = devm_request_irq(&pdev->dev, xudc->irq, tegra_xudc_irq, 0,
> dev_name(&pdev->dev), xudc);
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2020-01-17 4:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 14:14 [PATCH -next] usb: gadget: xudc: Remove redundant platform_get_irq error message YueHaibing
2020-01-17 4:06 ` Nagarjuna Kristam [this message]
2020-01-17 11:44 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a693269-3727-bb71-414e-856eab485353@nvidia.com \
--to=nkristam@nvidia.com \
--cc=balbi@kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).