From: Thierry Reding <thierry.reding@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org,
jonathanh@nvidia.com, nkristam@nvidia.com,
felipe.balbi@linux.intel.com, linux-usb@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] usb: gadget: xudc: Remove redundant platform_get_irq error message
Date: Fri, 17 Jan 2020 12:44:50 +0100 [thread overview]
Message-ID: <20200117114450.GB166525@ulmo> (raw)
In-Reply-To: <20200116141433.57056-1-yuehaibing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
On Thu, Jan 16, 2020 at 10:14:33PM +0800, YueHaibing wrote:
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-01-17 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 14:14 [PATCH -next] usb: gadget: xudc: Remove redundant platform_get_irq error message YueHaibing
2020-01-17 4:06 ` Nagarjuna Kristam
2020-01-17 11:44 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117114450.GB166525@ulmo \
--to=thierry.reding@gmail.com \
--cc=balbi@kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nkristam@nvidia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).