linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH] powercap: Add Hygon Fam18h RAPL support
@ 2021-02-25 13:01 Pu Wen
  2021-02-28 15:42 ` Srinivas Pandruvada
  0 siblings, 1 reply; 5+ messages in thread
From: Pu Wen @ 2021-02-25 13:01 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-pm, rjw, rafael, bp, victording, kim.phillips, rui.zhang,
	srinivas.pandruvada, Pu Wen

Enable Hygon Fam18h RAPL support for the power capping framework.

Signed-off-by: Pu Wen <puwen@hygon.cn>
---
 drivers/powercap/intel_rapl_common.c | 1 +
 drivers/powercap/intel_rapl_msr.c    | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
index fdda2a737186..73cf68af9770 100644
--- a/drivers/powercap/intel_rapl_common.c
+++ b/drivers/powercap/intel_rapl_common.c
@@ -1069,6 +1069,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
 
 	X86_MATCH_VENDOR_FAM(AMD, 0x17, &rapl_defaults_amd),
 	X86_MATCH_VENDOR_FAM(AMD, 0x19, &rapl_defaults_amd),
+	X86_MATCH_VENDOR_FAM(HYGON, 0x18, &rapl_defaults_amd),
 	{}
 };
 MODULE_DEVICE_TABLE(x86cpu, rapl_ids);
diff --git a/drivers/powercap/intel_rapl_msr.c b/drivers/powercap/intel_rapl_msr.c
index 78213d4b5b16..cc3b22881bfe 100644
--- a/drivers/powercap/intel_rapl_msr.c
+++ b/drivers/powercap/intel_rapl_msr.c
@@ -150,6 +150,7 @@ static int rapl_msr_probe(struct platform_device *pdev)
 	case X86_VENDOR_INTEL:
 		rapl_msr_priv = &rapl_msr_priv_intel;
 		break;
+	case X86_VENDOR_HYGON:
 	case X86_VENDOR_AMD:
 		rapl_msr_priv = &rapl_msr_priv_amd;
 		break;
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [RFC PATCH] powercap: Add Hygon Fam18h RAPL support
  2021-02-25 13:01 [RFC PATCH] powercap: Add Hygon Fam18h RAPL support Pu Wen
@ 2021-02-28 15:42 ` Srinivas Pandruvada
  2021-03-01  2:16   ` Wen Pu
  0 siblings, 1 reply; 5+ messages in thread
From: Srinivas Pandruvada @ 2021-02-28 15:42 UTC (permalink / raw)
  To: Pu Wen, linux-kernel
  Cc: linux-pm, rjw, rafael, bp, victording, kim.phillips, rui.zhang

On Thu, 2021-02-25 at 21:01 +0800, Pu Wen wrote:
> Enable Hygon Fam18h RAPL support for the power capping framework.
> 
If this patch is tested and works on this processor, not sure why this
is RFC?

Thanks,
Srinivas

> Signed-off-by: Pu Wen <puwen@hygon.cn>
> ---
>  drivers/powercap/intel_rapl_common.c | 1 +
>  drivers/powercap/intel_rapl_msr.c    | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/powercap/intel_rapl_common.c
> b/drivers/powercap/intel_rapl_common.c
> index fdda2a737186..73cf68af9770 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -1069,6 +1069,7 @@ static const struct x86_cpu_id rapl_ids[]
> __initconst = {
>  
>  	X86_MATCH_VENDOR_FAM(AMD, 0x17, &rapl_defaults_amd),
>  	X86_MATCH_VENDOR_FAM(AMD, 0x19, &rapl_defaults_amd),
> +	X86_MATCH_VENDOR_FAM(HYGON, 0x18, &rapl_defaults_amd),
>  	{}
>  };
>  MODULE_DEVICE_TABLE(x86cpu, rapl_ids);
> diff --git a/drivers/powercap/intel_rapl_msr.c
> b/drivers/powercap/intel_rapl_msr.c
> index 78213d4b5b16..cc3b22881bfe 100644
> --- a/drivers/powercap/intel_rapl_msr.c
> +++ b/drivers/powercap/intel_rapl_msr.c
> @@ -150,6 +150,7 @@ static int rapl_msr_probe(struct platform_device
> *pdev)
>  	case X86_VENDOR_INTEL:
>  		rapl_msr_priv = &rapl_msr_priv_intel;
>  		break;
> +	case X86_VENDOR_HYGON:
>  	case X86_VENDOR_AMD:
>  		rapl_msr_priv = &rapl_msr_priv_amd;
>  		break;


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC PATCH] powercap: Add Hygon Fam18h RAPL support
  2021-02-28 15:42 ` Srinivas Pandruvada
@ 2021-03-01  2:16   ` Wen Pu
  2021-03-01 14:20     ` Rafael J. Wysocki
  0 siblings, 1 reply; 5+ messages in thread
From: Wen Pu @ 2021-03-01  2:16 UTC (permalink / raw)
  To: Srinivas Pandruvada, linux-kernel
  Cc: linux-pm, rjw, rafael, bp, victording, kim.phillips, rui.zhang

On 2021/2/28 23:42, Srinivas Pandruvada wrote:
> On Thu, 2021-02-25 at 21:01 +0800, Pu Wen wrote:
>> Enable Hygon Fam18h RAPL support for the power capping framework.
>>
> If this patch is tested and works on this processor, not sure why this
> is RFC?

This patch is tested and works on Hygon processor. The 'RFC' is automated
generated by my script ;)

Thanks,
Pu Wen

> Thanks,
> Srinivas
> 
>> Signed-off-by: Pu Wen <puwen@hygon.cn>
>> ---
>>  drivers/powercap/intel_rapl_common.c | 1 +
>>  drivers/powercap/intel_rapl_msr.c    | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/powercap/intel_rapl_common.c
>> b/drivers/powercap/intel_rapl_common.c
>> index fdda2a737186..73cf68af9770 100644
>> --- a/drivers/powercap/intel_rapl_common.c
>> +++ b/drivers/powercap/intel_rapl_common.c
>> @@ -1069,6 +1069,7 @@ static const struct x86_cpu_id rapl_ids[]
>> __initconst = {
>>  
>>  	X86_MATCH_VENDOR_FAM(AMD, 0x17, &rapl_defaults_amd),
>>  	X86_MATCH_VENDOR_FAM(AMD, 0x19, &rapl_defaults_amd),
>> +	X86_MATCH_VENDOR_FAM(HYGON, 0x18, &rapl_defaults_amd),
>>  	{}
>>  };
>>  MODULE_DEVICE_TABLE(x86cpu, rapl_ids);
>> diff --git a/drivers/powercap/intel_rapl_msr.c
>> b/drivers/powercap/intel_rapl_msr.c
>> index 78213d4b5b16..cc3b22881bfe 100644
>> --- a/drivers/powercap/intel_rapl_msr.c
>> +++ b/drivers/powercap/intel_rapl_msr.c
>> @@ -150,6 +150,7 @@ static int rapl_msr_probe(struct platform_device
>> *pdev)
>>  	case X86_VENDOR_INTEL:
>>  		rapl_msr_priv = &rapl_msr_priv_intel;
>>  		break;
>> +	case X86_VENDOR_HYGON:
>>  	case X86_VENDOR_AMD:
>>  		rapl_msr_priv = &rapl_msr_priv_amd;
>>  		break;
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC PATCH] powercap: Add Hygon Fam18h RAPL support
  2021-03-01  2:16   ` Wen Pu
@ 2021-03-01 14:20     ` Rafael J. Wysocki
  2021-03-02  2:04       ` Wen Pu
  0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2021-03-01 14:20 UTC (permalink / raw)
  To: Wen Pu
  Cc: Srinivas Pandruvada, linux-kernel, linux-pm, rjw, rafael, bp,
	victording, kim.phillips, rui.zhang

On Mon, Mar 1, 2021 at 3:18 AM Wen Pu <puwen@hygon.cn> wrote:
>
> On 2021/2/28 23:42, Srinivas Pandruvada wrote:
> > On Thu, 2021-02-25 at 21:01 +0800, Pu Wen wrote:
> >> Enable Hygon Fam18h RAPL support for the power capping framework.
> >>
> > If this patch is tested and works on this processor, not sure why this
> > is RFC?
>
> This patch is tested and works on Hygon processor. The 'RFC' is automated
> generated by my script ;)

Well, care to resend as non-RFC, then?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC PATCH] powercap: Add Hygon Fam18h RAPL support
  2021-03-01 14:20     ` Rafael J. Wysocki
@ 2021-03-02  2:04       ` Wen Pu
  0 siblings, 0 replies; 5+ messages in thread
From: Wen Pu @ 2021-03-02  2:04 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Srinivas Pandruvada, linux-kernel, linux-pm, rjw, bp, victording,
	kim.phillips, rui.zhang

On 2021/3/1 22:20, Rafael J. Wysocki wrote:
> On Mon, Mar 1, 2021 at 3:18 AM Wen Pu <puwen@hygon.cn> wrote:
>>
>> On 2021/2/28 23:42, Srinivas Pandruvada wrote:
>>> On Thu, 2021-02-25 at 21:01 +0800, Pu Wen wrote:
>>>> Enable Hygon Fam18h RAPL support for the power capping framework.
>>>>
>>> If this patch is tested and works on this processor, not sure why this
>>> is RFC?
>>
>> This patch is tested and works on Hygon processor. The 'RFC' is automated
>> generated by my script ;)
> 
> Well, care to resend as non-RFC, then?

OK, already resend. Thanks!

-- 
Regards,
Pu Wen

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-03-02  7:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 13:01 [RFC PATCH] powercap: Add Hygon Fam18h RAPL support Pu Wen
2021-02-28 15:42 ` Srinivas Pandruvada
2021-03-01  2:16   ` Wen Pu
2021-03-01 14:20     ` Rafael J. Wysocki
2021-03-02  2:04       ` Wen Pu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).