From: Kishon Vijay Abraham I <kishon@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2] phy: ti-pipe3: Use TRM recommended settings for SATA DPLL
Date: Tue, 8 Aug 2017 17:36:26 +0530 [thread overview]
Message-ID: <0a90f02c-49e4-c4f1-5264-1b963902ff68@ti.com> (raw)
In-Reply-To: <c7bc0f49-f120-d195-5d40-3d0f9f8962d2@ti.com>
On Monday 07 August 2017 02:41 PM, Roger Quadros wrote:
> The AM572x Technical Reference Manual, SPRUHZ6H,
> Revised November 2016 [1], shows recommended settings for the
> SATA DPLL in Table 26-8. DPLL CLKDCOLDO Recommended Settings.
>
> Use those settings in the driver. The TRM does not show
> a value for 20MHz SYS_CLK so we use something close to the
> 26MHz setting.
>
> [1] - http://www.ti.com/lit/ug/spruhz6h/spruhz6h.pdf
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> [nsekhar@ti.com: add exact TRM version to commit text]
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
merged, thanks!
-Kishon
> ---
> v2:
> - Mention full TRM version in commit log
>
> drivers/phy/ti/phy-ti-pipe3.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/phy/ti/phy-ti-pipe3.c b/drivers/phy/ti/phy-ti-pipe3.c
> index 9c84d32..0e564f3 100644
> --- a/drivers/phy/ti/phy-ti-pipe3.c
> +++ b/drivers/phy/ti/phy-ti-pipe3.c
> @@ -118,12 +118,12 @@ static struct pipe3_dpll_map dpll_map_usb[] = {
> };
>
> static struct pipe3_dpll_map dpll_map_sata[] = {
> - {12000000, {1000, 7, 4, 6, 0} }, /* 12 MHz */
> - {16800000, {714, 7, 4, 6, 0} }, /* 16.8 MHz */
> + {12000000, {625, 4, 4, 6, 0} }, /* 12 MHz */
> + {16800000, {625, 6, 4, 7, 0} }, /* 16.8 MHz */
> {19200000, {625, 7, 4, 6, 0} }, /* 19.2 MHz */
> - {20000000, {600, 7, 4, 6, 0} }, /* 20 MHz */
> - {26000000, {461, 7, 4, 6, 0} }, /* 26 MHz */
> - {38400000, {312, 7, 4, 6, 0} }, /* 38.4 MHz */
> + {20000000, {750, 9, 4, 6, 0} }, /* 20 MHz */
> + {26000000, {750, 12, 4, 6, 0} }, /* 26 MHz */
> + {38400000, {625, 15, 4, 6, 0} }, /* 38.4 MHz */
> { }, /* Terminator */
> };
>
>
prev parent reply other threads:[~2017-08-08 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 8:10 [PATCH] phy: ti-pipe3: Use TRM recommended settings for SATA DPLL Roger Quadros
2017-08-07 9:11 ` [PATCH v2] " Roger Quadros
2017-08-08 12:06 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a90f02c-49e4-c4f1-5264-1b963902ff68@ti.com \
--to=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).