* [PATCH v2 1/3] dt-bindings: watchdog: Add compatible for MediaTek MT8188
2022-08-16 6:53 [PATCH v2 0/3] Add watchdog support for MT8188 Soc Runyang Chen
@ 2022-08-16 6:53 ` Runyang Chen
2022-08-16 9:49 ` Krzysztof Kozlowski
2022-08-16 6:53 ` [PATCH v2 2/3] dt-bindings: reset: mt8188: add toprgu reset-controller header file Runyang Chen
2022-08-16 6:53 ` [PATCH v2 3/3] watchdog: mediatek: mt8188: add wdt support Runyang Chen
2 siblings, 1 reply; 8+ messages in thread
From: Runyang Chen @ 2022-08-16 6:53 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Runyang Chen
From: Runyang Chen <runyang.chen@mediatek.com>
Add dt-binding documentation of watchdog for MediaTek MT8188 Soc
Signed-off-by: Runyang Chen <runyang.chen@mediatek.com>
---
Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
index 762c62e428ef..b900c85d4560 100644
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
@@ -17,6 +17,7 @@ Required properties:
"mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
"mediatek,mt8183-wdt": for MT8183
"mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
+ "mediatek,mt8188-wdt", "mediatek,mt6589-wdt": for MT8188
"mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
"mediatek,mt8192-wdt": for MT8192
"mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
--
2.18.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: watchdog: Add compatible for MediaTek MT8188
2022-08-16 6:53 ` [PATCH v2 1/3] dt-bindings: watchdog: Add compatible for MediaTek MT8188 Runyang Chen
@ 2022-08-16 9:49 ` Krzysztof Kozlowski
2022-09-01 8:16 ` Liju-clr Chen
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-16 9:49 UTC (permalink / raw)
To: Runyang Chen, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
On 16/08/2022 09:53, Runyang Chen wrote:
> From: Runyang Chen <runyang.chen@mediatek.com>
>
> Add dt-binding documentation of watchdog for MediaTek MT8188 Soc
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: watchdog: Add compatible for MediaTek MT8188
2022-08-16 9:49 ` Krzysztof Kozlowski
@ 2022-09-01 8:16 ` Liju-clr Chen
2022-09-01 9:44 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Liju-clr Chen @ 2022-09-01 8:16 UTC (permalink / raw)
To: Krzysztof Kozlowski, Runyang Chen, Wim Van Sebroeck,
Guenter Roeck, Krzysztof Kozlowski, Matthias Brugger,
Rob Herring, nfraprado
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
Hi Maintainers,
Gentle ping for this patch.
It would be appreciated if you could give some suggestions.
Best Regards,
Liju Chen
On Tue, 2022-08-16 at 12:49 +0300, Krzysztof Kozlowski wrote:
> On 16/08/2022 09:53, Runyang Chen wrote:
> > From: Runyang Chen <runyang.chen@mediatek.com>
> >
> > Add dt-binding documentation of watchdog for MediaTek MT8188 Soc
> >
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: watchdog: Add compatible for MediaTek MT8188
2022-09-01 8:16 ` Liju-clr Chen
@ 2022-09-01 9:44 ` Krzysztof Kozlowski
2022-09-01 10:03 ` Liju-clr Chen
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-01 9:44 UTC (permalink / raw)
To: Liju-clr Chen, Runyang Chen, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
On 01/09/2022 11:16, Liju-clr Chen wrote:
> Hi Maintainers,
>
> Gentle ping for this patch.
> It would be appreciated if you could give some suggestions.
Why ping? You got the ack, so what do you need from me?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: watchdog: Add compatible for MediaTek MT8188
2022-09-01 9:44 ` Krzysztof Kozlowski
@ 2022-09-01 10:03 ` Liju-clr Chen
0 siblings, 0 replies; 8+ messages in thread
From: Liju-clr Chen @ 2022-09-01 10:03 UTC (permalink / raw)
To: Krzysztof Kozlowski, Runyang Chen, Wim Van Sebroeck,
Guenter Roeck, Krzysztof Kozlowski, Matthias Brugger,
Rob Herring, nfraprado
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
On Thu, 2022-09-01 at 12:44 +0300, Krzysztof Kozlowski wrote:
> On 01/09/2022 11:16, Liju-clr Chen wrote:
> > Hi Maintainers,
> >
> > Gentle ping for this patch.
> > It would be appreciated if you could give some suggestions.
>
> Why ping? You got the ack, so what do you need from me?
>
I apologized for this mistake.
I should reply this on cover letter instead of this patch.
Sorry for any inconvenience caused.
Best Regards,
Liju Chen
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/3] dt-bindings: reset: mt8188: add toprgu reset-controller header file
2022-08-16 6:53 [PATCH v2 0/3] Add watchdog support for MT8188 Soc Runyang Chen
2022-08-16 6:53 ` [PATCH v2 1/3] dt-bindings: watchdog: Add compatible for MediaTek MT8188 Runyang Chen
@ 2022-08-16 6:53 ` Runyang Chen
2022-08-16 6:53 ` [PATCH v2 3/3] watchdog: mediatek: mt8188: add wdt support Runyang Chen
2 siblings, 0 replies; 8+ messages in thread
From: Runyang Chen @ 2022-08-16 6:53 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Runyang Chen
From: Runyang Chen <runyang.chen@mediatek.com>
Add toprgu reset-controller header file for MT8188
Signed-off-by: Runyang Chen <runyang.chen@mediatek.com>
Acked-by: Rob Herring <robh@kernel.org>
---
include/dt-bindings/reset/mt8188-resets.h | 36 +++++++++++++++++++++++
1 file changed, 36 insertions(+)
create mode 100644 include/dt-bindings/reset/mt8188-resets.h
diff --git a/include/dt-bindings/reset/mt8188-resets.h b/include/dt-bindings/reset/mt8188-resets.h
new file mode 100644
index 000000000000..377cdfda82a9
--- /dev/null
+++ b/include/dt-bindings/reset/mt8188-resets.h
@@ -0,0 +1,36 @@
+/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)*/
+/*
+ * Copyright (c) 2022 MediaTek Inc.
+ * Author: Runyang Chen <runyang.chen@mediatek.com>
+ */
+
+#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT8188
+#define _DT_BINDINGS_RESET_CONTROLLER_MT8188
+
+#define MT8188_TOPRGU_CONN_MCU_SW_RST 0
+#define MT8188_TOPRGU_INFRA_GRST_SW_RST 1
+#define MT8188_TOPRGU_IPU0_SW_RST 2
+#define MT8188_TOPRGU_IPU1_SW_RST 3
+#define MT8188_TOPRGU_IPU2_SW_RST 4
+#define MT8188_TOPRGU_AUD_ASRC_SW_RST 5
+#define MT8188_TOPRGU_INFRA_SW_RST 6
+#define MT8188_TOPRGU_MMSYS_SW_RST 7
+#define MT8188_TOPRGU_MFG_SW_RST 8
+#define MT8188_TOPRGU_VENC_SW_RST 9
+#define MT8188_TOPRGU_VDEC_SW_RST 10
+#define MT8188_TOPRGU_CAM_VCORE_SW_RST 11
+#define MT8188_TOPRGU_SCP_SW_RST 12
+#define MT8188_TOPRGU_APMIXEDSYS_SW_RST 13
+#define MT8188_TOPRGU_AUDIO_SW_RST 14
+#define MT8188_TOPRGU_CAMSYS_SW_RST 15
+#define MT8188_TOPRGU_MJC_SW_RST 16
+#define MT8188_TOPRGU_PERI_SW_RST 17
+#define MT8188_TOPRGU_PERI_AO_SW_RST 18
+#define MT8188_TOPRGU_PCIE_SW_RST 19
+#define MT8188_TOPRGU_ADSPSYS_SW_RST 21
+#define MT8188_TOPRGU_DPTX_SW_RST 22
+#define MT8188_TOPRGU_SPMI_MST_SW_RST 23
+
+#define MT8188_TOPRGU_SW_RST_NUM 24
+
+#endif /* _DT_BINDINGS_RESET_CONTROLLER_MT8188 */
--
2.18.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 3/3] watchdog: mediatek: mt8188: add wdt support
2022-08-16 6:53 [PATCH v2 0/3] Add watchdog support for MT8188 Soc Runyang Chen
2022-08-16 6:53 ` [PATCH v2 1/3] dt-bindings: watchdog: Add compatible for MediaTek MT8188 Runyang Chen
2022-08-16 6:53 ` [PATCH v2 2/3] dt-bindings: reset: mt8188: add toprgu reset-controller header file Runyang Chen
@ 2022-08-16 6:53 ` Runyang Chen
2 siblings, 0 replies; 8+ messages in thread
From: Runyang Chen @ 2022-08-16 6:53 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: angelogioacchino.delregno, Project_Global_Chrome_Upstream_Group,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
Runyang Chen
From: Runyang Chen <runyang.chen@mediatek.com>
Support MT8188 watchdog device.
Signed-off-by: Runyang Chen <runyang.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/watchdog/mtk_wdt.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index e97787536792..b53763ad90cf 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c
@@ -13,6 +13,7 @@
#include <dt-bindings/reset/mt7986-resets.h>
#include <dt-bindings/reset/mt8183-resets.h>
#include <dt-bindings/reset/mt8186-resets.h>
+#include <dt-bindings/reset/mt8188-resets.h>
#include <dt-bindings/reset/mt8192-resets.h>
#include <dt-bindings/reset/mt8195-resets.h>
#include <linux/delay.h>
@@ -90,6 +91,10 @@ static const struct mtk_wdt_data mt8186_data = {
.toprgu_sw_rst_num = MT8186_TOPRGU_SW_RST_NUM,
};
+static const struct mtk_wdt_data mt8188_data = {
+ .toprgu_sw_rst_num = MT8188_TOPRGU_SW_RST_NUM,
+};
+
static const struct mtk_wdt_data mt8192_data = {
.toprgu_sw_rst_num = MT8192_TOPRGU_SW_RST_NUM,
};
@@ -429,6 +434,7 @@ static const struct of_device_id mtk_wdt_dt_ids[] = {
{ .compatible = "mediatek,mt7986-wdt", .data = &mt7986_data },
{ .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data },
{ .compatible = "mediatek,mt8186-wdt", .data = &mt8186_data },
+ { .compatible = "mediatek,mt8188-wdt", .data = &mt8188_data },
{ .compatible = "mediatek,mt8192-wdt", .data = &mt8192_data },
{ .compatible = "mediatek,mt8195-wdt", .data = &mt8195_data },
{ /* sentinel */ }
--
2.18.0
^ permalink raw reply related [flat|nested] 8+ messages in thread