* [PATCH] ARM: dts: rockchip: use DMA channels for UARTs of TinkerBoard
@ 2020-03-14 14:23 Katsuhiro Suzuki
2020-03-14 15:09 ` Heiko Stübner
0 siblings, 1 reply; 3+ messages in thread
From: Katsuhiro Suzuki @ 2020-03-14 14:23 UTC (permalink / raw)
To: Heiko Stuebner, linux-rockchip
Cc: linux-arm-kernel, linux-kernel, Katsuhiro Suzuki
This patch enables to use DMAC for all UARTs that are connected to
dmac_peri core for TinkerBoard.
Only uart2 is connected different DMAC (dmac_bus_s) so keep current
settings on this patch.
Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
---
arch/arm/boot/dts/rk3288-tinker.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi
index 312582c1bd37..6efabeaf3c6d 100644
--- a/arch/arm/boot/dts/rk3288-tinker.dtsi
+++ b/arch/arm/boot/dts/rk3288-tinker.dtsi
@@ -491,10 +491,14 @@ &tsadc {
};
&uart0 {
+ dmas = <&dmac_peri 1>, <&dmac_peri 2>;
+ dma-names = "tx", "rx";
status = "okay";
};
&uart1 {
+ dmas = <&dmac_peri 3>, <&dmac_peri 4>;
+ dma-names = "tx", "rx";
status = "okay";
};
@@ -503,10 +507,14 @@ &uart2 {
};
&uart3 {
+ dmas = <&dmac_peri 7>, <&dmac_peri 8>;
+ dma-names = "tx", "rx";
status = "okay";
};
&uart4 {
+ dmas = <&dmac_peri 9>, <&dmac_peri 10>;
+ dma-names = "tx", "rx";
status = "okay";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: use DMA channels for UARTs of TinkerBoard
2020-03-14 14:23 [PATCH] ARM: dts: rockchip: use DMA channels for UARTs of TinkerBoard Katsuhiro Suzuki
@ 2020-03-14 15:09 ` Heiko Stübner
2020-03-15 9:44 ` Katsuhiro Suzuki
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stübner @ 2020-03-14 15:09 UTC (permalink / raw)
To: Katsuhiro Suzuki; +Cc: linux-rockchip, linux-arm-kernel, linux-kernel
Hi,
Am Samstag, 14. März 2020, 15:23:27 CET schrieb Katsuhiro Suzuki:
> This patch enables to use DMAC for all UARTs that are connected to
> dmac_peri core for TinkerBoard.
>
> Only uart2 is connected different DMAC (dmac_bus_s) so keep current
> settings on this patch.
This belongs in rk3288.dtsi, as this is definitly not board-specific, as
the dma-uart connection is done inside the soc.
At least on arm64 (rk3328, px30, probably more) we already have the
uart dmas in the core dtsi without any problems.
Is there any reason why you only did add it to the tinker board only?
Heiko
> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> ---
> arch/arm/boot/dts/rk3288-tinker.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi
> index 312582c1bd37..6efabeaf3c6d 100644
> --- a/arch/arm/boot/dts/rk3288-tinker.dtsi
> +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi
> @@ -491,10 +491,14 @@ &tsadc {
> };
>
> &uart0 {
> + dmas = <&dmac_peri 1>, <&dmac_peri 2>;
> + dma-names = "tx", "rx";
> status = "okay";
> };
>
> &uart1 {
> + dmas = <&dmac_peri 3>, <&dmac_peri 4>;
> + dma-names = "tx", "rx";
> status = "okay";
> };
>
> @@ -503,10 +507,14 @@ &uart2 {
> };
>
> &uart3 {
> + dmas = <&dmac_peri 7>, <&dmac_peri 8>;
> + dma-names = "tx", "rx";
> status = "okay";
> };
>
> &uart4 {
> + dmas = <&dmac_peri 9>, <&dmac_peri 10>;
> + dma-names = "tx", "rx";
> status = "okay";
> };
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: use DMA channels for UARTs of TinkerBoard
2020-03-14 15:09 ` Heiko Stübner
@ 2020-03-15 9:44 ` Katsuhiro Suzuki
0 siblings, 0 replies; 3+ messages in thread
From: Katsuhiro Suzuki @ 2020-03-15 9:44 UTC (permalink / raw)
To: Heiko Stübner; +Cc: linux-rockchip, linux-arm-kernel, linux-kernel
Hello Heiko,
> This belongs in rk3288.dtsi, as this is definitly not board-specific, as
> the dma-uart connection is done inside the soc.
>
> At least on arm64 (rk3328, px30, probably more) we already have the
> uart dmas in the core dtsi without any problems.
>
> Is there any reason why you only did add it to the tinker board only?
There is no special reason. Simply I don't have and not tested on other
boards of RK3288. But I hope these DMA settings can work correctly on
other boards.
I'll resend patch for rk3288.dtsi.
Best Regards,
Katsuhiro Suzuki
On 2020/03/15 0:09, Heiko Stübner wrote:
> Hi,
>
> Am Samstag, 14. März 2020, 15:23:27 CET schrieb Katsuhiro Suzuki:
>> This patch enables to use DMAC for all UARTs that are connected to
>> dmac_peri core for TinkerBoard.
>>
>> Only uart2 is connected different DMAC (dmac_bus_s) so keep current
>> settings on this patch.
>
> This belongs in rk3288.dtsi, as this is definitly not board-specific, as
> the dma-uart connection is done inside the soc.
>
> At least on arm64 (rk3328, px30, probably more) we already have the
> uart dmas in the core dtsi without any problems.
>
> Is there any reason why you only did add it to the tinker board only?
>
>
> Heiko
>
>
>> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
>> ---
>> arch/arm/boot/dts/rk3288-tinker.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi
>> index 312582c1bd37..6efabeaf3c6d 100644
>> --- a/arch/arm/boot/dts/rk3288-tinker.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi
>> @@ -491,10 +491,14 @@ &tsadc {
>> };
>>
>> &uart0 {
>> + dmas = <&dmac_peri 1>, <&dmac_peri 2>;
>> + dma-names = "tx", "rx";
>> status = "okay";
>> };
>>
>> &uart1 {
>> + dmas = <&dmac_peri 3>, <&dmac_peri 4>;
>> + dma-names = "tx", "rx";
>> status = "okay";
>> };
>>
>> @@ -503,10 +507,14 @@ &uart2 {
>> };
>>
>> &uart3 {
>> + dmas = <&dmac_peri 7>, <&dmac_peri 8>;
>> + dma-names = "tx", "rx";
>> status = "okay";
>> };
>>
>> &uart4 {
>> + dmas = <&dmac_peri 9>, <&dmac_peri 10>;
>> + dma-names = "tx", "rx";
>> status = "okay";
>> };
>>
>>
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-15 9:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-14 14:23 [PATCH] ARM: dts: rockchip: use DMA channels for UARTs of TinkerBoard Katsuhiro Suzuki
2020-03-14 15:09 ` Heiko Stübner
2020-03-15 9:44 ` Katsuhiro Suzuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).