* [PATCH] i2c: i2c-st: fix missing struct parameter description
@ 2020-03-26 21:22 Alain Volmat
2020-03-27 8:47 ` Patrice CHOTARD
2020-03-28 4:02 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Alain Volmat @ 2020-03-26 21:22 UTC (permalink / raw)
To: Patrice Chotard, linux-arm-kernel, linux-i2c, linux-kernel; +Cc: avolmat
Fix a missing struct parameter description to allow
warning free W=1 compilation.
Signed-off-by: Alain Volmat <avolmat@me.com>
---
drivers/i2c/busses/i2c-st.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
index 54e1fc8a495e..f7f7b5b64720 100644
--- a/drivers/i2c/busses/i2c-st.c
+++ b/drivers/i2c/busses/i2c-st.c
@@ -434,6 +434,7 @@ static void st_i2c_wr_fill_tx_fifo(struct st_i2c_dev *i2c_dev)
/**
* st_i2c_rd_fill_tx_fifo() - Fill the Tx FIFO in read mode
* @i2c_dev: Controller's private data
+ * @max: Maximum amount of data to fill into the Tx FIFO
*
* This functions fills the Tx FIFO with fixed pattern when
* in read mode to trigger clock.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: i2c-st: fix missing struct parameter description
2020-03-26 21:22 [PATCH] i2c: i2c-st: fix missing struct parameter description Alain Volmat
@ 2020-03-27 8:47 ` Patrice CHOTARD
2020-03-28 4:02 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Patrice CHOTARD @ 2020-03-27 8:47 UTC (permalink / raw)
To: Alain Volmat, linux-arm-kernel, linux-i2c, linux-kernel
Hi Alain
On 3/26/20 10:22 PM, Alain Volmat wrote:
> Fix a missing struct parameter description to allow
> warning free W=1 compilation.
>
> Signed-off-by: Alain Volmat <avolmat@me.com>
> ---
> drivers/i2c/busses/i2c-st.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
> index 54e1fc8a495e..f7f7b5b64720 100644
> --- a/drivers/i2c/busses/i2c-st.c
> +++ b/drivers/i2c/busses/i2c-st.c
> @@ -434,6 +434,7 @@ static void st_i2c_wr_fill_tx_fifo(struct st_i2c_dev *i2c_dev)
> /**
> * st_i2c_rd_fill_tx_fifo() - Fill the Tx FIFO in read mode
> * @i2c_dev: Controller's private data
> + * @max: Maximum amount of data to fill into the Tx FIFO
> *
> * This functions fills the Tx FIFO with fixed pattern when
> * in read mode to trigger clock.
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: i2c-st: fix missing struct parameter description
2020-03-26 21:22 [PATCH] i2c: i2c-st: fix missing struct parameter description Alain Volmat
2020-03-27 8:47 ` Patrice CHOTARD
@ 2020-03-28 4:02 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2020-03-28 4:02 UTC (permalink / raw)
To: Alain Volmat; +Cc: Patrice Chotard, linux-arm-kernel, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
On Thu, Mar 26, 2020 at 10:22:43PM +0100, Alain Volmat wrote:
> Fix a missing struct parameter description to allow
> warning free W=1 compilation.
>
> Signed-off-by: Alain Volmat <avolmat@me.com>
Applied to for-current, thanks! Please note that the 'i2c-' prefix of
the driver is dropped because it is redundant in $ubject.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-28 4:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 21:22 [PATCH] i2c: i2c-st: fix missing struct parameter description Alain Volmat
2020-03-27 8:47 ` Patrice CHOTARD
2020-03-28 4:02 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).