From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rahul T R <r-ravikumar@ti.com>,
robh+dt@kernel.org, nm@ti.com, vigneshr@ti.com, kishon@ti.com,
krzysztof.kozlowski+dt@linaro.org
Cc: lee.jones@linaro.org, rogerq@kernel.org,
devicetree@vger.kernel.org, kristo@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, s-anna@ti.com
Subject: Re: [PATCH 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add clock property
Date: Sun, 29 May 2022 16:14:02 +0200 [thread overview]
Message-ID: <0b561964-5718-ab1e-34c3-07eadae5b04e@linaro.org> (raw)
In-Reply-To: <20220527083556.18864-2-r-ravikumar@ti.com>
On 27/05/2022 10:35, Rahul T R wrote:
> Add a pattern property for clock, also update the example with
> a clock node
>
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> ---
> .../bindings/mfd/ti,j721e-system-controller.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> index fa86691ebf16..e774a7f0bb08 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> @@ -48,6 +48,12 @@ patternProperties:
> description:
> This is the SERDES lane control mux.
>
> + "^clock@[0-9a-f]+$":
> + type: object
> + $ref: ../clock/ti,am654-ehrpwm-tbclk.yaml#
Full path please, so /schemas/clock/.......
> + description:
> + This is TI syscon gate clk.
Don't use "This is". Just describe it without need of full sentence.
"syscon gate clock" is a bit unspecific and actually looks like you
describe "clocks" property...
> +
> required:
> - compatible
> - reg
> @@ -79,5 +85,11 @@ examples:
> <0x40c0 0x3>, <0x40c4 0x3>, <0x40c8 0x3>, <0x40cc 0x3>;
> /* SERDES4 lane0/1/2/3 select */
> };
> +
> + ehrpwm_tbclk: clock@4140 {
No need for label.
> + compatible = "ti,am654-ehrpwm-tbclk", "syscon";
Messed up indentation.
> + reg = <0x4140 0x18>;
> + #clock-cells = <1>;
> + };
> };
> ...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-29 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 8:35 [PATCH 0/3] Enable RPi header on j721e sk Rahul T R
2022-05-27 8:35 ` [PATCH 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add clock property Rahul T R
2022-05-29 14:14 ` Krzysztof Kozlowski [this message]
2022-05-30 7:33 ` Rahul T R
2022-05-27 8:35 ` [PATCH 2/3] arm64: dts: ti: k3-j721e-*: Add dts nodes for EHRPWMs Rahul T R
2022-05-27 8:35 ` [PATCH 3/3] arm64: dts: ti: k3-j721e-sk: Add pinmux for RPi Header Rahul T R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b561964-5718-ab1e-34c3-07eadae5b04e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=r-ravikumar@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=s-anna@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).