* [PATCH] leds: mlxreg: fix a kernel-doc warning
@ 2024-02-21 6:01 Randy Dunlap
2024-02-23 11:01 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2024-02-21 6:01 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Vadim Pasternak, Pavel Machek, Lee Jones, linux-leds
Drop one struct description to fix a kernel-doc warning:
drivers/leds/leds-mlxreg.c:42: warning: Excess struct member 'led_data' description in 'mlxreg_led_data'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Vadim Pasternak <vadimp@nvidia.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org
---
drivers/leds/leds-mlxreg.c | 1 -
1 file changed, 1 deletion(-)
diff -- a/drivers/leds/leds-mlxreg.c b/drivers/leds/leds-mlxreg.c
--- a/drivers/leds/leds-mlxreg.c
+++ b/drivers/leds/leds-mlxreg.c
@@ -29,7 +29,6 @@
* @data: led configuration data;
* @led_cdev: led class data;
* @base_color: base led color (other colors have constant offset from base);
- * @led_data: led data;
* @data_parent: pointer to private device control data of parent;
* @led_cdev_name: class device name
*/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: mlxreg: fix a kernel-doc warning
2024-02-21 6:01 [PATCH] leds: mlxreg: fix a kernel-doc warning Randy Dunlap
@ 2024-02-23 11:01 ` Lee Jones
2024-02-23 11:01 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2024-02-23 11:01 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Vadim Pasternak, Pavel Machek, linux-leds
On Tue, 20 Feb 2024, Randy Dunlap wrote:
Would you mind being more descriptive in your subject lines please?
It's common for people (me included) to find subject lines a reliable
way to search through Git history and these types of descriptions are
likely to cause duplication.
Thanks.
> Drop one struct description to fix a kernel-doc warning:
>
> drivers/leds/leds-mlxreg.c:42: warning: Excess struct member 'led_data' description in 'mlxreg_led_data'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Vadim Pasternak <vadimp@nvidia.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Lee Jones <lee@kernel.org>
> Cc: linux-leds@vger.kernel.org
> ---
> drivers/leds/leds-mlxreg.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff -- a/drivers/leds/leds-mlxreg.c b/drivers/leds/leds-mlxreg.c
> --- a/drivers/leds/leds-mlxreg.c
> +++ b/drivers/leds/leds-mlxreg.c
> @@ -29,7 +29,6 @@
> * @data: led configuration data;
> * @led_cdev: led class data;
> * @base_color: base led color (other colors have constant offset from base);
> - * @led_data: led data;
> * @data_parent: pointer to private device control data of parent;
> * @led_cdev_name: class device name
> */
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: mlxreg: fix a kernel-doc warning
2024-02-23 11:01 ` Lee Jones
@ 2024-02-23 11:01 ` Lee Jones
2024-02-26 1:49 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2024-02-23 11:01 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Vadim Pasternak, Pavel Machek, linux-leds
On Fri, 23 Feb 2024, Lee Jones wrote:
> On Tue, 20 Feb 2024, Randy Dunlap wrote:
>
> Would you mind being more descriptive in your subject lines please?
>
> It's common for people (me included) to find subject lines a reliable
> way to search through Git history and these types of descriptions are
> likely to cause duplication.
Also if you push them in a set, they're easier to apply.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: mlxreg: fix a kernel-doc warning
2024-02-23 11:01 ` Lee Jones
@ 2024-02-26 1:49 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2024-02-26 1:49 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Vadim Pasternak, Pavel Machek, linux-leds
Hi,
On 2/23/24 03:01, Lee Jones wrote:
> On Fri, 23 Feb 2024, Lee Jones wrote:
>
>> On Tue, 20 Feb 2024, Randy Dunlap wrote:
>>
>> Would you mind being more descriptive in your subject lines please?
Will do.
>> It's common for people (me included) to find subject lines a reliable
>> way to search through Git history and these types of descriptions are
>> likely to cause duplication.
>
> Also if you push them in a set, they're easier to apply.
Do you mean a git tree or a patch series?
I'll be glad to change the 3 patches to a patch series.
Thanks.
--
#Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-26 1:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-21 6:01 [PATCH] leds: mlxreg: fix a kernel-doc warning Randy Dunlap
2024-02-23 11:01 ` Lee Jones
2024-02-23 11:01 ` Lee Jones
2024-02-26 1:49 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).