From: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
To: Zhiqiang Hou <Zhiqiang.Hou@nxp.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
computersforpeace@gmail.com, dwmw2@infradead.org,
boris.brezillon@free-electrons.com, marek.vasut@gmail.com,
richard@nod.at
Subject: Re: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash
Date: Tue, 5 Dec 2017 21:40:53 +0100 [thread overview]
Message-ID: <0b8fae88-cff4-41ac-2613-09bb671ec070@wedev4u.fr> (raw)
In-Reply-To: <20171205053322.35823-1-Zhiqiang.Hou@nxp.com>
Hi Hou,
Le 05/12/2017 à 06:33, Zhiqiang Hou a écrit :
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> To be compatible with legacy device, reset the addressing mode
> to the default mode. Such as Freescale eSPI boot, it copies the
> images from SPI flash without firing a reset signal previously,
> so the reboot command will fail without reseting the addressing
> mode of SPI flash.
>
You should put this in one of the commit messages so it explains which
issue is fixed by your patches.
Otherwise, your series looks good to me :)
Best regards,
Cyrille
> Hou Zhiqiang (2):
> mtd: spi-nor: add an API to restore the status of SPI flash chip
> mtd: m25p80: restore the status of SPI flash when stop using it
>
> Documentation/mtd/spi-nor.txt | 3 +++
> drivers/mtd/devices/m25p80.c | 9 +++++++++
> drivers/mtd/spi-nor/spi-nor.c | 10 ++++++++++
> include/linux/mtd/spi-nor.h | 6 ++++++
> 4 files changed, 28 insertions(+)
>
next prev parent reply other threads:[~2017-12-05 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 5:33 [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash Zhiqiang Hou
2017-12-05 5:33 ` [PATCHv2 1/2] mtd: spi-nor: add an API to restore the status of SPI flash chip Zhiqiang Hou
2017-12-05 5:33 ` [PATCHv2 2/2] mtd: m25p80: restore the status of SPI flash when stop using it Zhiqiang Hou
2017-12-05 20:40 ` Cyrille Pitchen [this message]
2017-12-06 2:17 ` [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash Z.q. Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b8fae88-cff4-41ac-2613-09bb671ec070@wedev4u.fr \
--to=cyrille.pitchen@wedev4u.fr \
--cc=Zhiqiang.Hou@nxp.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).