* [PATCH] xen/pvcalls: remove redundant check for irq >= 0
@ 2017-11-03 9:20 Colin King
2017-11-03 10:01 ` Juergen Gross
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-11-03 9:20 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, xen-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
This is a moot point, but irq is always less than zero at the label
out_error, so the check for irq >= 0 is redundant and can be removed.
Detected by CoverityScan, CID#1460371 ("Logically dead code")
Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/xen/pvcalls-front.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index de8a470351a5..b08569998046 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -351,9 +351,7 @@ static int create_active(struct sock_mapping *map, int *evtchn)
return 0;
out_error:
- if (irq >= 0)
- unbind_from_irqhandler(irq, map);
- else if (*evtchn >= 0)
+ if (*evtchn >= 0)
xenbus_free_evtchn(pvcalls_front_dev, *evtchn);
kfree(map->active.data.in);
kfree(map->active.ring);
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/pvcalls: remove redundant check for irq >= 0
2017-11-03 9:20 [PATCH] xen/pvcalls: remove redundant check for irq >= 0 Colin King
@ 2017-11-03 10:01 ` Juergen Gross
2017-11-08 21:20 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2017-11-03 10:01 UTC (permalink / raw)
To: Colin King, Boris Ostrovsky, xen-devel; +Cc: kernel-janitors, linux-kernel
On 03/11/17 10:20, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> This is a moot point, but irq is always less than zero at the label
> out_error, so the check for irq >= 0 is redundant and can be removed.
>
> Detected by CoverityScan, CID#1460371 ("Logically dead code")
>
> Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/pvcalls: remove redundant check for irq >= 0
2017-11-03 10:01 ` Juergen Gross
@ 2017-11-08 21:20 ` Boris Ostrovsky
0 siblings, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2017-11-08 21:20 UTC (permalink / raw)
To: Juergen Gross, Colin King, xen-devel; +Cc: kernel-janitors, linux-kernel
On 11/03/2017 06:01 AM, Juergen Gross wrote:
> On 03/11/17 10:20, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> This is a moot point, but irq is always less than zero at the label
>> out_error, so the check for irq >= 0 is redundant and can be removed.
>>
>> Detected by CoverityScan, CID#1460371 ("Logically dead code")
>>
>> Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Applied to for-linus-4.15.
-boris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-08 21:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 9:20 [PATCH] xen/pvcalls: remove redundant check for irq >= 0 Colin King
2017-11-03 10:01 ` Juergen Gross
2017-11-08 21:20 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).