* Re: [PATCH] pinctrl: sirf: Add missing put_device() call in sirfsoc_gpio_probe()
@ 2020-06-02 18:56 Markus Elfring
2020-06-03 1:12 ` yukuai (C)
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-06-02 18:56 UTC (permalink / raw)
To: Yu Kuai, linux-arm-kernel, linux-gpio
Cc: kernel-janitors, linux-kernel, Yi Zhang, Barry Song
> in sirfsoc_gpio_probe(), if of_find_device_by_node() succeed,
> put_device() is missing in the error handling patch.
How do you think about another wording variant?
A coccicheck run provided information like the following.
drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing put_device;
call of_find_device_by_node on line 792, but without a corresponding
object release within this function.
Generated by: scripts/coccinelle/free/put_device.cocci
Thus add a jump target to fix the exception handling for this
function implementation.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: sirf: Add missing put_device() call in sirfsoc_gpio_probe()
2020-06-02 18:56 [PATCH] pinctrl: sirf: Add missing put_device() call in sirfsoc_gpio_probe() Markus Elfring
@ 2020-06-03 1:12 ` yukuai (C)
0 siblings, 0 replies; 2+ messages in thread
From: yukuai (C) @ 2020-06-03 1:12 UTC (permalink / raw)
To: Markus Elfring, linux-arm-kernel, linux-gpio
Cc: kernel-janitors, linux-kernel, Yi Zhang, Barry Song
On 2020/6/3 2:56, Markus Elfring wrote:
>> in sirfsoc_gpio_probe(), if of_find_device_by_node() succeed,
>> put_device() is missing in the error handling patch.
>
> How do you think about another wording variant?
>
> A coccicheck run provided information like the following.
>
> drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing put_device;
> call of_find_device_by_node on line 792, but without a corresponding
> object release within this function.
>
> Generated by: scripts/coccinelle/free/put_device.cocci
>
> Thus add a jump target to fix the exception handling for this
> function implementation.
>
>
> Would you like to add the tag “Fixes” to the commit message?
>
Will do, thanks for your advise!
Yu Kuai
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-03 1:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 18:56 [PATCH] pinctrl: sirf: Add missing put_device() call in sirfsoc_gpio_probe() Markus Elfring
2020-06-03 1:12 ` yukuai (C)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).