From: Georgi Djakov <georgi.djakov@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] interconnect: qcom: Add SM8350 interconnect provider driver
Date: Thu, 18 Mar 2021 09:08:39 +0200 [thread overview]
Message-ID: <0c405a3c-1759-34f3-08c6-116444479b09@linaro.org> (raw)
In-Reply-To: <20210302134323.2822076-3-vkoul@kernel.org>
Hi Vinod,
On 3/2/21 15:43, Vinod Koul wrote:
> Add driver for the Qualcomm interconnect buses found in SM8i350 based
Still SM8i350? Have you checked my comments on v1?
> platforms. The topology consists of several NoCs that are controlled by
> a remote processor that collects the aggregated bandwidth for each
> master-slave pairs.
>
> Generated from downstream interconnect driver written by David Dai
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/interconnect/qcom/Kconfig | 10 +
> drivers/interconnect/qcom/Makefile | 2 +
> drivers/interconnect/qcom/sm8350.c | 636 +++++++++++++++++++++++++++++
> drivers/interconnect/qcom/sm8350.h | 168 ++++++++
> 4 files changed, 816 insertions(+)
> create mode 100644 drivers/interconnect/qcom/sm8350.c
> create mode 100644 drivers/interconnect/qcom/sm8350.h
>
> diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
> index ca52647f8955..836157d97cae 100644
> --- a/drivers/interconnect/qcom/Kconfig
> +++ b/drivers/interconnect/qcom/Kconfig
> @@ -110,5 +110,15 @@ config INTERCONNECT_QCOM_SM8250
> This is a driver for the Qualcomm Network-on-Chip on sm8250-based
> platforms.
>
> +config INTERCONNECT_QCOM_SM8350
> + tristate "Qualcomm SM8350 interconnect driver"
> + depends on INTERCONNECT_QCOM
> + depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
Again: depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
> + select INTERCONNECT_QCOM_RPMH
> + select INTERCONNECT_QCOM_BCM_VOTER
> + help
> + This is a driver for the Qualcomm Network-on-Chip on SM8350-based
> + platforms.
> +
> config INTERCONNECT_QCOM_SMD_RPM
> tristate
> diff --git a/drivers/interconnect/qcom/Makefile b/drivers/interconnect/qcom/Makefile
> index c6a735df067e..93d97e590836 100644
> --- a/drivers/interconnect/qcom/Makefile
> +++ b/drivers/interconnect/qcom/Makefile
> @@ -12,6 +12,7 @@ qnoc-sdm845-objs := sdm845.o
> qnoc-sdx55-objs := sdx55.o
> qnoc-sm8150-objs := sm8150.o
> qnoc-sm8250-objs := sm8250.o
> +qnoc-sm8350-objs := sm8350.o
> icc-smd-rpm-objs := smd-rpm.o icc-rpm.o
>
> obj-$(CONFIG_INTERCONNECT_QCOM_BCM_VOTER) += icc-bcm-voter.o
> @@ -26,4 +27,5 @@ obj-$(CONFIG_INTERCONNECT_QCOM_SDM845) += qnoc-sdm845.o
> obj-$(CONFIG_INTERCONNECT_QCOM_SDX55) += qnoc-sdx55.o
> obj-$(CONFIG_INTERCONNECT_QCOM_SM8150) += qnoc-sm8150.o
> obj-$(CONFIG_INTERCONNECT_QCOM_SM8250) += qnoc-sm8250.o
> +obj-$(CONFIG_INTERCONNECT_QCOM_SM8350) += qnoc-sm8350.o
> obj-$(CONFIG_INTERCONNECT_QCOM_SMD_RPM) += icc-smd-rpm.o
> diff --git a/drivers/interconnect/qcom/sm8350.c b/drivers/interconnect/qcom/sm8350.c
> new file mode 100644
> index 000000000000..55c76542aeff
> --- /dev/null
> +++ b/drivers/interconnect/qcom/sm8350.c
> @@ -0,0 +1,636 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2019-2020, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2021, Linaro Limited
> + *
> + */
> +
> +#include <linux/device.h>
> +#include <linux/interconnect.h>
> +#include <linux/interconnect-provider.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/of_platform.h>
Is this used?
Thanks,
Georgi
next parent reply other threads:[~2021-03-18 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210302134323.2822076-1-vkoul@kernel.org>
[not found] ` <20210302134323.2822076-3-vkoul@kernel.org>
2021-03-18 7:08 ` Georgi Djakov [this message]
2021-03-18 9:17 ` [PATCH v2 2/2] interconnect: qcom: Add SM8350 interconnect provider driver Vinod Koul
[not found] ` <20210302134323.2822076-2-vkoul@kernel.org>
[not found] ` <369beb35-e743-c653-0637-c895368362ef@linaro.org>
2021-03-18 9:10 ` [PATCH v2 1/2] dt-bindings: interconnect: Add Qualcomm SM8350 DT bindings Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c405a3c-1759-34f3-08c6-116444479b09@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=okukatla@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).