From: Vinod Koul <vkoul@kernel.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] interconnect: qcom: Add SM8350 interconnect provider driver
Date: Thu, 18 Mar 2021 14:47:44 +0530 [thread overview]
Message-ID: <YFMauIq/L83Trvv6@vkoul-mobl.Dlink> (raw)
In-Reply-To: <0c405a3c-1759-34f3-08c6-116444479b09@linaro.org>
On 18-03-21, 09:08, Georgi Djakov wrote:
> Hi Vinod,
>
> On 3/2/21 15:43, Vinod Koul wrote:
> > Add driver for the Qualcomm interconnect buses found in SM8i350 based
>
> Still SM8i350? Have you checked my comments on v1?
Oops missed to fix the commit log :(
> > +config INTERCONNECT_QCOM_SM8350
> > + tristate "Qualcomm SM8350 interconnect driver"
> > + depends on INTERCONNECT_QCOM
> > + depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
>
> Again: depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
fixed now
> > +#include <linux/device.h>
> > +#include <linux/interconnect.h>
> > +#include <linux/interconnect-provider.h>
> > +#include <linux/module.h>
> > +#include <linux/of_device.h>
> > +#include <linux/of_platform.h>
>
> Is this used?
I need either of_device or of_platform, not both :)
I decided to keep of_device and also get rid of device.h
Also checked we can remove interconnect.h as interconnect-provider.h
already has it. So will send these in next version shortly
--
~Vinod
next prev parent reply other threads:[~2021-03-18 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210302134323.2822076-1-vkoul@kernel.org>
[not found] ` <20210302134323.2822076-3-vkoul@kernel.org>
2021-03-18 7:08 ` [PATCH v2 2/2] interconnect: qcom: Add SM8350 interconnect provider driver Georgi Djakov
2021-03-18 9:17 ` Vinod Koul [this message]
[not found] ` <20210302134323.2822076-2-vkoul@kernel.org>
[not found] ` <369beb35-e743-c653-0637-c895368362ef@linaro.org>
2021-03-18 9:10 ` [PATCH v2 1/2] dt-bindings: interconnect: Add Qualcomm SM8350 DT bindings Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFMauIq/L83Trvv6@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=okukatla@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).