* [PATCH] jffs2: ensure wbuf_verify is valid before using it.
@ 2018-10-20 12:08 Hou Tao
2018-12-09 6:35 ` Hou Tao
2018-12-16 23:56 ` Richard Weinberger
0 siblings, 2 replies; 4+ messages in thread
From: Hou Tao @ 2018-10-20 12:08 UTC (permalink / raw)
To: linux-mtd, dwmw2
Cc: linux-kernel, stable, richard.weinberger, boris.brezillon
Now MTD emulated by UBI volumn doesn't allocate wbuf_verify in
jffs2_ubivol_setup(), because UBI can do the verifcation itself,
so when CONFIG_JFFS2_FS_WBUF_VERIFY is enabled and a MTD device
emulated by UBI volumn is used, a Oops will occur as show in the
following trace:
general protection fault: 0000 [#1] SMP KASAN PTI
CPU: 6 PID: 404 Comm: kworker/6:1 Not tainted 4.19.0-rc8
Workqueue: events_long delayed_wbuf_sync
RIP: 0010:ubi_io_read+0x156/0x650
Call Trace:
ubi_eba_read_leb+0x57d/0xba0
ubi_leb_read+0xe5/0x1b0
gluebi_read+0x10c/0x1a0
mtd_read+0x112/0x340
jffs2_verify_write+0xef/0x440
__jffs2_flush_wbuf+0x3fa/0x3540
jffs2_flush_wbuf_gc+0x1b1/0x2e0
process_one_work+0x58b/0x11e0
worker_thread+0x8f/0xfe0
kthread+0x2ae/0x3a0
ret_from_fork+0x35/0x40
Fix the problem by checking the validity of wbuf_verify before
using it in jffs2_verify_write().
Cc: stable@vger.kernel.org
Fixes: 0029da3bf430 ("JFFS2: add UBI support")
Signed-off-by: Hou Tao <houtao1@huawei.com>
---
fs/jffs2/wbuf.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/fs/jffs2/wbuf.c b/fs/jffs2/wbuf.c
index c6821a509481..3de45f4559d1 100644
--- a/fs/jffs2/wbuf.c
+++ b/fs/jffs2/wbuf.c
@@ -234,6 +234,13 @@ static int jffs2_verify_write(struct jffs2_sb_info *c, unsigned char *buf,
size_t retlen;
char *eccstr;
+ /*
+ * MTD emulated by UBI volume doesn't allocate wbuf_verify,
+ * because it can do the verification itself.
+ */
+ if (!c->wbuf_verify)
+ return 0;
+
ret = mtd_read(c->mtd, ofs, c->wbuf_pagesize, &retlen, c->wbuf_verify);
if (ret && ret != -EUCLEAN && ret != -EBADMSG) {
pr_warn("%s(): Read back of page at %08x failed: %d\n",
--
2.16.2.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] jffs2: ensure wbuf_verify is valid before using it.
2018-10-20 12:08 [PATCH] jffs2: ensure wbuf_verify is valid before using it Hou Tao
@ 2018-12-09 6:35 ` Hou Tao
2018-12-15 13:24 ` Hou Tao
2018-12-16 23:56 ` Richard Weinberger
1 sibling, 1 reply; 4+ messages in thread
From: Hou Tao @ 2018-12-09 6:35 UTC (permalink / raw)
To: linux-mtd, dwmw2
Cc: richard.weinberger, boris.brezillon, linux-kernel, stable
ping ?
On 2018/10/20 20:08, Hou Tao wrote:
> Now MTD emulated by UBI volumn doesn't allocate wbuf_verify in
> jffs2_ubivol_setup(), because UBI can do the verifcation itself,
> so when CONFIG_JFFS2_FS_WBUF_VERIFY is enabled and a MTD device
> emulated by UBI volumn is used, a Oops will occur as show in the
> following trace:
>
> general protection fault: 0000 [#1] SMP KASAN PTI
> CPU: 6 PID: 404 Comm: kworker/6:1 Not tainted 4.19.0-rc8
> Workqueue: events_long delayed_wbuf_sync
> RIP: 0010:ubi_io_read+0x156/0x650
> Call Trace:
> ubi_eba_read_leb+0x57d/0xba0
> ubi_leb_read+0xe5/0x1b0
> gluebi_read+0x10c/0x1a0
> mtd_read+0x112/0x340
> jffs2_verify_write+0xef/0x440
> __jffs2_flush_wbuf+0x3fa/0x3540
> jffs2_flush_wbuf_gc+0x1b1/0x2e0
> process_one_work+0x58b/0x11e0
> worker_thread+0x8f/0xfe0
> kthread+0x2ae/0x3a0
> ret_from_fork+0x35/0x40
>
> Fix the problem by checking the validity of wbuf_verify before
> using it in jffs2_verify_write().
>
> Cc: stable@vger.kernel.org
> Fixes: 0029da3bf430 ("JFFS2: add UBI support")
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---
> fs/jffs2/wbuf.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/fs/jffs2/wbuf.c b/fs/jffs2/wbuf.c
> index c6821a509481..3de45f4559d1 100644
> --- a/fs/jffs2/wbuf.c
> +++ b/fs/jffs2/wbuf.c
> @@ -234,6 +234,13 @@ static int jffs2_verify_write(struct jffs2_sb_info *c, unsigned char *buf,
> size_t retlen;
> char *eccstr;
>
> + /*
> + * MTD emulated by UBI volume doesn't allocate wbuf_verify,
> + * because it can do the verification itself.
> + */
> + if (!c->wbuf_verify)
> + return 0;
> +
> ret = mtd_read(c->mtd, ofs, c->wbuf_pagesize, &retlen, c->wbuf_verify);
> if (ret && ret != -EUCLEAN && ret != -EBADMSG) {
> pr_warn("%s(): Read back of page at %08x failed: %d\n",
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] jffs2: ensure wbuf_verify is valid before using it.
2018-12-09 6:35 ` Hou Tao
@ 2018-12-15 13:24 ` Hou Tao
0 siblings, 0 replies; 4+ messages in thread
From: Hou Tao @ 2018-12-15 13:24 UTC (permalink / raw)
To: linux-mtd, dwmw2
Cc: richard.weinberger, boris.brezillon, linux-kernel, stable
ping ?
On 2018/12/9 14:35, Hou Tao wrote:
> ping ?
>
> On 2018/10/20 20:08, Hou Tao wrote:
>> Now MTD emulated by UBI volumn doesn't allocate wbuf_verify in
>> jffs2_ubivol_setup(), because UBI can do the verifcation itself,
>> so when CONFIG_JFFS2_FS_WBUF_VERIFY is enabled and a MTD device
>> emulated by UBI volumn is used, a Oops will occur as show in the
>> following trace:
>>
>> general protection fault: 0000 [#1] SMP KASAN PTI
>> CPU: 6 PID: 404 Comm: kworker/6:1 Not tainted 4.19.0-rc8
>> Workqueue: events_long delayed_wbuf_sync
>> RIP: 0010:ubi_io_read+0x156/0x650
>> Call Trace:
>> ubi_eba_read_leb+0x57d/0xba0
>> ubi_leb_read+0xe5/0x1b0
>> gluebi_read+0x10c/0x1a0
>> mtd_read+0x112/0x340
>> jffs2_verify_write+0xef/0x440
>> __jffs2_flush_wbuf+0x3fa/0x3540
>> jffs2_flush_wbuf_gc+0x1b1/0x2e0
>> process_one_work+0x58b/0x11e0
>> worker_thread+0x8f/0xfe0
>> kthread+0x2ae/0x3a0
>> ret_from_fork+0x35/0x40
>>
>> Fix the problem by checking the validity of wbuf_verify before
>> using it in jffs2_verify_write().
>>
>> Cc: stable@vger.kernel.org
>> Fixes: 0029da3bf430 ("JFFS2: add UBI support")
>> Signed-off-by: Hou Tao <houtao1@huawei.com>
>> ---
>> fs/jffs2/wbuf.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/fs/jffs2/wbuf.c b/fs/jffs2/wbuf.c
>> index c6821a509481..3de45f4559d1 100644
>> --- a/fs/jffs2/wbuf.c
>> +++ b/fs/jffs2/wbuf.c
>> @@ -234,6 +234,13 @@ static int jffs2_verify_write(struct jffs2_sb_info *c, unsigned char *buf,
>> size_t retlen;
>> char *eccstr;
>>
>> + /*
>> + * MTD emulated by UBI volume doesn't allocate wbuf_verify,
>> + * because it can do the verification itself.
>> + */
>> + if (!c->wbuf_verify)
>> + return 0;
>> +
>> ret = mtd_read(c->mtd, ofs, c->wbuf_pagesize, &retlen, c->wbuf_verify);
>> if (ret && ret != -EUCLEAN && ret != -EBADMSG) {
>> pr_warn("%s(): Read back of page at %08x failed: %d\n",
>>
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] jffs2: ensure wbuf_verify is valid before using it.
2018-10-20 12:08 [PATCH] jffs2: ensure wbuf_verify is valid before using it Hou Tao
2018-12-09 6:35 ` Hou Tao
@ 2018-12-16 23:56 ` Richard Weinberger
1 sibling, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2018-12-16 23:56 UTC (permalink / raw)
To: houtao1; +Cc: linux-mtd, David Woodhouse, LKML, stable, boris.brezillon
On Sat, Oct 20, 2018 at 2:06 PM Hou Tao <houtao1@huawei.com> wrote:
>
> Now MTD emulated by UBI volumn doesn't allocate wbuf_verify in
> jffs2_ubivol_setup(), because UBI can do the verifcation itself,
> so when CONFIG_JFFS2_FS_WBUF_VERIFY is enabled and a MTD device
> emulated by UBI volumn is used, a Oops will occur as show in the
> following trace:
>
> general protection fault: 0000 [#1] SMP KASAN PTI
> CPU: 6 PID: 404 Comm: kworker/6:1 Not tainted 4.19.0-rc8
> Workqueue: events_long delayed_wbuf_sync
> RIP: 0010:ubi_io_read+0x156/0x650
> Call Trace:
> ubi_eba_read_leb+0x57d/0xba0
> ubi_leb_read+0xe5/0x1b0
> gluebi_read+0x10c/0x1a0
> mtd_read+0x112/0x340
> jffs2_verify_write+0xef/0x440
> __jffs2_flush_wbuf+0x3fa/0x3540
> jffs2_flush_wbuf_gc+0x1b1/0x2e0
> process_one_work+0x58b/0x11e0
> worker_thread+0x8f/0xfe0
> kthread+0x2ae/0x3a0
> ret_from_fork+0x35/0x40
>
> Fix the problem by checking the validity of wbuf_verify before
> using it in jffs2_verify_write().
>
> Cc: stable@vger.kernel.org
> Fixes: 0029da3bf430 ("JFFS2: add UBI support")
> Signed-off-by: Hou Tao <houtao1@huawei.com>
Reviewed-by: Richard Weinberger <richard@nod.at>
BTW: Are you actually using glubi? It is on my list of things I'd like
to kill. :-)
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-16 23:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-20 12:08 [PATCH] jffs2: ensure wbuf_verify is valid before using it Hou Tao
2018-12-09 6:35 ` Hou Tao
2018-12-15 13:24 ` Hou Tao
2018-12-16 23:56 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).