linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: cs35l41: Add 12288000 clk freq to cs35l41_fs_mon clk config
@ 2023-03-18 14:14 Jianhua Lu
  2023-03-20 19:38 ` Rhodes, David
  2023-03-21 12:46 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Jianhua Lu @ 2023-03-18 14:14 UTC (permalink / raw)
  To: James Schulman, David Rhodes, Lucas Tanure, Richard Fitzgerald,
	Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
  Cc: alsa-devel, patches, linux-kernel, ~postmarketos/upstreaming,
	phone-devel, Jianhua Lu

There are 8 cs35l41 speaker amplifier connected to TDM
in my Xiaomi Mi Pad 5 Pro tablet. In this case, it's necessary
to set 12288000 (48000 * 32 * 8) clk freq for it.

rate=48000, slot_width=32, slots=8.

Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
 sound/soc/codecs/cs35l41.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c
index 9ec01a5f09ca..6ac501f008ec 100644
--- a/sound/soc/codecs/cs35l41.c
+++ b/sound/soc/codecs/cs35l41.c
@@ -150,6 +150,7 @@ static const struct cs35l41_fs_mon_config cs35l41_fs_mon[] = {
 	{ 5644800,	16,	24 },
 	{ 6000000,	16,	24 },
 	{ 6144000,	16,	24 },
+	{ 12288000,	0,	0 },
 };
 
 static int cs35l41_get_fs_mon_config_index(int freq)
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: cs35l41: Add 12288000 clk freq to cs35l41_fs_mon clk config
  2023-03-18 14:14 [PATCH] ASoC: cs35l41: Add 12288000 clk freq to cs35l41_fs_mon clk config Jianhua Lu
@ 2023-03-20 19:38 ` Rhodes, David
  2023-03-21 12:46 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Rhodes, David @ 2023-03-20 19:38 UTC (permalink / raw)
  To: Jianhua Lu, James Schulman, David Rhodes, Lucas Tanure,
	Richard Fitzgerald, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai
  Cc: alsa-devel, patches, linux-kernel, ~postmarketos/upstreaming,
	phone-devel

On 3/18/23 9:14 AM, Jianhua Lu wrote:
> There are 8 cs35l41 speaker amplifier connected to TDM
> in my Xiaomi Mi Pad 5 Pro tablet. In this case, it's necessary
> to set 12288000 (48000 * 32 * 8) clk freq for it.
> 
> rate=48000, slot_width=32, slots=8.
> 
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
>   sound/soc/codecs/cs35l41.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c
> index 9ec01a5f09ca..6ac501f008ec 100644
> --- a/sound/soc/codecs/cs35l41.c
> +++ b/sound/soc/codecs/cs35l41.c
> @@ -150,6 +150,7 @@ static const struct cs35l41_fs_mon_config cs35l41_fs_mon[] = {
>   	{ 5644800,	16,	24 },
>   	{ 6000000,	16,	24 },
>   	{ 6144000,	16,	24 },
> +	{ 12288000,	0,	0 },
>   };
>   
>   static int cs35l41_get_fs_mon_config_index(int freq)

This is a valid clocking configuration. 12.288 MHz is already available 
in cs35l41_pll_sysclk[] as well.
Values for fs1 and fs2 are not required because cs35l41_dai_set_sysclk() 
will use hardcoded values for freq > 6.144 MHz.

Reviewed-by: David Rhodes <David.Rhodes@cirrus.com>

Thanks,
David

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: cs35l41: Add 12288000 clk freq to cs35l41_fs_mon clk config
  2023-03-18 14:14 [PATCH] ASoC: cs35l41: Add 12288000 clk freq to cs35l41_fs_mon clk config Jianhua Lu
  2023-03-20 19:38 ` Rhodes, David
@ 2023-03-21 12:46 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2023-03-21 12:46 UTC (permalink / raw)
  To: James Schulman, David Rhodes, Lucas Tanure, Richard Fitzgerald,
	Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Jianhua Lu
  Cc: alsa-devel, patches, linux-kernel, ~postmarketos/upstreaming,
	phone-devel

On Sat, 18 Mar 2023 22:14:39 +0800, Jianhua Lu wrote:
> There are 8 cs35l41 speaker amplifier connected to TDM
> in my Xiaomi Mi Pad 5 Pro tablet. In this case, it's necessary
> to set 12288000 (48000 * 32 * 8) clk freq for it.
> 
> rate=48000, slot_width=32, slots=8.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs35l41: Add 12288000 clk freq to cs35l41_fs_mon clk config
      commit: 00a7ef3242f42c38c9ffdf14ab2d729fd9754391

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-21 12:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-18 14:14 [PATCH] ASoC: cs35l41: Add 12288000 clk freq to cs35l41_fs_mon clk config Jianhua Lu
2023-03-20 19:38 ` Rhodes, David
2023-03-21 12:46 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).