From: Rajendra Nayak <rnayak@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>,
Andy Gross <andy.gross@linaro.org>
Cc: devicetree@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
linux-arm-msm@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
LKML <linux-kernel@vger.kernel.org>,
evgreen@chromium.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 3/4] arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP
Date: Thu, 22 Feb 2018 13:27:05 +0530 [thread overview]
Message-ID: <0cfcb7ce-9da8-c49a-7df7-4749d07cd365@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=WgyX-O8haJp3WpzPodV2f1sokL9hW_qe7R8hVYy3v+sg@mail.gmail.com>
On 02/22/2018 04:53 AM, Doug Anderson wrote:
> Hi,
>
> On Mon, Feb 19, 2018 at 8:36 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>>> + interrupts = <GIC_SPI 208 IRQ_TYPE_NONE>;
>>
>> Please do not use IRQ_TYPE_NONE, ever. It doesn't exist in the GIC
>> binding. Set it to the actual trigger value.
>>
>
>>> + interrupts = <GIC_SPI 481 IRQ_TYPE_NONE>;
>>
>> Same here.
>
> Thanks for the review Marc!
>
>
> Andy: If I'm reading everything correctly you're the one who would
> collect these patches and apply them. Is that right? Do they look OK
> to you in general? Would you prefer that Rajendra send out a v5 with
> the fixes pointed out by Marc, or would you prefer to fix them up
> yourself when applying? Is now a good time or would you prefer to
> wait?
I just fixed up to remove all instances of IRQ_TYPE_NONE and sent a v5 out.
>
> Thanks! :)
>
> -Doug
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2018-02-22 7:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 6:04 [PATCH v4 0/4] Add DTS for SDM845 SoC and MTP Rajendra Nayak
2018-02-16 6:05 ` [PATCH v4 1/4] dt-bindings: arm: Document kryo385 cpu Rajendra Nayak
2018-02-16 19:27 ` Doug Anderson
2018-02-16 6:05 ` [PATCH v4 2/4] dt-bindings: qcom: Add SDM845 bindings Rajendra Nayak
2018-02-16 19:27 ` Doug Anderson
2018-02-19 19:34 ` Rob Herring
2018-02-21 16:51 ` Doug Anderson
2018-02-21 23:58 ` Rob Herring
2018-02-16 6:05 ` [PATCH v4 3/4] arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP Rajendra Nayak
2018-02-16 19:28 ` Doug Anderson
2018-02-19 16:36 ` Marc Zyngier
2018-02-21 23:23 ` Doug Anderson
2018-02-22 7:57 ` Rajendra Nayak [this message]
2018-02-22 6:20 ` Rajendra Nayak
2018-02-16 6:05 ` [PATCH v4 4/4] arm64: dts: sdm845: Add serial console support Rajendra Nayak
2018-02-16 19:28 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cfcb7ce-9da8-c49a-7df7-4749d07cd365@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).