linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	evgreen@chromium.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
Subject: Re: [PATCH v4 4/4] arm64: dts: sdm845: Add serial console support
Date: Fri, 16 Feb 2018 11:28:18 -0800	[thread overview]
Message-ID: <CAD=FV=WiW9yn5o_GXot9Pu=EQpnfDTS9sBDxnE__BrwwtOZtpA@mail.gmail.com> (raw)
In-Reply-To: <20180216060503.22006-5-rnayak@codeaurora.org>

Hi,

On Thu, Feb 15, 2018 at 10:05 PM, Rajendra Nayak <rnayak@codeaurora.org> wrote:
> Add the qup uart node and geni se instance needed to
> support the serial console on the MTP.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 39 +++++++++++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/sdm845.dtsi    | 39 +++++++++++++++++++++++++++++++++
>  2 files changed, 78 insertions(+)

Looks nice to me.  Thanks!

As in your cover letter, this patch will almost certainly need to be
spun again because it's based on bindings that have review feedback.
For those of you playing along at home, see
<https://patchwork.kernel.org/patch/10162063/>.  Thus, I'm not
providing a Reviewed-by tag at the moemnt.

I will still say thanks for posting this (even though it was based on
old bindings) since it allowed us to make some good progress ahead of
time so we'll be very close to landing when the serial patch is spun
next.


In my ideal world the first 3 patches of this series would land sooner
rather than later and then this 4th patch would simply be re-posted on
its own when the bindings get more finalized (or, even better, if the
first 3 patches have landed then Karthikeyan could just glom this on
to the end of his next spin of the serial driver.  ;-)


-Doug

      reply	other threads:[~2018-02-16 19:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16  6:04 [PATCH v4 0/4] Add DTS for SDM845 SoC and MTP Rajendra Nayak
2018-02-16  6:05 ` [PATCH v4 1/4] dt-bindings: arm: Document kryo385 cpu Rajendra Nayak
2018-02-16 19:27   ` Doug Anderson
2018-02-16  6:05 ` [PATCH v4 2/4] dt-bindings: qcom: Add SDM845 bindings Rajendra Nayak
2018-02-16 19:27   ` Doug Anderson
2018-02-19 19:34   ` Rob Herring
2018-02-21 16:51     ` Doug Anderson
2018-02-21 23:58       ` Rob Herring
2018-02-16  6:05 ` [PATCH v4 3/4] arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP Rajendra Nayak
2018-02-16 19:28   ` Doug Anderson
2018-02-19 16:36   ` Marc Zyngier
2018-02-21 23:23     ` Doug Anderson
2018-02-22  7:57       ` Rajendra Nayak
2018-02-22  6:20     ` Rajendra Nayak
2018-02-16  6:05 ` [PATCH v4 4/4] arm64: dts: sdm845: Add serial console support Rajendra Nayak
2018-02-16 19:28   ` Doug Anderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=WiW9yn5o_GXot9Pu=EQpnfDTS9sBDxnE__BrwwtOZtpA@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=evgreen@chromium.org \
    --cc=kramasub@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rnayak@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).