From: Ian Abbott <abbotti@mev.co.uk>
To: Nadim almas <nadim.902@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of
Date: Tue, 2 Aug 2016 18:42:38 +0100 [thread overview]
Message-ID: <0d2f5143-c3c9-f8c1-1bb8-4d5a95ab5b68@mev.co.uk> (raw)
In-Reply-To: <1469909095-15991-1-git-send-email-nadim.902@gmail.com>
On 30/07/16 21:04, Nadim almas wrote:
> This patch compresses two lines in to a single line in file
> cb_pcidas.c
But this patch changes cb_pcidas64.c. Also, the Subject line says
'cd_pcidas'.
You can remove the 'drivers:' tag from the subject line to save some
space. It is sufficient to tag it as 'Staging: comedi: cb_pcidas64:'.
> if immediate return statement is found. It also removes variable
> bytes_written as it is no longer needed.
The patch does not remove any variables.
> It is done using script Coccinelle. And coccinelle uses following
> semantic patch for this compression function:
>
> @@
> expression e, ret;
> @@
>
> -ret =
> +return
> e;
> -return ret
>
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>
> drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
>
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index 1f9c08a..d30cf3d 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -1408,9 +1408,7 @@ static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples)
> if (retval < 0)
> return retval;
>
> - num_samples = retval * fifo->num_segments * fifo->sample_packing_ratio;
> -
> - return num_samples;
> + return retval * fifo->num_segments * fifo->sample_packing_ratio;
> }
>
> /* query length of fifo */
>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2016-08-02 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 20:04 [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of Nadim almas
2016-08-02 17:42 ` Ian Abbott [this message]
2016-08-21 14:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d2f5143-c3c9-f8c1-1bb8-4d5a95ab5b68@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nadim.902@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).