From: Yicong Yang <yangyicong@hisilicon.com>
To: Wolfram Sang <wsa@kernel.org>,
<andriy.shevchenko@linux.intel.com>, <linux-i2c@vger.kernel.org>,
<Sergey.Semin@baikalelectronics.ru>,
<linux-kernel@vger.kernel.org>, <digetx@gmail.com>,
<treding@nvidia.com>, <jarkko.nikula@linux.intel.com>,
<rmk+kernel@armlinux.org.uk>, <song.bao.hua@hisilicon.com>,
<john.garry@huawei.com>, <mika.westerberg@linux.intel.com>,
<prime.zeng@huawei.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH v6 2/5] i2c: core: add api to provide frequency mode strings
Date: Wed, 7 Apr 2021 16:29:29 +0800 [thread overview]
Message-ID: <0d48f447-d1f2-1c86-27f4-3c8b23dcaf30@hisilicon.com> (raw)
In-Reply-To: <20210406195414.GG3122@kunai>
On 2021/4/7 3:54, Wolfram Sang wrote:
>
>> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
>> index 10bd0b0..7268180 100644
>> --- a/include/linux/i2c.h
>> +++ b/include/linux/i2c.h
>> @@ -47,6 +47,26 @@ typedef int (*i2c_slave_cb_t)(struct i2c_client *client,
>> #define I2C_MAX_HIGH_SPEED_MODE_FREQ 3400000
>> #define I2C_MAX_ULTRA_FAST_MODE_FREQ 5000000
>>
>> +static inline const char *i2c_freq_mode_string(u32 bus_freq_hz)
>> +{
>> + switch (bus_freq_hz) {
>> + case I2C_MAX_STANDARD_MODE_FREQ:
>> + return "Standard Mode (100 kHz)";
>> + case I2C_MAX_FAST_MODE_FREQ:
>> + return "Fast Mode (400 kHz)";
>> + case I2C_MAX_FAST_MODE_PLUS_FREQ:
>> + return "Fast Mode Plus (1.0 MHz)";
>> + case I2C_MAX_TURBO_MODE_FREQ:
>> + return "Turbo Mode (1.4 MHz)";
>> + case I2C_MAX_HIGH_SPEED_MODE_FREQ:
>> + return "High Speed Mode (3.4 MHz)";
>> + case I2C_MAX_ULTRA_FAST_MODE_FREQ:
>> + return "Ultra Fast Mode (5.0 MHz)";
>> + default:
>> + return "Unknown Mode";
>> + }
>> +}
>
> Any reason ehy this is an inline function? My gut feeling says it would
> be better added to the core?
>
it's not a complicated function so i didn't think it'll make much difference,
so i just put it in the header along with the coresponding macro definitions.
do you want me to move it to the core?
Thanks
next prev parent reply other threads:[~2021-04-07 8:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 13:36 [PATCH v6 0/5] Add support for HiSilicon I2C controller Yicong Yang
2021-03-31 13:36 ` [PATCH v6 1/5] i2c: core: add managed function for adding i2c adapters Yicong Yang
2021-04-06 20:16 ` Wolfram Sang
2021-03-31 13:36 ` [PATCH v6 2/5] i2c: core: add api to provide frequency mode strings Yicong Yang
2021-04-06 19:54 ` Wolfram Sang
2021-04-07 8:29 ` Yicong Yang [this message]
2021-04-07 10:08 ` Andy Shevchenko
2021-04-07 10:24 ` Yicong Yang
2021-04-07 22:56 ` Wolfram Sang
2021-03-31 13:36 ` [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller Yicong Yang
2021-04-06 20:02 ` Wolfram Sang
2021-04-07 8:18 ` Yicong Yang
2021-04-07 8:32 ` Jarkko Nikula
2021-04-07 10:16 ` Yicong Yang
2021-04-07 23:04 ` Wolfram Sang
2021-04-08 7:17 ` Yicong Yang
2021-04-08 9:43 ` Andy Shevchenko
2021-03-31 13:36 ` [PATCH v6 4/5] MAINTAINERS: Add maintainer for HiSilicon I2C driver Yicong Yang
2021-03-31 13:36 ` [PATCH v6 5/5] i2c: designware: Switch over to i2c_freq_mode_string() Yicong Yang
2021-04-06 20:18 ` [PATCH v6 0/5] Add support for HiSilicon I2C controller Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d48f447-d1f2-1c86-27f4-3c8b23dcaf30@hisilicon.com \
--to=yangyicong@hisilicon.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=digetx@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=prime.zeng@huawei.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=song.bao.hua@hisilicon.com \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).