Re: [PATCH v6 2/5] i2c: core: add api to provide frequency mode strings

From: Wolfram Sang <wsa@kernel.org>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org,
	Sergey.Semin@baikalelectronics.ru, linux-kernel@vger.kernel.org,
	digetx@gmail.com, treding@nvidia.com,
	jarkko.nikula@linux.intel.com, rmk+kernel@armlinux.org.uk,
	song.bao.hua@hisilicon.com, john.garry@huawei.com,
	mika.westerberg@linux.intel.com, prime.zeng@huawei.com,
	linuxarm@huawei.com
Subject: Re: [PATCH v6 2/5] i2c: core: add api to provide frequency mode strings
Date: Tue, 6 Apr 2021 21:54:14 +0200	[thread overview]
Message-ID: <20210406195414.GG3122@kunai> (raw)
In-Reply-To: <1617197790-30627-3-git-send-email-yangyicong@hisilicon.com>

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 10bd0b0..7268180 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -47,6 +47,26 @@ typedef int (*i2c_slave_cb_t)(struct i2c_client *client,
>  #define I2C_MAX_HIGH_SPEED_MODE_FREQ	3400000
>  #define I2C_MAX_ULTRA_FAST_MODE_FREQ	5000000
>  
> +static inline const char *i2c_freq_mode_string(u32 bus_freq_hz)
> +{
> +	switch (bus_freq_hz) {
> +	case I2C_MAX_STANDARD_MODE_FREQ:
> +		return "Standard Mode (100 kHz)";
> +	case I2C_MAX_FAST_MODE_FREQ:
> +		return "Fast Mode (400 kHz)";
> +	case I2C_MAX_FAST_MODE_PLUS_FREQ:
> +		return "Fast Mode Plus (1.0 MHz)";
> +	case I2C_MAX_TURBO_MODE_FREQ:
> +		return "Turbo Mode (1.4 MHz)";
> +	case I2C_MAX_HIGH_SPEED_MODE_FREQ:
> +		return "High Speed Mode (3.4 MHz)";
> +	case I2C_MAX_ULTRA_FAST_MODE_FREQ:
> +		return "Ultra Fast Mode (5.0 MHz)";
> +	default:
> +		return "Unknown Mode";
> +	}
> +}

Any reason ehy this is an inline function? My gut feeling says it would
be better added to the core?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]