* [PATCH v1] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator
@ 2020-11-18 3:46 JC Kuo
2020-11-18 11:24 ` Jon Hunter
0 siblings, 1 reply; 3+ messages in thread
From: JC Kuo @ 2020-11-18 3:46 UTC (permalink / raw)
To: gregkh, thierry.reding, jonathanh, robh+dt
Cc: linux-kernel, linux-tegra, devicetree, JC Kuo
USB_VBUS_EN0 regulator (regulator@11) is being overwritten by vdd-cam-1v2
regulator. This commit rearrange USB_VBUS_EN0 to be regulator@14.
Signed-off-by: JC Kuo <jckuo@nvidia.com>
---
.../arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
index e18e1a9a3011..a9caaf7c0d67 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
@@ -1663,16 +1663,6 @@ vdd_usb_vbus: regulator@9 {
vin-supply = <&vdd_5v0_sys>;
};
- vdd_usb_vbus_otg: regulator@11 {
- compatible = "regulator-fixed";
- regulator-name = "USB_VBUS_EN0";
- regulator-min-microvolt = <5000000>;
- regulator-max-microvolt = <5000000>;
- gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;
- enable-active-high;
- vin-supply = <&vdd_5v0_sys>;
- };
-
vdd_hdmi: regulator@10 {
compatible = "regulator-fixed";
regulator-name = "VDD_HDMI_5V0";
@@ -1712,4 +1702,14 @@ vdd_cam_1v8: regulator@13 {
enable-active-high;
vin-supply = <&vdd_3v3_sys>;
};
+
+ vdd_usb_vbus_otg: regulator@14 {
+ compatible = "regulator-fixed";
+ regulator-name = "USB_VBUS_EN0";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ vin-supply = <&vdd_5v0_sys>;
+ };
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator
2020-11-18 3:46 [PATCH v1] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator JC Kuo
@ 2020-11-18 11:24 ` Jon Hunter
2020-11-19 2:59 ` JC Kuo
0 siblings, 1 reply; 3+ messages in thread
From: Jon Hunter @ 2020-11-18 11:24 UTC (permalink / raw)
To: JC Kuo, gregkh, thierry.reding, robh+dt
Cc: linux-kernel, linux-tegra, devicetree
On 18/11/2020 03:46, JC Kuo wrote:
> USB_VBUS_EN0 regulator (regulator@11) is being overwritten by vdd-cam-1v2
> regulator. This commit rearrange USB_VBUS_EN0 to be regulator@14.
>
> Signed-off-by: JC Kuo <jckuo@nvidia.com>
> ---
> .../arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> index e18e1a9a3011..a9caaf7c0d67 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> @@ -1663,16 +1663,6 @@ vdd_usb_vbus: regulator@9 {
> vin-supply = <&vdd_5v0_sys>;
> };
>
> - vdd_usb_vbus_otg: regulator@11 {
> - compatible = "regulator-fixed";
> - regulator-name = "USB_VBUS_EN0";
> - regulator-min-microvolt = <5000000>;
> - regulator-max-microvolt = <5000000>;
> - gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> - vin-supply = <&vdd_5v0_sys>;
> - };
> -
> vdd_hdmi: regulator@10 {
> compatible = "regulator-fixed";
> regulator-name = "VDD_HDMI_5V0";
> @@ -1712,4 +1702,14 @@ vdd_cam_1v8: regulator@13 {
> enable-active-high;
> vin-supply = <&vdd_3v3_sys>;
> };
> +
> + vdd_usb_vbus_otg: regulator@14 {
> + compatible = "regulator-fixed";
> + regulator-name = "USB_VBUS_EN0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + vin-supply = <&vdd_5v0_sys>;
> + };
> };
>
Thanks for catching this! We should add the 'Fixes:' tag.
By the way, I assume that VBUS is currently broken for the OTG port.
Without this change is that USB port completely broken? I am wondering
if we need to CC stable@vger.kernel.org on this.
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator
2020-11-18 11:24 ` Jon Hunter
@ 2020-11-19 2:59 ` JC Kuo
0 siblings, 0 replies; 3+ messages in thread
From: JC Kuo @ 2020-11-19 2:59 UTC (permalink / raw)
To: Jon Hunter, gregkh, thierry.reding, robh+dt
Cc: linux-kernel, linux-tegra, devicetree
On 11/18/20 7:24 PM, Jon Hunter wrote:
>
> On 18/11/2020 03:46, JC Kuo wrote:
>> USB_VBUS_EN0 regulator (regulator@11) is being overwritten by vdd-cam-1v2
>> regulator. This commit rearrange USB_VBUS_EN0 to be regulator@14.
>>
>> Signed-off-by: JC Kuo <jckuo@nvidia.com>
>> ---
>> .../arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 20 +++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
>> index e18e1a9a3011..a9caaf7c0d67 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
>> @@ -1663,16 +1663,6 @@ vdd_usb_vbus: regulator@9 {
>> vin-supply = <&vdd_5v0_sys>;
>> };
>>
>> - vdd_usb_vbus_otg: regulator@11 {
>> - compatible = "regulator-fixed";
>> - regulator-name = "USB_VBUS_EN0";
>> - regulator-min-microvolt = <5000000>;
>> - regulator-max-microvolt = <5000000>;
>> - gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;
>> - enable-active-high;
>> - vin-supply = <&vdd_5v0_sys>;
>> - };
>> -
>> vdd_hdmi: regulator@10 {
>> compatible = "regulator-fixed";
>> regulator-name = "VDD_HDMI_5V0";
>> @@ -1712,4 +1702,14 @@ vdd_cam_1v8: regulator@13 {
>> enable-active-high;
>> vin-supply = <&vdd_3v3_sys>;
>> };
>> +
>> + vdd_usb_vbus_otg: regulator@14 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "USB_VBUS_EN0";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + vin-supply = <&vdd_5v0_sys>;
>> + };
>> };
>>
>
> Thanks for catching this! We should add the 'Fixes:' tag.
Thanks for review. I will submit v2 and add 'Fixes:' tag.
>
> By the way, I assume that VBUS is currently broken for the OTG port.
> Without this change is that USB port completely broken? I am wondering
> if we need to CC stable@vger.kernel.org on this.
You are correct. Host mode at the OTG port is currently broken because VBUS is
not supplied to the OTG port. I will CC stable@vger.kernel.org when send v2.
>
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
>
> Cheers
> Jon
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-19 3:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 3:46 [PATCH v1] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator JC Kuo
2020-11-18 11:24 ` Jon Hunter
2020-11-19 2:59 ` JC Kuo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).