linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Michal Hocko <mhocko@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Waiman Long <longman@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Roman Gushchin <guro@fb.com>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	linux-mm@kvack.org, Shakeel Butt <shakeelb@google.com>,
	Muchun Song <songmuchun@bytedance.com>,
	Luis Goncalves <lgoncalv@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] mm/memcg: Disable task obj_stock for PREEMPT_RT
Date: Mon, 9 Aug 2021 11:28:41 +0200	[thread overview]
Message-ID: <0e282deb-ead2-2ce6-26cf-f15adcab79ca@suse.cz> (raw)
In-Reply-To: <YRDwOhVglJmY7ES5@dhcp22.suse.cz>

On 8/9/21 11:07 AM, Michal Hocko wrote:
> On Wed 04-08-21 10:33:41, Michal Hocko wrote:
>> On Wed 04-08-21 09:39:23, Vlastimil Babka wrote:
>> > On 8/4/21 1:21 AM, Thomas Gleixner wrote:
>> > > 	/*
>> > > 	 * The only protection from memory hotplug vs. drain_stock races is
>> > > 	 * that we always operate on local CPU stock here with IRQ disabled
>> > > 	 */
>> > > -	local_irq_save(flags);
>> > > +	local_lock_irqsave(memcg_stock_lock, flags);
>> > >         ...
>> > > 	if (use_task_obj_stock())
>> > >   		drain_obj_stock(&stock->task_obj);
>> > > 
>> > > which is incomprehensible garbage.
>> > > 
>> > > The comment above the existing local_irq_save() is garbage w/o any local
>> > > lock conversion already today (and even before the commit which
>> > > introduced stock::task_obj) simply because that comment does not explain
>> > > the why.
>> > 
>> > Michal, this seems to be your comment from commit 72f0184c8a00 ("mm, memcg:
>> > remove hotplug locking from try_charge"). Was "memory hotplug" a mistake,
>> > because the rest of the commit is about cpu hotplug, and I don't really see a
>> > memory hotplug connection there?
>> 
>> This part of the changelog tried to explain that part IIRC
>> "
>>     We can get rid of {get,put}_online_cpus, fortunately.  We do not have to
>>     be worried about races with memory hotplug because drain_local_stock,
>>     which is called from both the WQ draining and the memory hotplug
>>     contexts, is always operating on the local cpu stock with IRQs disabled.
>> "
>> 
>> Now I have to admit I do not remember all the details and from a quick
>> look the memory hotplug doesn't seem to be draining memcg pcp stock.
>> Maybe this has been removed since then. The only stock draining outside
>> of the memcg code seems to be memcg_hotplug_cpu_dead callback. That
>> would indicate that I really meant the cpu hotplug here indeed.
> 
> Does this look better?

Yes, thanks.

> ---
> 
> From 5aa1c8ce0d88b8c6d59ba95c7e36ca07dc2b2161 Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@suse.com>
> Date: Mon, 9 Aug 2021 10:59:04 +0200
> Subject: [PATCH] memcg: fix up drain_local_stock comment
> 
> Thomas and Vlastimil have noticed that the comment in drain_local_stock
> doesn't quite make sense. It talks about a synchronization with the
> memory hotplug but there is no actual memory hotplug involvement here.
> I meant to talk about cpu hotplug here. Fix that up and hopefuly make
> the comment more helpful by referencing the cpu hotplug callback as
> well.
> 
> Signed-off-by: Michal Hocko <mhocko@suse.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>  mm/memcontrol.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index eb8e87c4833f..f7be7b01395e 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2205,8 +2205,9 @@ static void drain_local_stock(struct work_struct *dummy)
>  	unsigned long flags;
>  
>  	/*
> -	 * The only protection from memory hotplug vs. drain_stock races is
> -	 * that we always operate on local CPU stock here with IRQ disabled
> +	 * The only protection from cpu hotplug (memcg_hotplug_cpu_dead) vs.
> +	 * drain_stock races is that we always operate on local CPU stock
> +	 * here with IRQ disabled
>  	 */
>  	local_irq_save(flags);
>  
> 


      reply	other threads:[~2021-08-09  9:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03 17:55 Waiman Long
2021-08-03 23:21 ` Thomas Gleixner
2021-08-04  1:40   ` Waiman Long
2021-08-04  8:52     ` Michal Hocko
2021-08-04 16:00     ` Waiman Long
2021-08-04  7:39   ` Vlastimil Babka
2021-08-04  8:33     ` Michal Hocko
2021-08-09  9:07       ` Michal Hocko
2021-08-09  9:28         ` Vlastimil Babka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e282deb-ead2-2ce6-26cf-f15adcab79ca@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=bristot@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=longman@redhat.com \
    --cc=mhocko@suse.com \
    --cc=shakeelb@google.com \
    --cc=songmuchun@bytedance.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH] mm/memcg: Disable task obj_stock for PREEMPT_RT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).