* [PATCH V1] bus: mhi: host: Avoid ringing EV DB if there is no elements to process
@ 2023-02-21 10:15 Vivek Pernamitta
2023-02-21 15:52 ` Jeffrey Hugo
0 siblings, 1 reply; 2+ messages in thread
From: Vivek Pernamitta @ 2023-02-21 10:15 UTC (permalink / raw)
To: mhi
Cc: quic_qianyu, manivannan.sadhasivam, Vivek Pernamitta,
Manivannan Sadhasivam, Alex Elder, Greg Kroah-Hartman,
Hemant Kumar, Jeffrey Hugo, Bhaumik Bhatt, Paul Davey,
open list:MHI BUS, open list
Avoid ringing Event DB if there is no elements to process.
As mhi_poll function can be called by mhi client drivers
which will call process_event, which will ring DB even if
there no ring elements to process.
Signed-off-by: Vivek Pernamitta <quic_vpernami@quicinc.com>
---
drivers/bus/mhi/host/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
index df0fbfe..8bf8394 100644
--- a/drivers/bus/mhi/host/main.c
+++ b/drivers/bus/mhi/host/main.c
@@ -1031,7 +1031,9 @@ int mhi_process_data_event_ring(struct mhi_controller *mhi_cntrl,
count++;
}
read_lock_bh(&mhi_cntrl->pm_lock);
- if (likely(MHI_DB_ACCESS_VALID(mhi_cntrl)))
+
+ /* Ring EV DB only if there is any pending element to process */
+ if (likely(MHI_DB_ACCESS_VALID(mhi_cntrl)) && count)
mhi_ring_er_db(mhi_event);
read_unlock_bh(&mhi_cntrl->pm_lock);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V1] bus: mhi: host: Avoid ringing EV DB if there is no elements to process
2023-02-21 10:15 [PATCH V1] bus: mhi: host: Avoid ringing EV DB if there is no elements to process Vivek Pernamitta
@ 2023-02-21 15:52 ` Jeffrey Hugo
0 siblings, 0 replies; 2+ messages in thread
From: Jeffrey Hugo @ 2023-02-21 15:52 UTC (permalink / raw)
To: Vivek Pernamitta, mhi
Cc: quic_qianyu, manivannan.sadhasivam, Manivannan Sadhasivam,
Alex Elder, Greg Kroah-Hartman, Hemant Kumar, Bhaumik Bhatt,
Paul Davey, open list:MHI BUS, open list
On 2/21/2023 3:15 AM, Vivek Pernamitta wrote:
> Avoid ringing Event DB if there is no elements to process.
> As mhi_poll function can be called by mhi client drivers
> which will call process_event, which will ring DB even if
> there no ring elements to process.
>
> Signed-off-by: Vivek Pernamitta <quic_vpernami@quicinc.com>
> ---
> drivers/bus/mhi/host/main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
> index df0fbfe..8bf8394 100644
> --- a/drivers/bus/mhi/host/main.c
> +++ b/drivers/bus/mhi/host/main.c
> @@ -1031,7 +1031,9 @@ int mhi_process_data_event_ring(struct mhi_controller *mhi_cntrl,
> count++;
> }
> read_lock_bh(&mhi_cntrl->pm_lock);
> - if (likely(MHI_DB_ACCESS_VALID(mhi_cntrl)))
> +
> + /* Ring EV DB only if there is any pending element to process */
> + if (likely(MHI_DB_ACCESS_VALID(mhi_cntrl)) && count)
> mhi_ring_er_db(mhi_event);
> read_unlock_bh(&mhi_cntrl->pm_lock);
>
Seems like this optimization also applies to mhi_process_ctrl_ev_ring().
Why not update that as well?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-21 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-21 10:15 [PATCH V1] bus: mhi: host: Avoid ringing EV DB if there is no elements to process Vivek Pernamitta
2023-02-21 15:52 ` Jeffrey Hugo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).