From: Kishon Vijay Abraham I <kishon@ti.com>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"adouglas@cadence.com" <adouglas@cadence.com>,
"niklas.cassel@axis.com" <niklas.cassel@axis.com>,
"jesper.nilsson@axis.com" <jesper.nilsson@axis.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 01/10] PCI: dwc: Add MSI-X callbacks handler
Date: Tue, 24 Apr 2018 12:37:58 +0530 [thread overview]
Message-ID: <0e8b8ce9-db12-1e11-3eb5-62f3fa686d59@ti.com> (raw)
In-Reply-To: <e2fe7d5f-9f57-0e67-d321-541ff4706792@synopsys.com>
Hi,
On Monday 23 April 2018 03:06 PM, Gustavo Pimentel wrote:
> Hi Kishon,
>
> On 16/04/2018 10:29, Kishon Vijay Abraham I wrote:
>> Hi Gustavo,
>>
>> On Tuesday 10 April 2018 10:44 PM, Gustavo Pimentel wrote:
>>> Changes the pcie_raise_irq function signature, namely the interrupt_num
>>> variable type from u8 to u16 to accommodate the MSI-X maximum interrupts
>>> of 2048.
>>>
>>> Implements a PCIe config space capability iterator function to search and
>>> save the MSI and MSI-X pointers. With this method the code becomes more
>>> generic and flexible.
>>>
>>> Implements MSI-X set/get functions for sysfs interface in order to change
>>> the EP entries number.
>>>
>>> Implements EP MSI-X interface for triggering interruptions.
>>>
>>> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
>>> ---
>>> drivers/pci/dwc/pci-dra7xx.c | 2 +-
>>> drivers/pci/dwc/pcie-artpec6.c | 2 +-
>>> drivers/pci/dwc/pcie-designware-ep.c | 145 ++++++++++++++++++++++++++++++++-
>>> drivers/pci/dwc/pcie-designware-plat.c | 6 +-
>>> drivers/pci/dwc/pcie-designware.h | 23 +++++-
>>> 5 files changed, 173 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>>> index ed8558d..5265725 100644
>>> --- a/drivers/pci/dwc/pci-dra7xx.c
>>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>>> @@ -369,7 +369,7 @@ static void dra7xx_pcie_raise_msi_irq(struct dra7xx_pcie *dra7xx,
>>> }
>>>
>>> static int dra7xx_pcie_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
>>> - enum pci_epc_irq_type type, u8 interrupt_num)
>>> + enum pci_epc_irq_type type, u16 interrupt_num)
>>> {
>>> struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
>>> struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
>>> diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c
>>> index e66cede..96dc259 100644
>>> --- a/drivers/pci/dwc/pcie-artpec6.c
>>> +++ b/drivers/pci/dwc/pcie-artpec6.c
>>> @@ -428,7 +428,7 @@ static void artpec6_pcie_ep_init(struct dw_pcie_ep *ep)
>>> }
>>>
>>> static int artpec6_pcie_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
>>> - enum pci_epc_irq_type type, u8 interrupt_num)
>>> + enum pci_epc_irq_type type, u16 interrupt_num)
>>> {
>>> struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
>>>
>>> diff --git a/drivers/pci/dwc/pcie-designware-ep.c b/drivers/pci/dwc/pcie-designware-ep.c
>>> index 15b22a6..874d4c2 100644
>>> --- a/drivers/pci/dwc/pcie-designware-ep.c
>>> +++ b/drivers/pci/dwc/pcie-designware-ep.c
>>> @@ -40,6 +40,44 @@ void dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar)
>>> __dw_pcie_ep_reset_bar(pci, bar, 0);
>>> }
>>>
>>> +void dw_pcie_ep_find_cap_addr(struct dw_pcie_ep *ep)
>>> +{
>>
>> This should be implemented in a generic way similar to pci_find_capability().
>> It'll be useful when we try to implement other capabilities as well.
>
> Hum, what you suggest? Something implemented on the pci-epf-core?
yeah, Initially thought it could be implemented as a helper function in
pci-epc-core so that both designware and cadence can use it.
But do we really have to find the address like this? since all designware IP's
will have a particular capability at a fixed address offset, why not follow use
existing mechanism in dw_pcie_ep_get_msi?
Or is it possible for a particular capability to have address offsets for
different vendors? How is it for cadence?
Thanks
Kishon
next prev parent reply other threads:[~2018-04-24 7:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 17:14 [RFC 00/10] Adds pcitest tool support for MSI-X Gustavo Pimentel
2018-04-10 17:14 ` [RFC 01/10] PCI: dwc: Add MSI-X callbacks handler Gustavo Pimentel
2018-04-16 9:29 ` Kishon Vijay Abraham I
2018-04-23 9:36 ` Gustavo Pimentel
2018-04-24 7:07 ` Kishon Vijay Abraham I [this message]
2018-04-24 9:36 ` Gustavo Pimentel
2018-04-24 11:24 ` Kishon Vijay Abraham I
2018-04-26 15:30 ` Gustavo Pimentel
2018-04-24 14:05 ` Alan Douglas
2018-04-24 9:15 ` Alan Douglas
2018-04-24 11:43 ` Gustavo Pimentel
2018-05-10 10:40 ` Gustavo Pimentel
2018-04-10 17:14 ` [RFC 02/10] PCI: cadence: Update cdns_pcie_ep_raise_irq function signature Gustavo Pimentel
2018-04-13 16:05 ` Alan Douglas
2018-04-10 17:14 ` [RFC 03/10] PCI: endpoint: Add MSI-X interfaces Gustavo Pimentel
2018-04-17 10:24 ` Kishon Vijay Abraham I
2018-04-17 15:51 ` Gustavo Pimentel
2018-04-10 17:14 ` [RFC 04/10] PCI: dwc: MSI callbacks handler rework Gustavo Pimentel
2018-04-10 17:14 ` [RFC 05/10] PCI: dwc: Add legacy interrupt callback handler Gustavo Pimentel
2018-04-10 17:14 ` [RFC 06/10] misc: pci_endpoint_test: Add MSI-X support Gustavo Pimentel
2018-04-17 10:33 ` Kishon Vijay Abraham I
2018-04-17 17:38 ` Gustavo Pimentel
2018-04-24 7:19 ` Kishon Vijay Abraham I
2018-04-24 10:57 ` Gustavo Pimentel
2018-04-24 11:43 ` Kishon Vijay Abraham I
2018-04-26 15:36 ` Gustavo Pimentel
2018-04-24 6:59 ` Alan Douglas
2018-04-24 11:11 ` Gustavo Pimentel
2018-04-10 17:14 ` [RFC 07/10] misc: pci_endpoint_test: Replace lower into upper case characters Gustavo Pimentel
2018-04-10 17:14 ` [RFC 08/10] PCI: endpoint: functions/pci-epf-test: Add MSI-X support Gustavo Pimentel
2018-04-10 17:14 ` [RFC 09/10] PCI: endpoint: functions/pci-epf-test: Replace lower into upper case characters Gustavo Pimentel
2018-04-10 17:14 ` [RFC 10/10] tools: PCI: Add MSI-X support Gustavo Pimentel
2018-04-24 9:57 ` Alan Douglas
2018-04-24 17:18 ` Gustavo Pimentel
2018-04-24 6:48 ` [RFC 00/10] Adds pcitest tool support for MSI-X Alan Douglas
2018-04-24 8:49 ` Gustavo Pimentel
2018-04-24 9:28 ` Alan Douglas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e8b8ce9-db12-1e11-3eb5-62f3fa686d59@ti.com \
--to=kishon@ti.com \
--cc=Joao.Pinto@synopsys.com \
--cc=adouglas@cadence.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jesper.nilsson@axis.com \
--cc=jingoohan1@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=niklas.cassel@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).