From: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"jgg@nvidia.com" <jgg@nvidia.com>, Linuxarm <linuxarm@huawei.com>,
liulongfang <liulongfang@huawei.com>,
"Zengtao (B)" <prime.zeng@hisilicon.com>,
yuzenghui <yuzenghui@huawei.com>,
"Jonathan Cameron" <jonathan.cameron@huawei.com>,
"Wangzhou (B)" <wangzhou1@hisilicon.com>
Subject: RE: [RFC v2 3/4] crypto: hisilicon/qm - Export mailbox functions for common use
Date: Mon, 5 Jul 2021 10:23:12 +0000 [thread overview]
Message-ID: <0ebcb89c4fc64d289d5ffcdfe03529ec@huawei.com> (raw)
In-Reply-To: <2f9c5fee-fcd1-3512-fef8-f2707df621ba@nvidia.com>
> -----Original Message-----
> From: Max Gurtovoy [mailto:mgurtovoy@nvidia.com]
> Sent: 04 July 2021 10:34
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>;
> kvm@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-crypto@vger.kernel.org
> Cc: alex.williamson@redhat.com; jgg@nvidia.com; Linuxarm
> <linuxarm@huawei.com>; liulongfang <liulongfang@huawei.com>; Zengtao (B)
> <prime.zeng@hisilicon.com>; yuzenghui <yuzenghui@huawei.com>; Jonathan
> Cameron <jonathan.cameron@huawei.com>; Wangzhou (B)
> <wangzhou1@hisilicon.com>
> Subject: Re: [RFC v2 3/4] crypto: hisilicon/qm - Export mailbox functions for
> common use
>
>
> On 7/2/2021 12:58 PM, Shameer Kolothum wrote:
> > From: Longfang Liu <liulongfang@huawei.com>
> >
> > Export QM mailbox functions so that they can be used from HiSilicon
> > ACC vfio live migration driver in follow-up patch.
> >
> > Signed-off-by: Longfang Liu <liulongfang@huawei.com>
> > Signed-off-by: Shameer Kolothum
> <shameerali.kolothum.thodi@huawei.com>
> > ---
> > drivers/crypto/hisilicon/qm.c | 8 +++++---
> > drivers/crypto/hisilicon/qm.h | 4 ++++
> > 2 files changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/crypto/hisilicon/qm.c
> > b/drivers/crypto/hisilicon/qm.c index ce439a0c66c9..87fc0199705e
> > 100644
> > --- a/drivers/crypto/hisilicon/qm.c
> > +++ b/drivers/crypto/hisilicon/qm.c
> > @@ -492,7 +492,7 @@ static bool qm_qp_avail_state(struct hisi_qm *qm,
> struct hisi_qp *qp,
> > }
> >
> > /* return 0 mailbox ready, -ETIMEDOUT hardware timeout */ -static
> > int qm_wait_mb_ready(struct hisi_qm *qm)
> > +int qm_wait_mb_ready(struct hisi_qm *qm)
> > {
> > u32 val;
> >
> > @@ -500,6 +500,7 @@ static int qm_wait_mb_ready(struct hisi_qm *qm)
> > val, !((val >> QM_MB_BUSY_SHIFT) &
> > 0x1), POLL_PERIOD, POLL_TIMEOUT);
> > }
> > +EXPORT_SYMBOL_GPL(qm_wait_mb_ready);
> >
> > /* 128 bit should be written to hardware at one time to trigger a mailbox
> */
> > static void qm_mb_write(struct hisi_qm *qm, const void *src) @@
> > -523,8 +524,8 @@ static void qm_mb_write(struct hisi_qm *qm, const void
> *src)
> > : "memory");
> > }
> >
> > -static int qm_mb(struct hisi_qm *qm, u8 cmd, dma_addr_t dma_addr, u16
> queue,
> > - bool op)
> > +int qm_mb(struct hisi_qm *qm, u8 cmd, dma_addr_t dma_addr, u16 queue,
> > + bool op)
> > {
> > struct qm_mailbox mailbox;
> > int ret = 0;
> > @@ -563,6 +564,7 @@ static int qm_mb(struct hisi_qm *qm, u8 cmd,
> dma_addr_t dma_addr, u16 queue,
> > atomic64_inc(&qm->debug.dfx.mb_err_cnt);
> > return ret;
> > }
> > +EXPORT_SYMBOL_GPL(qm_mb);
> >
> > static void qm_db_v1(struct hisi_qm *qm, u16 qn, u8 cmd, u16 index, u8
> priority)
> > {
> > diff --git a/drivers/crypto/hisilicon/qm.h
> > b/drivers/crypto/hisilicon/qm.h index acefdf8b3a50..18b010d5452d
> > 100644
> > --- a/drivers/crypto/hisilicon/qm.h
> > +++ b/drivers/crypto/hisilicon/qm.h
> > @@ -396,6 +396,10 @@ pci_ers_result_t hisi_qm_dev_slot_reset(struct
> pci_dev *pdev);
> > void hisi_qm_reset_prepare(struct pci_dev *pdev);
> > void hisi_qm_reset_done(struct pci_dev *pdev);
> >
> > +int qm_wait_mb_ready(struct hisi_qm *qm); int qm_mb(struct hisi_qm
> > +*qm, u8 cmd, dma_addr_t dma_addr, u16 queue,
> > + bool op);
> > +
>
> maybe you can put it under include/linux/.. ?
Ok. I suppose we could do that.
Thanks,
Shameer
>
>
> > struct hisi_acc_sgl_pool;
> > struct hisi_acc_hw_sgl *hisi_acc_sg_buf_map_to_hw_sgl(struct device
> *dev,
> > struct scatterlist *sgl, struct hisi_acc_sgl_pool *pool,
next prev parent reply other threads:[~2021-07-05 10:23 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 9:58 [RFC v2 0/4] vfio/hisilicon: add acc live migration driver Shameer Kolothum
2021-07-02 9:58 ` [RFC v2 1/4] hisi-acc-vfio-pci: add new vfio_pci driver for HiSilicon ACC devices Shameer Kolothum
2021-07-02 20:29 ` Alex Williamson
2021-07-05 7:20 ` Shameerali Kolothum Thodi
2021-07-04 7:03 ` Leon Romanovsky
2021-07-05 8:47 ` Shameerali Kolothum Thodi
2021-07-05 9:41 ` Max Gurtovoy
2021-07-05 10:18 ` Shameerali Kolothum Thodi
2021-07-05 18:27 ` Leon Romanovsky
2021-07-05 18:32 ` Jason Gunthorpe
2021-07-06 3:59 ` Leon Romanovsky
2021-07-06 4:39 ` Christoph Hellwig
2021-07-06 11:51 ` Jason Gunthorpe
2021-07-02 9:58 ` [RFC v2 2/4] hisi_acc_vfio_pci: Override ioctl method to limit BAR2 region size Shameer Kolothum
2021-07-02 20:29 ` Alex Williamson
2021-07-05 7:22 ` Shameerali Kolothum Thodi
2021-07-02 9:58 ` [RFC v2 3/4] crypto: hisilicon/qm - Export mailbox functions for common use Shameer Kolothum
2021-07-04 9:34 ` Max Gurtovoy
2021-07-05 10:23 ` Shameerali Kolothum Thodi [this message]
2021-07-02 9:58 ` [RFC v2 4/4] hisi_acc_vfio_pci: Add support for vfio live migration Shameer Kolothum
2022-02-02 13:14 ` [RFC v2 0/4] vfio/hisilicon: add acc live migration driver Jason Gunthorpe
2022-02-02 14:34 ` Shameerali Kolothum Thodi
2022-02-02 15:39 ` Jason Gunthorpe
2022-02-02 16:10 ` Shameerali Kolothum Thodi
2022-02-02 17:03 ` Jason Gunthorpe
2022-02-02 19:05 ` Joao Martins
2022-02-03 15:18 ` Jason Gunthorpe
2022-02-04 19:53 ` Joao Martins
2022-02-04 23:07 ` Jason Gunthorpe
2022-02-11 17:28 ` Joao Martins
2022-02-11 17:49 ` Jason Gunthorpe
2022-02-11 21:43 ` Joao Martins
2022-02-12 0:01 ` Jason Gunthorpe
2022-02-14 13:34 ` Joao Martins
2022-02-14 14:06 ` Jason Gunthorpe
2022-02-15 16:00 ` Joao Martins
2022-02-15 16:21 ` Jason Gunthorpe
2022-02-22 11:55 ` Joao Martins
2022-02-23 1:03 ` Jason Gunthorpe
2022-02-25 19:18 ` Joao Martins
2022-02-25 20:44 ` Jason Gunthorpe
2022-02-28 13:01 ` Joao Martins
2022-02-28 21:01 ` Jason Gunthorpe
2022-03-01 13:06 ` Joao Martins
2022-03-01 13:54 ` Jason Gunthorpe
2022-03-01 14:27 ` Joao Martins
2022-03-11 13:51 ` iommufd(+vfio-compat) dirty tracking (Was: Re: [RFC v2 0/4] vfio/hisilicon: add acc live migration driver) Joao Martins
2022-03-15 19:29 ` Jason Gunthorpe
2022-03-16 16:36 ` iommufd(+vfio-compat) dirty tracking Joao Martins
2022-03-16 20:37 ` Joao Martins
2022-03-18 17:12 ` Joao Martins
2022-03-18 17:34 ` Jason Gunthorpe
2022-02-02 17:30 ` [RFC v2 0/4] vfio/hisilicon: add acc live migration driver Alex Williamson
2022-02-02 18:04 ` Jason Gunthorpe
2022-02-18 16:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ebcb89c4fc64d289d5ffcdfe03529ec@huawei.com \
--to=shameerali.kolothum.thodi@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=jgg@nvidia.com \
--cc=jonathan.cameron@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liulongfang@huawei.com \
--cc=mgurtovoy@nvidia.com \
--cc=prime.zeng@hisilicon.com \
--cc=wangzhou1@hisilicon.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).