From: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
To: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-crypto@vger.kernel.org>
Cc: <alex.williamson@redhat.com>, <jgg@nvidia.com>,
<mgurtovoy@nvidia.com>, <linuxarm@huawei.com>,
<liulongfang@huawei.com>, <prime.zeng@hisilicon.com>,
<yuzenghui@huawei.com>, <jonathan.cameron@huawei.com>,
<wangzhou1@hisilicon.com>
Subject: [RFC v2 2/4] hisi_acc_vfio_pci: Override ioctl method to limit BAR2 region size
Date: Fri, 2 Jul 2021 10:58:47 +0100 [thread overview]
Message-ID: <20210702095849.1610-3-shameerali.kolothum.thodi@huawei.com> (raw)
In-Reply-To: <20210702095849.1610-1-shameerali.kolothum.thodi@huawei.com>
HiSilicon ACC VF device BAR2 region consists of both functional register
space and migration control register space. From a security point of
view, it's not advisable to export the migration control region to Guest.
Hence, hide the migration region and report only the functional register
space.
Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
---
drivers/vfio/pci/hisi_acc_vfio_pci.c | 42 +++++++++++++++++++++++++++-
1 file changed, 41 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/pci/hisi_acc_vfio_pci.c b/drivers/vfio/pci/hisi_acc_vfio_pci.c
index a9e173098ab5..d57cf6d7adaf 100644
--- a/drivers/vfio/pci/hisi_acc_vfio_pci.c
+++ b/drivers/vfio/pci/hisi_acc_vfio_pci.c
@@ -12,6 +12,46 @@
#include <linux/vfio.h>
#include <linux/vfio_pci_core.h>
+static long hisi_acc_vfio_pci_ioctl(struct vfio_device *core_vdev, unsigned int cmd,
+ unsigned long arg)
+{
+ struct vfio_pci_core_device *vdev =
+ container_of(core_vdev, struct vfio_pci_core_device, vdev);
+
+ if (cmd == VFIO_DEVICE_GET_REGION_INFO) {
+ struct pci_dev *pdev = vdev->pdev;
+ struct vfio_region_info info;
+ unsigned long minsz;
+
+ minsz = offsetofend(struct vfio_region_info, offset);
+
+ if (copy_from_user(&info, (void __user *)arg, minsz))
+ return -EFAULT;
+
+ if (info.argsz < minsz)
+ return -EINVAL;
+
+ if (info.index == VFIO_PCI_BAR2_REGION_INDEX) {
+ info.offset = VFIO_PCI_INDEX_TO_OFFSET(info.index);
+
+ /*
+ * ACC VF dev BAR2 region(64K) consists of both functional
+ * register space and migration control register space.
+ * Report only the first 32K(functional region) to Guest.
+ */
+ info.size = pci_resource_len(pdev, info.index) / 2;
+
+ info.flags = VFIO_REGION_INFO_FLAG_READ |
+ VFIO_REGION_INFO_FLAG_WRITE |
+ VFIO_REGION_INFO_FLAG_MMAP;
+
+ return copy_to_user((void __user *)arg, &info, minsz) ?
+ -EFAULT : 0;
+ }
+ }
+ return vfio_pci_core_ioctl(core_vdev, cmd, arg);
+}
+
static int hisi_acc_vfio_pci_open(struct vfio_device *core_vdev)
{
struct vfio_pci_core_device *vdev =
@@ -33,7 +73,7 @@ static const struct vfio_device_ops hisi_acc_vfio_pci_ops = {
.name = "hisi-acc-vfio-pci",
.open = hisi_acc_vfio_pci_open,
.release = vfio_pci_core_release,
- .ioctl = vfio_pci_core_ioctl,
+ .ioctl = hisi_acc_vfio_pci_ioctl,
.read = vfio_pci_core_read,
.write = vfio_pci_core_write,
.mmap = vfio_pci_core_mmap,
--
2.17.1
next prev parent reply other threads:[~2021-07-02 9:59 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 9:58 [RFC v2 0/4] vfio/hisilicon: add acc live migration driver Shameer Kolothum
2021-07-02 9:58 ` [RFC v2 1/4] hisi-acc-vfio-pci: add new vfio_pci driver for HiSilicon ACC devices Shameer Kolothum
2021-07-02 20:29 ` Alex Williamson
2021-07-05 7:20 ` Shameerali Kolothum Thodi
2021-07-04 7:03 ` Leon Romanovsky
2021-07-05 8:47 ` Shameerali Kolothum Thodi
2021-07-05 9:41 ` Max Gurtovoy
2021-07-05 10:18 ` Shameerali Kolothum Thodi
2021-07-05 18:27 ` Leon Romanovsky
2021-07-05 18:32 ` Jason Gunthorpe
2021-07-06 3:59 ` Leon Romanovsky
2021-07-06 4:39 ` Christoph Hellwig
2021-07-06 11:51 ` Jason Gunthorpe
2021-07-02 9:58 ` Shameer Kolothum [this message]
2021-07-02 20:29 ` [RFC v2 2/4] hisi_acc_vfio_pci: Override ioctl method to limit BAR2 region size Alex Williamson
2021-07-05 7:22 ` Shameerali Kolothum Thodi
2021-07-02 9:58 ` [RFC v2 3/4] crypto: hisilicon/qm - Export mailbox functions for common use Shameer Kolothum
2021-07-04 9:34 ` Max Gurtovoy
2021-07-05 10:23 ` Shameerali Kolothum Thodi
2021-07-02 9:58 ` [RFC v2 4/4] hisi_acc_vfio_pci: Add support for vfio live migration Shameer Kolothum
2022-02-02 13:14 ` [RFC v2 0/4] vfio/hisilicon: add acc live migration driver Jason Gunthorpe
2022-02-02 14:34 ` Shameerali Kolothum Thodi
2022-02-02 15:39 ` Jason Gunthorpe
2022-02-02 16:10 ` Shameerali Kolothum Thodi
2022-02-02 17:03 ` Jason Gunthorpe
2022-02-02 19:05 ` Joao Martins
2022-02-03 15:18 ` Jason Gunthorpe
2022-02-04 19:53 ` Joao Martins
2022-02-04 23:07 ` Jason Gunthorpe
2022-02-11 17:28 ` Joao Martins
2022-02-11 17:49 ` Jason Gunthorpe
2022-02-11 21:43 ` Joao Martins
2022-02-12 0:01 ` Jason Gunthorpe
2022-02-14 13:34 ` Joao Martins
2022-02-14 14:06 ` Jason Gunthorpe
2022-02-15 16:00 ` Joao Martins
2022-02-15 16:21 ` Jason Gunthorpe
2022-02-22 11:55 ` Joao Martins
2022-02-23 1:03 ` Jason Gunthorpe
2022-02-25 19:18 ` Joao Martins
2022-02-25 20:44 ` Jason Gunthorpe
2022-02-28 13:01 ` Joao Martins
2022-02-28 21:01 ` Jason Gunthorpe
2022-03-01 13:06 ` Joao Martins
2022-03-01 13:54 ` Jason Gunthorpe
2022-03-01 14:27 ` Joao Martins
2022-03-11 13:51 ` iommufd(+vfio-compat) dirty tracking (Was: Re: [RFC v2 0/4] vfio/hisilicon: add acc live migration driver) Joao Martins
2022-03-15 19:29 ` Jason Gunthorpe
2022-03-16 16:36 ` iommufd(+vfio-compat) dirty tracking Joao Martins
2022-03-16 20:37 ` Joao Martins
2022-03-18 17:12 ` Joao Martins
2022-03-18 17:34 ` Jason Gunthorpe
2022-02-02 17:30 ` [RFC v2 0/4] vfio/hisilicon: add acc live migration driver Alex Williamson
2022-02-02 18:04 ` Jason Gunthorpe
2022-02-18 16:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702095849.1610-3-shameerali.kolothum.thodi@huawei.com \
--to=shameerali.kolothum.thodi@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=jgg@nvidia.com \
--cc=jonathan.cameron@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liulongfang@huawei.com \
--cc=mgurtovoy@nvidia.com \
--cc=prime.zeng@hisilicon.com \
--cc=wangzhou1@hisilicon.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).