From: Joe Perches <joe@perches.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
Christopher S Hall <christopher.s.hall@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PTP: introduce new versions of IOCTLs
Date: Mon, 19 Aug 2019 08:58:22 -0700 [thread overview]
Message-ID: <0f1487356ae2e9ff185ede2359381630007538c7.camel@perches.com> (raw)
In-Reply-To: <20190819154320.GB2883@localhost>
On Mon, 2019-08-19 at 08:43 -0700, Richard Cochran wrote:
> On Sun, Aug 18, 2019 at 03:07:18PM -0700, Joe Perches wrote:
> > Also the original patch deletes 2 case entries for
> > PTP_PIN_GETFUNC and PTP_PIN_SETFUNC and converts them to
> > PTP_PIN_GETFUNC2 and PTP_PIN_SETFUNC2 but still uses tests
> > for the deleted case label entries making part of the case
> > code block unreachable.
> >
> > That's at least a defect:
> >
> > - case PTP_PIN_GETFUNC:
> > + case PTP_PIN_GETFUNC2:
> >
> > and
> >
> > - case PTP_PIN_SETFUNC:
> > + case PTP_PIN_SETFUNC2:
>
> Good catch. Felipe, please fix that!
>
> (Regarding Joe's memset suggestion, I'll leave that to your discretion.)
Not just how declarations are done or memset.
Minimizing unnecessary stack consumption is generally good.
next prev parent reply other threads:[~2019-08-19 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 7:47 [PATCH 1/2] PTP: introduce new versions of IOCTLs Felipe Balbi
2019-08-14 7:47 ` [PATCH 2/2] PTP: add support for one-shot output Felipe Balbi
2019-08-17 16:03 ` Richard Cochran
2019-08-17 15:59 ` [PATCH 1/2] PTP: introduce new versions of IOCTLs Richard Cochran
2019-08-17 16:17 ` Joe Perches
2019-08-18 20:11 ` Richard Cochran
2019-08-18 22:07 ` Joe Perches
2019-08-19 15:43 ` Richard Cochran
2019-08-19 15:58 ` Joe Perches [this message]
2019-08-28 8:23 ` Felipe Balbi
2019-08-28 12:57 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f1487356ae2e9ff185ede2359381630007538c7.camel@perches.com \
--to=joe@perches.com \
--cc=christopher.s.hall@intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).