From: Richard Cochran <richardcochran@gmail.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Christopher S Hall <christopher.s.hall@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] PTP: add support for one-shot output
Date: Sat, 17 Aug 2019 09:03:42 -0700 [thread overview]
Message-ID: <20190817160342.GB1540@localhost> (raw)
In-Reply-To: <20190814074712.10684-2-felipe.balbi@linux.intel.com>
On Wed, Aug 14, 2019 at 10:47:12AM +0300, Felipe Balbi wrote:
> diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h
> index 039cd62ec706..9412b16cc8ed 100644
> --- a/include/uapi/linux/ptp_clock.h
> +++ b/include/uapi/linux/ptp_clock.h
> @@ -67,7 +67,9 @@ struct ptp_perout_request {
> struct ptp_clock_time start; /* Absolute start time. */
> struct ptp_clock_time period; /* Desired period, zero means disable. */
> unsigned int index; /* Which channel to configure. */
> - unsigned int flags; /* Reserved for future use. */
> +
> +#define PTP_PEROUT_ONE_SHOT BIT(0)
> + unsigned int flags; /* Bit 0 -> oneshot output. */
The .flags field doesn't need this comment. The individual BIT macro
names should be clear enough, and if not, then comment the macros.
> unsigned int rsv[4]; /* Reserved for future use. */
> };
>
> --
> 2.22.0
>
Reviewed-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2019-08-17 16:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 7:47 [PATCH 1/2] PTP: introduce new versions of IOCTLs Felipe Balbi
2019-08-14 7:47 ` [PATCH 2/2] PTP: add support for one-shot output Felipe Balbi
2019-08-17 16:03 ` Richard Cochran [this message]
2019-08-17 15:59 ` [PATCH 1/2] PTP: introduce new versions of IOCTLs Richard Cochran
2019-08-17 16:17 ` Joe Perches
2019-08-18 20:11 ` Richard Cochran
2019-08-18 22:07 ` Joe Perches
2019-08-19 15:43 ` Richard Cochran
2019-08-19 15:58 ` Joe Perches
2019-08-28 8:23 ` Felipe Balbi
2019-08-28 12:57 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190817160342.GB1540@localhost \
--to=richardcochran@gmail.com \
--cc=christopher.s.hall@intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).