Re: [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature_persistent'

[Juergen Gross <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1846 bytes --]

On 16.07.22 00:51, SeongJae Park wrote:
> Introduction of 'feature_persistent' made two bugs.  First one is wrong
> overwrite of 'vbd->feature_gnt_persistent' in 'blkback' due to wrong
> parameter value caching position, and the second one is unintended
> behavioral change that could break previous dynamic frontend/backend
> persistent feature support changes.  This patchset fixes the issues.
> 
> Changes from v3
> (https://lore.kernel.org/xen-devel/20220715175521.126649-1-sj@kernel.org/)
> - Split 'blkback' patch for each of the two issues
> - Add 'Reported-by: Andrii Chepurnyi <andrii.chepurnyi82@gmail.com>'
> 
> Changes from v2
> (https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/)
> - Keep the behavioral change of v1
> - Update blkfront's counterpart to follow the changed behavior
> - Update documents for the changed behavior
> 
> Changes from v1
> (https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/)
> - Avoid the behavioral change
>    (https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/)
> - Rebase on latest xen/tip/linux-next
> - Re-work by SeongJae Park <sj@kernel.org>
> - Cc stable@
> 
> Maximilian Heyne (1):
>    xen-blkback: Apply 'feature_persistent' parameter when connect
> 
> SeongJae Park (2):
>    xen-blkback: fix persistent grants negotiation
>    xen-blkfront: Apply 'feature_persistent' parameter when connect
> 
>   .../ABI/testing/sysfs-driver-xen-blkback      |  2 +-
>   .../ABI/testing/sysfs-driver-xen-blkfront     |  2 +-
>   drivers/block/xen-blkback/xenbus.c            | 20 ++++++++-----------
>   drivers/block/xen-blkfront.c                  |  4 +---
>   4 files changed, 11 insertions(+), 17 deletions(-)
> 

For the series:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]