From: Maximilian Heyne <mheyne@amazon.de>
To: SeongJae Park <sj@kernel.org>
Cc: <roger.pau@citrix.com>, <axboe@kernel.dk>,
<boris.ostrovsky@oracle.com>, <jgross@suse.com>,
<olekstysh@gmail.com>, <andrii.chepurnyi82@gmail.com>,
<xen-devel@lists.xenproject.org>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v4 0/3] xen-blk{back, front}: Fix two bugs in 'feature_persistent'
Date: Mon, 1 Aug 2022 12:17:09 +0000 [thread overview]
Message-ID: <20220801121709.GA40940@dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com> (raw)
In-Reply-To: <20220715225108.193398-1-sj@kernel.org>
On Fri, Jul 15, 2022 at 10:51:05PM +0000, SeongJae Park wrote:
>
> Introduction of 'feature_persistent' made two bugs. First one is wrong
> overwrite of 'vbd->feature_gnt_persistent' in 'blkback' due to wrong
> parameter value caching position, and the second one is unintended
> behavioral change that could break previous dynamic frontend/backend
> persistent feature support changes. This patchset fixes the issues.
>
> Changes from v3
> (https://lore.kernel.org/xen-devel/20220715175521.126649-1-sj@kernel.org/)
> - Split 'blkback' patch for each of the two issues
> - Add 'Reported-by: Andrii Chepurnyi <andrii.chepurnyi82@gmail.com>'
>
> Changes from v2
> (https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/)
> - Keep the behavioral change of v1
> - Update blkfront's counterpart to follow the changed behavior
> - Update documents for the changed behavior
>
> Changes from v1
> (https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/)
> - Avoid the behavioral change
> (https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/)
> - Rebase on latest xen/tip/linux-next
> - Re-work by SeongJae Park <sj@kernel.org>
> - Cc stable@
>
> Maximilian Heyne (1):
> xen-blkback: Apply 'feature_persistent' parameter when connect
>
> SeongJae Park (2):
> xen-blkback: fix persistent grants negotiation
> xen-blkfront: Apply 'feature_persistent' parameter when connect
>
> .../ABI/testing/sysfs-driver-xen-blkback | 2 +-
> .../ABI/testing/sysfs-driver-xen-blkfront | 2 +-
> drivers/block/xen-blkback/xenbus.c | 20 ++++++++-----------
> drivers/block/xen-blkfront.c | 4 +---
> 4 files changed, 11 insertions(+), 17 deletions(-)
>
> --
> 2.25.1
>
Changes look good to me. Thank you for reworking my patch and also fixing the
blkfront driver.
Reviewed-by: Maximilian Heyne <mheyne@amazon.de>
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2022-08-01 12:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 22:51 [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature_persistent' SeongJae Park
2022-07-15 22:51 ` [PATCH v4 1/3] xen-blkback: fix persistent grants negotiation SeongJae Park
2022-07-15 22:51 ` [PATCH v4 2/3] xen-blkback: Apply 'feature_persistent' parameter when connect SeongJae Park
2022-07-15 22:51 ` [PATCH v4 3/3] xen-blkfront: " SeongJae Park
2022-07-18 16:12 ` [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature_persistent' Andrii Chepurnyi
2022-08-01 12:17 ` Maximilian Heyne [this message]
2022-08-12 10:08 ` Juergen Gross
2022-08-14 8:36 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801121709.GA40940@dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com \
--to=mheyne@amazon.de \
--cc=andrii.chepurnyi82@gmail.com \
--cc=axboe@kernel.dk \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olekstysh@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sj@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).