From: Heiko Stuebner <heiko@sntech.de>
To: Frank Wunderlich <frank-w@public-files.de>,
Peter Geis <pgwipeout@gmail.com>
Cc: Dan Johansen <strit@manjaro.org>,
Frank Wunderlich <linux@fw-web.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Michael Riesch <michael.riesch@wolfvision.net>,
devicetree <devicetree@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb
Date: Sun, 10 Apr 2022 18:53:17 +0200 [thread overview]
Message-ID: <10062144.nUPlyArG6x@phil> (raw)
In-Reply-To: <CAMdYzYpK-RTf_8FVte2QLJawCKCjU6efgkRjsBj6quWGSSE6xA@mail.gmail.com>
Am Samstag, 9. April 2022, 17:26:01 CEST schrieb Peter Geis:
> On Sat, Apr 9, 2022 at 7:56 AM Frank Wunderlich <frank-w@public-files.de> wrote:
> >
> > Hi,
> >
> > so to not break the binding and other boards the right Patch should be like this
> >
> > +++ b/drivers/usb/dwc3/core.c
> > @@ -1691,17 +1691,17 @@ static int dwc3_probe(struct platform_device *pdev)
> > * Clocks are optional, but new DT platforms should support all
> > * clocks as required by the DT-binding.
> > */
> > - dwc->bus_clk = devm_clk_get_optional(dev, "bus_early");
> > + dwc->bus_clk = devm_clk_get_optional(dev, "bus_clk");
> > if (IS_ERR(dwc->bus_clk))
> > return dev_err_probe(dev, PTR_ERR(dwc->bus_clk),
> > "could not get bus clock\n");
> >
> > - dwc->ref_clk = devm_clk_get_optional(dev, "ref");
> > + dwc->ref_clk = devm_clk_get_optional(dev, "ref_clk");
> > if (IS_ERR(dwc->ref_clk))
> > return dev_err_probe(dev, PTR_ERR(dwc->ref_clk),
> > "could not get ref clock\n");
> >
> > - dwc->susp_clk = devm_clk_get_optional(dev, "suspend");
> > + dwc->susp_clk = devm_clk_get_optional(dev, "suspend_clk");
> > if (IS_ERR(dwc->susp_clk))
> > return dev_err_probe(dev, PTR_ERR(dwc->susp_clk),
> > "could not get suspend clock\n");
> >
> > but this needs fixing dts using the new clock names
> >
> > this is a link to the series moving from bulk_clk to named clocks:
> >
> > https://patchwork.kernel.org/project/linux-usb/patch/20220127200636.1456175-3-sean.anderson@seco.com/
> >
> > regards Frank
>
> I've submitted a fix for the backwards compatibility issue.
> https://patchwork.kernel.org/project/linux-rockchip/patch/20220409152116.3834354-1-pgwipeout@gmail.com/
>
> This fix is standalone and necessary no matter which route we decide
> to go with this series (and the rk3328/rk3399 support as well).
> With this patch, dwc3 is functional on the rk356x as the series was
> submitted, so if we decide to fix everything all at once, that is a
> viable option.
Thanks for doing that fix.
As the usb-dt-series is actually following the rockchip,dwc3 binding,
and "just" the driver does ignore it, I've now applied the usb series
and hope for a resolution of the general problem :-)
Heiko
prev parent reply other threads:[~2022-04-10 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 7:51 [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb Frank Wunderlich
2022-04-09 10:14 ` Aw: " Frank Wunderlich
2022-04-09 10:23 ` Heiko Stuebner
2022-04-09 10:32 ` Aw: " Frank Wunderlich
2022-04-09 10:40 ` Dan Johansen
2022-04-09 10:57 ` Aw: " Frank Wunderlich
2022-04-09 11:01 ` Heiko Stuebner
2022-04-09 11:13 ` Aw: " Frank Wunderlich
2022-04-09 11:14 ` Aw: " Peter Geis
2022-04-09 11:30 ` Peter Geis
2022-04-09 11:35 ` Heiko Stuebner
2022-04-09 11:51 ` Peter Geis
2022-04-09 11:56 ` Aw: " Frank Wunderlich
2022-04-09 15:26 ` Peter Geis
2022-04-10 16:53 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10062144.nUPlyArG6x@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=strit@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).